{"id":14560,"url":"https://patchwork.libcamera.org/api/patches/14560/?format=json","web_url":"https://patchwork.libcamera.org/patch/14560/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211111110605.105202-6-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-11T11:05:56","name":"[libcamera-devel,v3,05/14] ipa: ipu3: agc: Compute the gain for each frame","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9a86a7752233a3e83b58c405b9417379ccff0a59","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14560/mbox/","series":[{"id":2713,"url":"https://patchwork.libcamera.org/api/series/2713/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2713","date":"2021-11-11T11:05:51","name":"IPA: IPU3: Introduce per-frame controls","version":3,"mbox":"https://patchwork.libcamera.org/series/2713/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14560/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14560/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86FCFBF415\n\tfor ;\n\tThu, 11 Nov 2021 11:06:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14F6460369;\n\tThu, 11 Nov 2021 12:06:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7ACD460345\n\tfor ;\n\tThu, 11 Nov 2021 12:06:10 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:e627:8337:a781:d98])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 335531543;\n\tThu, 11 Nov 2021 12:06:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rBYGfTx4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636628770;\n\tbh=LlZGDXH5lxpj6GorSDNn50EUKU2Bjq0JdYuHBX9ctJs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rBYGfTx4iPfxlqtVtRr7GFZoZrvn/b5Qz7yVFiE0Tqh9cN2Dr6EuYvK+MswNZ28ul\n\tYkKmSCPiCEBUFOG3E/Ct5nec1yLosuMuN8jmbKxlVqO/ukms9AfxA39xJZs6TSyFSo\n\tvMuoCTwM3zb1Yo83NJQ6UHURoTr/ycSUhsDd4Ttg=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 11 Nov 2021 12:05:56 +0100","Message-Id":"<20211111110605.105202-6-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211111110605.105202-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211111110605.105202-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 05/14] ipa: ipu3: agc: Compute the gain\n\tfor each frame","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that we have the real exposure applied at each frame, remove the\nearly return based on a frame counter and compute the gain for each\nframe.\n\nInstead of that, introduce a number of startup frames during which the\nfilter speed is 1.0, meaning we apply instantly the exposure value\ncalculated and not a slower filtered one.\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Kieran Bingham \n---\n src/ipa/ipu3/algorithms/agc.cpp | 26 +++++++++++---------------\n 1 file changed, 11 insertions(+), 15 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 0ae575a3..862366ac 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -45,11 +45,6 @@ namespace ipa::ipu3::algorithms {\n \n LOG_DEFINE_CATEGORY(IPU3Agc)\n \n-/* Number of frames to wait before calculating stats on minimum exposure */\n-static constexpr uint32_t kInitialFrameMinAECount = 4;\n-/* Number of frames to wait between new gain/shutter time estimations */\n-static constexpr uint32_t kFrameSkipCount = 6;\n-\n /* Limits for analogue gain values */\n static constexpr double kMinAnalogueGain = 1.0;\n static constexpr double kMaxAnalogueGain = 8.0;\n@@ -69,10 +64,13 @@ static constexpr double kEvGainTarget = 0.5;\n */\n static constexpr uint32_t kMinCellsPerZoneRatio = 255 * 20 / 100;\n \n+/* Number of frames to wait before calculating stats on minimum exposure */\n+static constexpr uint32_t kNumStartupFrames = 10;\n+\n Agc::Agc()\n-\t: frameCount_(0), lastFrame_(0), iqMean_(0.0), lineDuration_(0s),\n-\t minExposureLines_(0), maxExposureLines_(0), filteredExposure_(0s),\n-\t currentExposure_(0s), prevExposureValue_(0s)\n+\t: frameCount_(0), iqMean_(0.0), lineDuration_(0s), minExposureLines_(0),\n+\t maxExposureLines_(0), filteredExposure_(0s), currentExposure_(0s),\n+\t prevExposureValue_(0s)\n {\n }\n \n@@ -159,6 +157,11 @@ void Agc::measureBrightness(const ipu3_uapi_stats_3a *stats,\n void Agc::filterExposure()\n {\n \tdouble speed = 0.2;\n+\n+\t/* Adapt instantly if we are in startup phase */\n+\tif (frameCount_ < kNumStartupFrames)\n+\t\tspeed = 1.0;\n+\n \tif (filteredExposure_ == 0s) {\n \t\t/* DG stands for digital gain.*/\n \t\tfilteredExposure_ = currentExposure_;\n@@ -185,13 +188,6 @@ void Agc::filterExposure()\n */\n void Agc::computeExposure(IPAFrameContext &frameContext)\n {\n-\t/* Algorithm initialization should wait for first valid frames */\n-\t/* \\todo - have a number of frames given by DelayedControls ?\n-\t * - implement a function for IIR */\n-\tif ((frameCount_ < kInitialFrameMinAECount) || (frameCount_ - lastFrame_ < kFrameSkipCount))\n-\t\treturn;\n-\n-\tlastFrame_ = frameCount_;\n \n \t/* Are we correctly exposed ? */\n \tif (std::abs(iqMean_ - kEvGainTarget * knumHistogramBins) <= 1) {\n","prefixes":["libcamera-devel","v3","05/14"]}