[{"id":21055,"web_url":"https://patchwork.libcamera.org/comment/21055/","msgid":"<163733762071.1089182.16094167749101989992@Monstersaurus>","date":"2021-11-19T16:00:20","subject":"Re: [libcamera-devel] [PATCH v3 1/3] ipa: ipu3: Extend ipu3 ipa\n\tinterface for lens controls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Han-Lin Chen (2021-11-11 10:49:56)\n> IPU3Event and IPU3Action use two fields for both libcamera controls and sensor\n> V4L2 controls. The patch extend one more field for lens V4L2 controls\n> for auto focus usage.\n> \n> Signed-off-by: Han-Lin Chen \n\nTo match the Sensor controls, this makes sense to me.\n\nWe are considering making more direct/specific calls rather than going\nthrough the IPU3Event, but until that happens, I think this should get\nintgrated.\n\nEarly integration will help align the requirements, and this patch\nitself isn't too controversial.\n\nI think separation of the control types makes this much clearer, and\nlens controls are clearly distinct from sensor controls ... so...\n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/ipa/ipu3.mojom | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n> index 16e3462e..cc0d822f 100644\n> --- a/include/libcamera/ipa/ipu3.mojom\n> +++ b/include/libcamera/ipa/ipu3.mojom\n> @@ -24,12 +24,14 @@ struct IPU3Event {\n> uint32 bufferId;\n> libcamera.ControlList controls;\n> libcamera.ControlList sensorControls;\n> + libcamera.ControlList lensControls;\n> };\n> \n> struct IPU3Action {\n> IPU3Operations op;\n> libcamera.ControlList controls;\n> libcamera.ControlList sensorControls;\n> + libcamera.ControlList lensControls;\n> };\n> \n> struct IPAConfigInfo {\n> -- \n> 2.34.0.rc1.387.gb447b232ab-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6A09BF415\n\tfor ;\n\tFri, 19 Nov 2021 16:00:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DCF8160371;\n\tFri, 19 Nov 2021 17:00:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE44D600B5\n\tfor ;\n\tFri, 19 Nov 2021 17:00:23 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 811A71C19;\n\tFri, 19 Nov 2021 17:00:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"frREJ1iI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637337623;\n\tbh=hsuPgJ8mDK6yxxMUH9XEpzR2JBSl67VJsVBxruKddCw=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=frREJ1iIJdIaXzesmnrGm1enSpia81bIIJWodVPooVNX/PjlUu+B2ne7o31OYOErj\n\tyRZ8OZNZsQkOvouisAXuVpukcAKqIHj/2GG7YCZtI3naZWcInSGjYHMNcAoM2ql1Pf\n\t5T/FH9Z3eJn7qLh53HwR9jTEgYAlnkusqC6quOkE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211111104958.312070-1-hanlinchen@chromium.org>","References":"<20211111104958.312070-1-hanlinchen@chromium.org>","From":"Kieran Bingham ","To":"Han-Lin Chen ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 19 Nov 2021 16:00:20 +0000","Message-ID":"<163733762071.1089182.16094167749101989992@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 1/3] ipa: ipu3: Extend ipu3 ipa\n\tinterface for lens controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]