[{"id":20838,"web_url":"https://patchwork.libcamera.org/comment/20838/","msgid":"<2093c64c-8ff3-df17-5565-d9fb2c92d9ac@ideasonboard.com>","date":"2021-11-11T03:54:42","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix\n\tminCrop indentation","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch\n\nOn 11/11/21 5:03 AM, Kieran Bingham wrote:\n> When updating the controls the calculation for minCrop incorrectly\n> indents the parameters to scaledBy().\n>\n> Fix it.\n>\n> Signed-off-by: Kieran Bingham \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index eb714aa61099..3cd7383f0e40 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1039,7 +1039,7 @@ int PipelineHandlerIPU3::updateControls(IPU3CameraData *data)\n> \t * top-left corner as we allow application to freely pan the crop area.\n> \t */\n> \tRectangle minCrop = Rectangle(minSize).scaledBy(analogueCrop.size(),\n> -\t\t\t\t\t sensorInfo.outputSize);\n> +\t\t\t\t\t\t\tsensorInfo.outputSize);\n> \n> \tcontrols[&controls::ScalerCrop] = ControlInfo(minCrop, maxCrop, maxCrop);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4BE96BDB1C\n\tfor ;\n\tThu, 11 Nov 2021 03:54:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D12C60233;\n\tThu, 11 Nov 2021 04:54:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B948600BF\n\tfor ;\n\tThu, 11 Nov 2021 04:54:48 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.254])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 27B4CE51;\n\tThu, 11 Nov 2021 04:54:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"e8LL2VxM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636602887;\n\tbh=PLQDm9TagdJ2AR0TFvOLJHBlNaVJwI86D0HE3ozWE8w=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=e8LL2VxMQl5IzUJuXYQnVZmldKjUpJsLC8RDGtvqV6trB5N7VQE+RXjVIYHTvVAX9\n\ts21O4LFdD8sBsVtaxRXTP1SYcersmLs5vQwAIpggD3dAUhhhhfU7tG+LrPwqe0O1Pf\n\tns3RqvyLurWL2BG086ww/S4ITLAjghTcI/momyuA=","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20211110233341.2147832-1-kieran.bingham@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<2093c64c-8ff3-df17-5565-d9fb2c92d9ac@ideasonboard.com>","Date":"Thu, 11 Nov 2021 09:24:42 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211110233341.2147832-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix\n\tminCrop indentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20843,"web_url":"https://patchwork.libcamera.org/comment/20843/","msgid":"<20211111080530.wbn3iax2fjxwmgwn@uno.localdomain>","date":"2021-11-11T08:05:30","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix\n\tminCrop indentation","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Wed, Nov 10, 2021 at 11:33:41PM +0000, Kieran Bingham wrote:\n> When updating the controls the calculation for minCrop incorrectly\n> indents the parameters to scaledBy().\n>\n> Fix it.\n>\n> Signed-off-by: Kieran Bingham \n\nUps,\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index eb714aa61099..3cd7383f0e40 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1039,7 +1039,7 @@ int PipelineHandlerIPU3::updateControls(IPU3CameraData *data)\n> \t * top-left corner as we allow application to freely pan the crop area.\n> \t */\n> \tRectangle minCrop = Rectangle(minSize).scaledBy(analogueCrop.size(),\n> -\t\t\t\t\t sensorInfo.outputSize);\n> +\t\t\t\t\t\t\tsensorInfo.outputSize);\n>\n> \tcontrols[&controls::ScalerCrop] = ControlInfo(minCrop, maxCrop, maxCrop);\n>\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80A81BDB1C\n\tfor ;\n\tThu, 11 Nov 2021 08:04:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4987560345;\n\tThu, 11 Nov 2021 09:04:39 +0100 (CET)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 802ED6032C\n\tfor ;\n\tThu, 11 Nov 2021 09:04:37 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 15977C0004;\n\tThu, 11 Nov 2021 08:04:36 +0000 (UTC)"],"Date":"Thu, 11 Nov 2021 09:05:30 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20211111080530.wbn3iax2fjxwmgwn@uno.localdomain>","References":"<20211110233341.2147832-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211110233341.2147832-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix\n\tminCrop indentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20849,"web_url":"https://patchwork.libcamera.org/comment/20849/","msgid":"<20211111093335.GD4088@pyrite.rasen.tech>","date":"2021-11-11T09:33:35","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix\n\tminCrop indentation","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Wed, Nov 10, 2021 at 11:33:41PM +0000, Kieran Bingham wrote:\n> When updating the controls the calculation for minCrop incorrectly\n> indents the parameters to scaledBy().\n> \n> Fix it.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index eb714aa61099..3cd7383f0e40 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1039,7 +1039,7 @@ int PipelineHandlerIPU3::updateControls(IPU3CameraData *data)\n> \t * top-left corner as we allow application to freely pan the crop area.\n> \t */\n> \tRectangle minCrop = Rectangle(minSize).scaledBy(analogueCrop.size(),\n> -\t\t\t\t\t sensorInfo.outputSize);\n> +\t\t\t\t\t\t\tsensorInfo.outputSize);\n> \n> \tcontrols[&controls::ScalerCrop] = ControlInfo(minCrop, maxCrop, maxCrop);\n> \n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8ACE5BDB1C\n\tfor ;\n\tThu, 11 Nov 2021 09:33:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E11A060345;\n\tThu, 11 Nov 2021 10:33:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 088EE6032C\n\tfor ;\n\tThu, 11 Nov 2021 10:33:44 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 912E7E51;\n\tThu, 11 Nov 2021 10:33:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YN7YR1xY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636623223;\n\tbh=nBAnLcwfdBvjEychZdD0QpL/PalG4lipBdwRv1N85OQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YN7YR1xYioqwXVLopgbY0RlnwWTCwQ7gtS2bUdsFAMYxtj9LSW3eQxz+L7QM3QvVe\n\t2VDWtbn139PXP0aiAhE3oXj2n+6vTRMrQE4tMCUUbIbKMCaRiw34xmSDhy/1TKRCpJ\n\tSXPOnNEUXfWpjYGZdtjxgJNJEFzsX+U1ItSUuW2Q=","Date":"Thu, 11 Nov 2021 18:33:35 +0900","From":"paul.elder@ideasonboard.com","To":"Kieran Bingham ","Message-ID":"<20211111093335.GD4088@pyrite.rasen.tech>","References":"<20211110233341.2147832-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20211110233341.2147832-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix\n\tminCrop indentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]