[{"id":20834,"web_url":"https://patchwork.libcamera.org/comment/20834/","msgid":"<163658678875.2121661.8321834365620714925@Monstersaurus>","date":"2021-11-10T23:26:28","subject":"Re: [libcamera-devel] [PATCH v2 14/14] ipa: ipu3: Pass the\n\tAnalogueGain control","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-10 19:59:01)\n> We can set the controls::AnalogueGain metadata now that AGC is updating\n> it correctly.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Kieran Bingham \n\nEeek. I think I need to revoke this (temporarily? :D) - I think it might be wrong.\n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 9220fea5..e69382f9 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -637,6 +637,8 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n> \n> ctrls.set(controls::ExposureTime, context_.frameContext.agc.exposure * lineDuration_.count());\n> \n> + ctrls.set(controls::AnalogueGain, context_.frameContext.agc.gain);\n> +\n\nI fear that the exposure and gain are now being reported /after running\nthe algorithms.\n\nThat means this metadata is going to report the 'desired' gain/exposure\nthat will be found in a frame about 2 or 3 frames from now.\n\nWhile I think it /should/ be reporting what was given / determined to be\nthe 'input' exposure and gain that comes in.\n\nThis makes me go back to the earlier patch thinking that when the\nexposure and gain are stored in 3/14 - they should be stored separately\nas 'input' parameters.\n\nSame questions now apply to the ExposureTime added from\ncontext_.frameContext.agc.exposure in [13/14]\n\n> /*\n> * \\todo We should be able to add 'anything' (with a Control) in here to\n> * get information to say.\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68249BF415\n\tfor ;\n\tWed, 10 Nov 2021 23:26:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B14266035D;\n\tThu, 11 Nov 2021 00:26:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 730C4600BF\n\tfor ;\n\tThu, 11 Nov 2021 00:26:31 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0214A292;\n\tThu, 11 Nov 2021 00:26:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GyDWz0Od\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636586791;\n\tbh=Wd4PpwVhmcZ8w381Td7ylGfdQqyOnjiSzSJ3WwQ9mTQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=GyDWz0OdpRYODLhGx44jsMGhTJzH9SDKOhkiaL+8oSmOFCGRM4d3kWAuh7VZaRup5\n\tQDRWkALy4mC3zXwDfB1+gz8WtVqXaq6sPvFtH2crgaP/X0cAvn17A8v7VAfIjWzcEY\n\tN4FtbnIsn6551gxv0MdfZwqXdiqVfZJ93zSiYaKY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211110195901.85597-15-jeanmichel.hautbois@ideasonboard.com>","References":"<20211110195901.85597-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211110195901.85597-15-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 10 Nov 2021 23:26:28 +0000","Message-ID":"<163658678875.2121661.8321834365620714925@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 14/14] ipa: ipu3: Pass the\n\tAnalogueGain control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]