[{"id":20831,"web_url":"https://patchwork.libcamera.org/comment/20831/","msgid":"<163658445073.2121661.14884544949398490797@Monstersaurus>","date":"2021-11-10T22:47:30","subject":"Re: [libcamera-devel] [PATCH v2 11/14] ipa: ipu3: Send color\n\ttemperature in the metadata","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-10 19:58:58)\n> Now that the color temperature is updated per-frame, use the value and\n> set the corresponding controls::ColourTemperature.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/ipu3.cpp | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 1111f200..eb8c0dc4 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -632,6 +632,14 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n> (sensorInfo_.pixelRate / 1e6);\n> ctrls.set(controls::FrameDuration, frameDuration);\n> \n> + ctrls.set(controls::ColourTemperature, context_.frameContext.awb.temperatureK);\n> +\n> + /*\n> + * \\todo We should be able to add 'anything' (with a Control) in here to\n> + * get information to say.\n> + * It can be for debug purposes (qcam) or for any other HAL.\n> + */\n\nHrm ... I'm not sure that helps. And if we weren't adding this comment,\nthe one line could have been in the previous patch.\n\nI think that this comment was based on a discussion we had. I was trying\nto say that you could add any arbitrary data you might need to get out\nof the IPA for debug while developing. But I don't think that's a\ngeneral statement that gets a todo, as we wouldn't merge 'any arbitrary'\ndata...\n\n\nIf you want to keep it, then it could be something like\n\n\"\"\"\n\t/*\n\t * \\todo The Metadata provides a path to getting extended data\n\t * out to the application. Further data such as a simplifed Histogram\n\t * might have value to be exposed, however such data may be\n\t * difficult to report in a generically parsable way and we\n\t * likely want to avoid putting platform specific metadata in.\n\t */\n\"\"\"\n\nWith that, or squashed to the previous patch if you prefer, either way:\n\nReviewed-by: Kieran Bingham \n\n> +\n> IPU3Action op;\n> op.op = ActionMetadataReady;\n> op.controls = ctrls;\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB4EDBF415\n\tfor ;\n\tWed, 10 Nov 2021 22:47:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E96EA6035D;\n\tWed, 10 Nov 2021 23:47:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68B1A6033C\n\tfor ;\n\tWed, 10 Nov 2021 23:47:33 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0BAC78B6;\n\tWed, 10 Nov 2021 23:47:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZeVNA1+r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636584453;\n\tbh=JDGaI0VoW56oBOGEc4PYb46XUorBJyRD7toBAh4oVoc=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=ZeVNA1+rsyLAj+utj3j11rf9GHdVUoxLqFM+TKDiJgFuhSYcAiJiy4x57gdC4Dr4c\n\tRM34a1dkf3pwNEkPSNfagQY+L8ybqYl4VHGyIJljjcDJtVdotFo0ytymw1lXI9WZY2\n\tfM3yPMcbmlOd2ptdDUAKQkTpjEvjFlGJ67dPQO3k=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211110195901.85597-12-jeanmichel.hautbois@ideasonboard.com>","References":"<20211110195901.85597-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211110195901.85597-12-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 10 Nov 2021 22:47:30 +0000","Message-ID":"<163658445073.2121661.14884544949398490797@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 11/14] ipa: ipu3: Send color\n\ttemperature in the metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]