[{"id":20790,"web_url":"https://patchwork.libcamera.org/comment/20790/","msgid":"<163653936754.1896795.1842663429262857149@Monstersaurus>","date":"2021-11-10T10:16:07","subject":"Re: [libcamera-devel] [PATCH 1/3] pipeline: raspberrypi: Add const\n\tqualifer in isRaw()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2021-11-10 10:08:00)\n> This function does not modify the pixFmt parameter, so use a const qualifier.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 5e1f227398a9..11d3c2b120dd 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -96,7 +96,7 @@ V4L2DeviceFormat toV4L2DeviceFormat(const V4L2SubdeviceFormat &format,\n> return deviceFormat;\n> }\n> \n> -bool isRaw(PixelFormat &pixFmt)\n> +bool isRaw(const PixelFormat &pixFmt)\n> {\n> /*\n> * The isRaw test might be redundant right now the pipeline handler only\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6463BDB1C\n\tfor ;\n\tWed, 10 Nov 2021 10:16:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D5C56034A;\n\tWed, 10 Nov 2021 11:16:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CB0B60128\n\tfor ;\n\tWed, 10 Nov 2021 11:16:10 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A8EBB292;\n\tWed, 10 Nov 2021 11:16:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BU1qvFkC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636539369;\n\tbh=PS4ORlCKgjtS1yWDYpQcawLnsx/jAMDdbVDdkXs5KOE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=BU1qvFkCr7RmD2RJjU6xroG8ugCrZi3IT0JlmoKAvVKqGPPxTsfvDMN6xdkAgJINV\n\tzDz15q2fT/IGyEycdgHwSz0+WXs5EUS9orvK0dhPLGFV66at0JyiYaR8UvO7PoII/6\n\tuKZLm24vjeOZ/91pgQ6Nv7ZMd83wVYNPqKSzoees=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211110100802.349623-1-naush@raspberrypi.com>","References":"<20211110100802.349623-1-naush@raspberrypi.com>","From":"Kieran Bingham ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 10 Nov 2021 10:16:07 +0000","Message-ID":"<163653936754.1896795.1842663429262857149@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH 1/3] pipeline: raspberrypi: Add const\n\tqualifer in isRaw()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Roman Stratiienko ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20817,"web_url":"https://patchwork.libcamera.org/comment/20817/","msgid":"<5c330a2b-de5c-003b-5193-d7324a1429b4@ideasonboard.com>","date":"2021-11-10T16:54:44","subject":"Re: [libcamera-devel] [PATCH 1/3] pipeline: raspberrypi: Add const\n\tqualifer in isRaw()","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch\n\nOn 11/10/21 3:38 PM, Naushir Patuck wrote:\n> This function does not modify the pixFmt parameter, so use a const qualifier.\n>\n> Signed-off-by: Naushir Patuck \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 5e1f227398a9..11d3c2b120dd 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -96,7 +96,7 @@ V4L2DeviceFormat toV4L2DeviceFormat(const V4L2SubdeviceFormat &format,\n> \treturn deviceFormat;\n> }\n> \n> -bool isRaw(PixelFormat &pixFmt)\n> +bool isRaw(const PixelFormat &pixFmt)\n> {\n> \t/*\n> \t * The isRaw test might be redundant right now the pipeline handler only","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F615BDB1C\n\tfor ;\n\tWed, 10 Nov 2021 16:54:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 66BD26035D;\n\tWed, 10 Nov 2021 17:54:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 21D8F6033C\n\tfor ;\n\tWed, 10 Nov 2021 17:54:50 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.5])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 013CD8BB;\n\tWed, 10 Nov 2021 17:54:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OxDbcKYP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636563289;\n\tbh=r0mHSilXSm1tk+St2BWkW6GrRbl9SKA0LuMKsBFbLN8=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=OxDbcKYP5QvAEgG8YRXxnmb2uojo6RYhQ93eR2SNHnPzvz+hRgyJUbf1uXaEnUUAV\n\tSiNqdmXlos+1djNvl5ssjLHHxzZo047rfzUdp4PtTLP0Yk5jxreOHvU9MJLL1ShOSY\n\tWzejarQcHRA3+dP2/d5AJ5x1TqHntCTS+ZV9SPU4=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211110100802.349623-1-naush@raspberrypi.com>","From":"Umang Jain ","Message-ID":"<5c330a2b-de5c-003b-5193-d7324a1429b4@ideasonboard.com>","Date":"Wed, 10 Nov 2021 22:24:44 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211110100802.349623-1-naush@raspberrypi.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 1/3] pipeline: raspberrypi: Add const\n\tqualifer in isRaw()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Roman Stratiienko ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20861,"web_url":"https://patchwork.libcamera.org/comment/20861/","msgid":"","date":"2021-11-11T14:03:33","subject":"Re: [libcamera-devel] [PATCH 1/3] pipeline: raspberrypi: Add const\n\tqualifer in isRaw()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Wed, Nov 10, 2021 at 10:08:00AM +0000, Naushir Patuck wrote:\n> This function does not modify the pixFmt parameter, so use a const qualifier.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 5e1f227398a9..11d3c2b120dd 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -96,7 +96,7 @@ V4L2DeviceFormat toV4L2DeviceFormat(const V4L2SubdeviceFormat &format,\n> \treturn deviceFormat;\n> }\n> \n> -bool isRaw(PixelFormat &pixFmt)\n> +bool isRaw(const PixelFormat &pixFmt)\n\nYou could even pass the pixel format by value.\n\nReviewed-by: Laurent Pinchart \n\n> {\n> \t/*\n> \t * The isRaw test might be redundant right now the pipeline handler only","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31D31BF415\n\tfor ;\n\tThu, 11 Nov 2021 14:03:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7798F600B5;\n\tThu, 11 Nov 2021 15:03:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 47455600B5\n\tfor ;\n\tThu, 11 Nov 2021 15:03:56 +0100 (CET)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C960ADEE;\n\tThu, 11 Nov 2021 15:03:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"E/uyF3WK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636639435;\n\tbh=xFUXJ7qqDxCvt5MhgtLzCRSnyqv2Y53nhrku2Np8rQU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=E/uyF3WKy1117c6dvvqo7rGx1xit53zmPCGuwEmbBZsF7hYcKpgNA6NtaqirkwqX9\n\tmpCn05r89gWma/loUaC0y0v8esCnMSCg5b2hI9mcNfV2kw/ngZiYpIUAyfDZKej1tQ\n\tbmWKYiOpdMp1MyDrlhQTU4HdO5h1ZQHYUh1XOyqY=","Date":"Thu, 11 Nov 2021 16:03:33 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20211110100802.349623-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211110100802.349623-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] pipeline: raspberrypi: Add const\n\tqualifer in isRaw()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org,\n\tRoman Stratiienko ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]