{"id":14508,"url":"https://patchwork.libcamera.org/api/patches/14508/?format=json","web_url":"https://patchwork.libcamera.org/patch/14508/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211110072207.3273703-1-hiroh@chromium.org>","date":"2021-11-10T07:22:04","name":"[libcamera-devel,v6,1/4] lc-compliance: Build with gtest in subprojects","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"bf7c1b01bad8ee06236db0dbb415d71e4494cfd3","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14508/mbox/","series":[{"id":2701,"url":"https://patchwork.libcamera.org/api/series/2701/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2701","date":"2021-11-10T07:22:04","name":"[libcamera-devel,v6,1/4] lc-compliance: Build with gtest in subprojects","version":6,"mbox":"https://patchwork.libcamera.org/series/2701/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14508/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14508/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2FE9DBF415\n\tfor ;\n\tWed, 10 Nov 2021 07:22:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E0CB6034E;\n\tWed, 10 Nov 2021 08:22:16 +0100 (CET)","from mail-pf1-x434.google.com (mail-pf1-x434.google.com\n\t[IPv6:2607:f8b0:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 737C460234\n\tfor ;\n\tWed, 10 Nov 2021 08:22:15 +0100 (CET)","by mail-pf1-x434.google.com with SMTP id n85so1834177pfd.10\n\tfor ;\n\tTue, 09 Nov 2021 23:22:15 -0800 (PST)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:4a73:e1bd:9b3f:4903])\n\tby smtp.gmail.com with ESMTPSA id\n\tr1sm5073669pjm.23.2021.11.09.23.22.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Nov 2021 23:22:12 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"e2unmHV2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=YE5KQnJ22RaCNYBTSjV2YzUxCwMlx+/X3tplBUGoB4Y=;\n\tb=e2unmHV2WyHoZ1gFGot7hqPZ9uNE6t7SgZXyn6Eu7QOHwwWb6MDTIlMty2NDM85TPI\n\tP+oS1v8NyzXKqggqzdEc1YDbT+s2J/SdMesp/WiR5r40Lc+zOD4q5CxIpJv2D5ySWWZB\n\tMsgrQrnLZA2vFgnt1/KB/0F3YuxCEv4eTKjRI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=YE5KQnJ22RaCNYBTSjV2YzUxCwMlx+/X3tplBUGoB4Y=;\n\tb=eUCf4tTyUV5yN0X9FUXqTtAYWNrj6oDmCWn+EhRKDkTiV3vVrabM0PMBvm/R2hA7Y3\n\tWRCiijqfZvutXUU1e+U1eeb8n6Hdj3tnG+DnKkkbd9R0g/DyeQPKgrEHysCHS7/ACY6z\n\toaps3fKrFx8fMAjCt6ngeGIDPzs8yGTWLEPDSH9Fo1IT1OA/5h4SGM7etlM/modoLTyM\n\t20UdqcHA0WdaMyNI08UQmEvGI0YKNwp5tbH0+Z5+tHeks0KpP3lpNWGfMP6Z+O3Mcir1\n\tGyLgc5AjSItR3sblr2wpJKejBFOIPzxxJ5cgoW6TZgZSCjowMedvuWw1uRMefMV6XEE4\n\tx/yg==","X-Gm-Message-State":"AOAM531Lc6kt4z2hmV/BqZK/AKL6X+nL2lZrSCIk2pU6aTxplNQFavCA\n\taYOHUYlQPVpobh+EU5o2Q1LsYxp8PUaSuQ==","X-Google-Smtp-Source":"ABdhPJzUW/czDsdIFq80cqaTiSqCHBZsvsN215MH40kIpBlQEOQ8MYlbcnxjaiIur7Buq7GRNFiKiQ==","X-Received":"by 2002:a63:ab48:: with SMTP id\n\tk8mr10426839pgp.307.1636528933156; \n\tTue, 09 Nov 2021 23:22:13 -0800 (PST)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 10 Nov 2021 16:22:04 +0900","Message-Id":"<20211110072207.3273703-1-hiroh@chromium.org>","X-Mailer":"git-send-email 2.34.0.rc0.344.g81b53c2807-goog","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 1/4] lc-compliance: Build with gtest in\n\tsubprojects","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"libgtest-dev is provided as a static library at least Debian 10.\nThe compiler and linker to create the static library might be\ndifferent from ones used for libcamera. This causes a problem\nupon linking.\n\nThis puts gtest code to subprojects, builds the code and link it\nfor lc-compliance. However, libgtest is locally built as a library on\nChromeOS and thus the used compiler and linker are the same as one\nused for libcamera. We don't do these on ChromeOS build environment.\n\nSigned-off-by: Hirokazu Honda \nTested-by: Jacopo Mondi \nReviewed-by: Kieran Bingham \n---\n README.rst | 2 +-\n src/lc-compliance/meson.build | 16 ++++++++++++++--\n subprojects/.gitignore | 4 +++-\n subprojects/gtest.wrap | 14 ++++++++++++++\n 4 files changed, 32 insertions(+), 4 deletions(-)\n create mode 100644 subprojects/gtest.wrap","diff":"diff --git a/README.rst b/README.rst\nindex 8af5f118..c48b4dba 100644\n--- a/README.rst\n+++ b/README.rst\n@@ -99,7 +99,7 @@ for android: [optional]\n libexif-dev libjpeg-dev libyaml-dev\n \n for lc-compliance: [optional]\n- libevent-dev libgtest-dev\n+ libevent-dev\n \n Using GStreamer plugin\n ~~~~~~~~~~~~~~~~~~~~~~\ndiff --git a/src/lc-compliance/meson.build b/src/lc-compliance/meson.build\nindex aa5852f6..8c43ef12 100644\n--- a/src/lc-compliance/meson.build\n+++ b/src/lc-compliance/meson.build\n@@ -1,15 +1,27 @@\n # SPDX-License-Identifier: CC0-1.0\n \n libevent = dependency('libevent_pthreads', required : get_option('lc-compliance'))\n-libgtest = dependency('gtest', required : get_option('lc-compliance'))\n \n-if not (libevent.found() and libgtest.found())\n+if not libevent.found()\n lc_compliance_enabled = false\n subdir_done()\n endif\n \n lc_compliance_enabled = true\n \n+if get_option('android_platform') == 'cros'\n+ libgtest = dependency('gtest', required : get_option('lc-compliance'))\n+\n+ if not libgtest.found()\n+ lc_compliance_enabled = false\n+ subdir_done()\n+ endif\n+\n+else\n+ libgtest_sp = subproject('gtest')\n+ libgtest = libgtest_sp.get_variable('gtest_dep')\n+endif\n+\n lc_compliance_sources = files([\n '../cam/event_loop.cpp',\n '../cam/options.cpp',\ndiff --git a/subprojects/.gitignore b/subprojects/.gitignore\nindex 410b8bd6..391fde2c 100644\n--- a/subprojects/.gitignore\n+++ b/subprojects/.gitignore\n@@ -1 +1,3 @@\n-/libyuv\n\\ No newline at end of file\n+/googletest-release*\n+/libyuv\n+/packagecache\n\\ No newline at end of file\ndiff --git a/subprojects/gtest.wrap b/subprojects/gtest.wrap\nnew file mode 100644\nindex 00000000..40128b35\n--- /dev/null\n+++ b/subprojects/gtest.wrap\n@@ -0,0 +1,14 @@\n+[wrap-file]\n+directory = googletest-release-1.11.0\n+source_url = https://github.com/google/googletest/archive/release-1.11.0.zip\n+source_filename = gtest-1.11.0.zip\n+source_hash = 353571c2440176ded91c2de6d6cd88ddd41401d14692ec1f99e35d013feda55a\n+patch_filename = gtest_1.11.0-1_patch.zip\n+patch_url = https://wrapdb.mesonbuild.com/v2/gtest_1.11.0-1/get_patch\n+patch_hash = d38c39184384608b08419be52aed1d0f9d9d1b5ed71c0c35e51cccbdddab7084\n+\n+[provide]\n+gtest = gtest_dep\n+gtest_main = gtest_main_dep\n+gmock = gmock_dep\n+gmock_main = gmock_main_dep\n","prefixes":["libcamera-devel","v6","1/4"]}