[{"id":20714,"web_url":"https://patchwork.libcamera.org/comment/20714/","msgid":"<20211108141227.dkaglbvg5u6e4rfh@uno.localdomain>","date":"2021-11-08T14:12:27","subject":"Re: [libcamera-devel] [PATCH 20/22] ipa: ipu3: Send color\n\ttemperature in the metadata","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Jean-Michel\n\nOn Mon, Nov 08, 2021 at 02:13:48PM +0100, Jean-Michel Hautbois wrote:\n> Now that the color temperature is updated per-frame, use the value and\n> set the corresponding controls::ColourTemperature.\n>\n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/ipu3.cpp | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n>\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 9b20e8ab..ca3f2417 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -696,6 +696,14 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n> \t\t\t\t(sensorInfo_.pixelRate / 1e6);\n> \tctrls.set(controls::FrameDuration, frameDuration);\n>\n> +\tctrls.set(controls::ColourTemperature, context_.frameContext->awb.temperatureK);\n> +\n> +\t/*\n> +\t * \\todo We should be able to add 'anything' (with a Control) in here to\n> +\t * get information to say.\n> +\t * It can be for debug purposes (qcam) or for any other HAL.\n> +\t */\n> +\n\nIs this comment a leftover ?\n\n> \tIPU3Action op;\n> \top.op = ActionMetadataReady;\n> \top.controls = ctrls;\n> --\n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1ABA3BDB1C\n\tfor ;\n\tMon, 8 Nov 2021 14:11:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD31B6035D;\n\tMon, 8 Nov 2021 15:11:36 +0100 (CET)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 498396032C\n\tfor ;\n\tMon, 8 Nov 2021 15:11:35 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 5935040004;\n\tMon, 8 Nov 2021 14:11:34 +0000 (UTC)"],"Date":"Mon, 8 Nov 2021 15:12:27 +0100","From":"Jacopo Mondi ","To":"Jean-Michel Hautbois ","Message-ID":"<20211108141227.dkaglbvg5u6e4rfh@uno.localdomain>","References":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211108131350.130665-21-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211108131350.130665-21-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 20/22] ipa: ipu3: Send color\n\ttemperature in the metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20820,"web_url":"https://patchwork.libcamera.org/comment/20820/","msgid":"<6dc92b37-1c2c-1f05-00e4-ae5bfac04acc@ideasonboard.com>","date":"2021-11-10T17:58:51","subject":"Re: [libcamera-devel] [PATCH 20/22] ipa: ipu3: Send color\n\ttemperature in the metadata","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 08/11/2021 15:12, Jacopo Mondi wrote:\n> Hi Jean-Michel\n> \n> On Mon, Nov 08, 2021 at 02:13:48PM +0100, Jean-Michel Hautbois wrote:\n>> Now that the color temperature is updated per-frame, use the value and\n>> set the corresponding controls::ColourTemperature.\n>>\n>> Signed-off-by: Jean-Michel Hautbois \n>> ---\n>> src/ipa/ipu3/ipu3.cpp | 8 ++++++++\n>> 1 file changed, 8 insertions(+)\n>>\n>> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n>> index 9b20e8ab..ca3f2417 100644\n>> --- a/src/ipa/ipu3/ipu3.cpp\n>> +++ b/src/ipa/ipu3/ipu3.cpp\n>> @@ -696,6 +696,14 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n>> \t\t\t\t(sensorInfo_.pixelRate / 1e6);\n>> \tctrls.set(controls::FrameDuration, frameDuration);\n>>\n>> +\tctrls.set(controls::ColourTemperature, context_.frameContext->awb.temperatureK);\n>> +\n>> +\t/*\n>> +\t * \\todo We should be able to add 'anything' (with a Control) in here to\n>> +\t * get information to say.\n>> +\t * It can be for debug purposes (qcam) or for any other HAL.\n>> +\t */\n>> +\n> \n> Is this comment a leftover ?\n\nNot really, I think it is worth saying this is were controls will be \nupdated, but perhaps should I reword it somehow ?\n\n> \n>> \tIPU3Action op;\n>> \top.op = ActionMetadataReady;\n>> \top.controls = ctrls;\n>> --\n>> 2.32.0\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14FEEBF415\n\tfor ;\n\tWed, 10 Nov 2021 17:58:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6BC1E6034E;\n\tWed, 10 Nov 2021 18:58:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D92776033C\n\tfor ;\n\tWed, 10 Nov 2021 18:58:53 +0100 (CET)","from [IPV6:2a01:e0a:169:7140:7713:3465:89e6:c5cd] (unknown\n\t[IPv6:2a01:e0a:169:7140:7713:3465:89e6:c5cd])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 725388BB;\n\tWed, 10 Nov 2021 18:58:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HNAsCCAM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636567133;\n\tbh=Ne0OHzBJWQZUkpgbDgGu6HXOYbmwi1rc0PI1X8QW8JE=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=HNAsCCAMOGihg+88z40Btcr0q9qBm46k80ApGg0a45PgF93xsc8jfDcXjp9QNOqHT\n\tibonnLFa1BYSLmR9WZ9Vuk/PHEY3CkmaQqfjUcaIgHaJ9bCcyKRXtktgvYhJNrxXBw\n\t9xWW7YIZoYuLRmltcgvrfpCZgLqpMG4p8cyDtt+U=","Message-ID":"<6dc92b37-1c2c-1f05-00e4-ae5bfac04acc@ideasonboard.com>","Date":"Wed, 10 Nov 2021 18:58:51 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.2.1","Content-Language":"en-US","To":"Jacopo Mondi ","References":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211108131350.130665-21-jeanmichel.hautbois@ideasonboard.com>\n\t<20211108141227.dkaglbvg5u6e4rfh@uno.localdomain>","From":"Jean-Michel Hautbois ","In-Reply-To":"<20211108141227.dkaglbvg5u6e4rfh@uno.localdomain>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 20/22] ipa: ipu3: Send color\n\ttemperature in the metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]