[{"id":20716,"web_url":"https://patchwork.libcamera.org/comment/20716/","msgid":"<163638172812.275423.8004781643125253916@Monstersaurus>","date":"2021-11-08T14:28:48","subject":"Re: [libcamera-devel] [PATCH 19/22] ipa: ipu3: awb: Add support for\n\tcolor temperature","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-08 13:13:47)\n> The AWB estimates the color temperature, but it is not used at all. It\n> can be useful for debug purpose at least, but also for lux estimation\n> later, to be able to know the temperature estimated for a given frame.\n> \n> Add a new member to the IPAFrameContext::awb for this purpose, and\n> update the value in AWB.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/algorithms/awb.cpp | 1 +\n> src/ipa/ipu3/ipa_context.cpp | 3 +++\n> src/ipa/ipu3/ipa_context.h | 2 ++\n> 3 files changed, 6 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n> index bd55d377..a3a5ac66 100644\n> --- a/src/ipa/ipu3/algorithms/awb.cpp\n> +++ b/src/ipa/ipu3/algorithms/awb.cpp\n> @@ -385,6 +385,7 @@ void Awb::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n> context.frameContext->awb.gains.blue = asyncResults_.blueGain;\n> context.frameContext->awb.gains.green = asyncResults_.greenGain;\n> context.frameContext->awb.gains.red = asyncResults_.redGain;\n> + context.frameContext->awb.temperatureK = asyncResults_.temperatureK;\n> }\n> \n> constexpr uint16_t Awb::threshold(float value)\n> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n> index ea92be77..9c0407df 100644\n> --- a/src/ipa/ipu3/ipa_context.cpp\n> +++ b/src/ipa/ipu3/ipa_context.cpp\n> @@ -117,6 +117,9 @@ namespace libcamera::ipa::ipu3 {\n> *\n> * \\var IPAFrameContext::awb.gains.blue\n> * \\brief White balance gain for B channel\n> + *\n> + * \\var IPAFrameContext::awb.temperatureK\n> + * \\brief Color temperature estimated\n\nI'd write this as:\n\n \\brief Estimated color temperature\n\nReviewed-by: Kieran Bingham \n\n> */\n> \n> /**\n> diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\n> index 69780915..3566dea1 100644\n> --- a/src/ipa/ipu3/ipa_context.h\n> +++ b/src/ipa/ipu3/ipa_context.h\n> @@ -45,6 +45,8 @@ struct IPAFrameContext {\n> double green;\n> double blue;\n> } gains;\n> +\n> + double temperatureK;\n> } awb;\n> \n> struct {\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 670A7BF415\n\tfor ;\n\tMon, 8 Nov 2021 14:28:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE3DA6032C;\n\tMon, 8 Nov 2021 15:28:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4713F6032C\n\tfor ;\n\tMon, 8 Nov 2021 15:28:51 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CD21B18CE;\n\tMon, 8 Nov 2021 15:28:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qTJzI4dj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636381730;\n\tbh=zWKqw/EBB9dc5PP83H6pyL05P3T5OWnKlxaNjwIPsLU=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=qTJzI4dj1NjpfGQGoiFJP+sWO9iv3lKRlEp3AOJpg1jFjmxWtCJh8HoRY4RwgXigj\n\tjvUJ73hevXMSuykc7FmTBfj/BlLVX/RP3+nQIih8N3D6NSksZwui5Ri6WfhfVJKjPh\n\t+SCR2qcMOnoCmdYdidkabMMB9ajtrqYwtBQDgHGM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211108131350.130665-20-jeanmichel.hautbois@ideasonboard.com>","References":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211108131350.130665-20-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 08 Nov 2021 14:28:48 +0000","Message-ID":"<163638172812.275423.8004781643125253916@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH 19/22] ipa: ipu3: awb: Add support for\n\tcolor temperature","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]