{"id":14487,"url":"https://patchwork.libcamera.org/api/patches/14487/?format=json","web_url":"https://patchwork.libcamera.org/patch/14487/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211108131350.130665-19-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-08T13:13:46","name":"[libcamera-devel,18/22] ipa: ipu3: Move the sensor update controls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"41dace93c42092b162f5e0d98be92efb2a0466f1","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14487/mbox/","series":[{"id":2696,"url":"https://patchwork.libcamera.org/api/series/2696/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2696","date":"2021-11-08T13:13:28","name":"IPA: IPU3: Introduce per-frame controls","version":1,"mbox":"https://patchwork.libcamera.org/series/2696/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14487/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14487/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 991BEC3252\n\tfor ;\n\tMon, 8 Nov 2021 13:14:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D7806049B;\n\tMon, 8 Nov 2021 14:14:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E694060398\n\tfor ;\n\tMon, 8 Nov 2021 14:14:02 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:c2bb:76d0:68d7:a9a5])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A187B187C;\n\tMon, 8 Nov 2021 14:14:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"O66lnqQr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636377242;\n\tbh=rg5fIYEY9UfUrV1R3AkxL5UAWNSg3Nzf/MnmXTE7/P4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=O66lnqQrwkulj98zx8CpJcpLXb/jSetQ2aQdXSgMkv3j6BYP5tM5ORLShAmSG7ig5\n\tHcbvw8XCyAqJYOrm81SSh9ARLaURWpwGklNfOAWa8VowmUqc84OGSWtLfGEhZdYD7v\n\t8kMQmHgX6tWZZhfS54ys6bn+LI9/bxg8GP7t4DcI=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 8 Nov 2021 14:13:46 +0100","Message-Id":"<20211108131350.130665-19-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 18/22] ipa: ipu3: Move the sensor update\n\tcontrols","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We want the setControls() to use the cached exposure_ and gain_ values,\nso move the frame context update of those variables into\nframeCompleted() call instead.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/ipu3.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex b60ab7e7..9b20e8ab 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -534,6 +534,10 @@ void IPAIPU3::frameStarted([[maybe_unused]] unsigned int frame)\n \n void IPAIPU3::frameCompleted([[maybe_unused]] unsigned int frame)\n {\n+\t/* Apply the exposure and gain updated values */\n+\texposure_ = context_.frameContext->agc.exposure;\n+\tgain_ = camHelper_->gainCode(context_.frameContext->agc.gain);\n+\n \t/*\n \t * Remove the pointer from the queue, it should not be accessed\n \t * anymore and delete it.\n@@ -711,10 +715,6 @@ void IPAIPU3::setControls(unsigned int frame)\n \tIPU3Action op;\n \top.op = ActionSetSensorControls;\n \n-\t/* Apply the exposure and gain updated values */\n-\texposure_ = context_.frameContext->agc.exposure;\n-\tgain_ = camHelper_->gainCode(context_.frameContext->agc.gain);\n-\n \tControlList ctrls(ctrls_);\n \tctrls.set(V4L2_CID_EXPOSURE, static_cast(exposure_));\n \tctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast(gain_));\n","prefixes":["libcamera-devel","18/22"]}