[{"id":20727,"web_url":"https://patchwork.libcamera.org/comment/20727/","msgid":"<163638645036.275423.10807534149566114854@Monstersaurus>","date":"2021-11-08T15:47:30","subject":"Re: [libcamera-devel] [PATCH 16/22] ipa: ipu3: Introduce sensor\n\tcontrols","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-08 13:13:44)\n> Pass the sensor controls as well as the libcamera controls to\n> processControl() on an EventProcessControls event received. This will be\n> used to populate the frame context.\n\nI'm ... really still not sure that this is the right time to get sensor\ncontrols. I'm not convinced it's getting the right data, at the right\ntime.\n\nHopefully I'll be proven wrong later...\n\n> \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/ipu3.cpp | 10 +++++++---\n> 1 file changed, 7 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index dcf4da65..177c5c2f 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -151,7 +151,9 @@ private:\n> ControlInfoMap *ipaControls);\n> void updateSessionConfiguration(const IPACameraSensorInfo &sensorInfo,\n> const ControlInfoMap &sensorControls);\n> - void processControls(unsigned int frame, const ControlList &controls);\n> + void processControls(unsigned int frame,\n> + const ControlList &controls,\n> + const ControlList &sensorCtrls);\n> void fillParams(unsigned int frame, ipu3_uapi_params *params);\n> void parseStatistics(unsigned int frame,\n> int64_t frameTimestamp,\n> @@ -549,7 +551,7 @@ void IPAIPU3::processEvent(const IPU3Event &event)\n> * a new frame.\n> */\n> frameStarted(event.frame);\n> - processControls(event.frame, event.controls);\n> + processControls(event.frame, event.controls, event.sensorControls);\n> break;\n> }\n> case EventFillParams: {\n> @@ -601,12 +603,14 @@ void IPAIPU3::processEvent(const IPU3Event &event)\n> * \\brief Process a control list for a request from the application\n> * \\param[in] frame The number of the frame which will be processed next\n> * \\param[in] controls The controls for the \\a frame\n> + * \\param[in] controls The sensor controls for the \\a frame\n> *\n> * Parse the request to handle any IPA-managed controls that were set from the\n> * application such as manual sensor settings.\n> */\n> void IPAIPU3::processControls([[maybe_unused]] unsigned int frame,\n> - [[maybe_unused]] const ControlList &controls)\n> + [[maybe_unused]] const ControlList &controls,\n> + [[maybe_unused]] const ControlList &sensorCtrls)\n> {\n> /* \\todo Start processing for 'frame' based on 'controls'. */\n> }\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7CF3EBF415\n\tfor ;\n\tMon, 8 Nov 2021 15:47:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3527F6035D;\n\tMon, 8 Nov 2021 16:47:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3570B6032C\n\tfor ;\n\tMon, 8 Nov 2021 16:47:33 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF26C4A6;\n\tMon, 8 Nov 2021 16:47:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OPrHUpRZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636386453;\n\tbh=cQ99Ystte7syeILW9y6QK9RcShLMOQbX5ecFa/Xgj04=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=OPrHUpRZ0r9D83FLhtB5UnJxv3EcvChKSINzgU01ZWLpt1QLJiZExZvp6nmdXOKrX\n\tZSAl9TzBWGm94Yge6Z9WLk+DQ8AhbarSwI5zyEYTVmnXmIqNflfmBscq/HkprYmI2E\n\t1WfWkh5JWMhY1axzCgztwDmwcyfF7MnFJ5Mj6xyU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211108131350.130665-17-jeanmichel.hautbois@ideasonboard.com>","References":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211108131350.130665-17-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 08 Nov 2021 15:47:30 +0000","Message-ID":"<163638645036.275423.10807534149566114854@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH 16/22] ipa: ipu3: Introduce sensor\n\tcontrols","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]