{"id":14484,"url":"https://patchwork.libcamera.org/api/patches/14484/?format=json","web_url":"https://patchwork.libcamera.org/patch/14484/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211108131350.130665-16-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-08T13:13:43","name":"[libcamera-devel,15/22] ipa: ipu3: Mark the beginning and and of a frame","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"23bf398b9239b54c0df1d741d81866a347908eae","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14484/mbox/","series":[{"id":2696,"url":"https://patchwork.libcamera.org/api/series/2696/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2696","date":"2021-11-08T13:13:28","name":"IPA: IPU3: Introduce per-frame controls","version":1,"mbox":"https://patchwork.libcamera.org/series/2696/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14484/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14484/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CB25BDB1C\n\tfor ;\n\tMon, 8 Nov 2021 13:14:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7C166034A;\n\tMon, 8 Nov 2021 14:14:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 612736036C\n\tfor ;\n\tMon, 8 Nov 2021 14:14:02 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:c2bb:76d0:68d7:a9a5])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1AB971853;\n\tMon, 8 Nov 2021 14:14:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XFPLJ0Yg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636377242;\n\tbh=47OtOxB8pGy1t3K0IQ656RXKkOy86iLRbjLJf3XaLac=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XFPLJ0YgGo4iCIqC9so58FOQcblOGRuVMERkGBDDVkHFOc0Rf5PrTwBiOMwURdNZF\n\tMrjjtbJS8N4bOymp9U96rqj8dVwezGd0SL8sNiA49lQ1nxG8ioIu+vvy3KMnwI0GTe\n\talZXnm1OpSK2fh7KgeRLDFkYihcZqE+L71jsrC7I=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 8 Nov 2021 14:13:43 +0100","Message-Id":"<20211108131350.130665-16-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 15/22] ipa: ipu3: Mark the beginning and\n\tand of a frame","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Introduce the skeleton for two functions which will be used to\ninstantiate a frame context, and do everything needed when a frame is\nreceived. Do the same for the other end, once the algorithms have run\nand updated the frame context to later deallocate the corresponding\nframe context.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/ipu3.cpp | 31 +++++++++++++++++++++++++++++++\n 1 file changed, 31 insertions(+)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 62df7819..dcf4da65 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -160,6 +160,14 @@ private:\n \tvoid setControls(unsigned int frame);\n \tvoid calculateBdsGrid(const Size &bdsOutputSize);\n \n+\t/*\n+\t * Internal events that mark the beginning of processing a new frame\n+\t * to the point that it has successfully completed processing its\n+\t * statistics.\n+\t */\n+\tvoid frameStarted(unsigned int frame);\n+\tvoid frameCompleted(unsigned int frame);\n+\n \tstd::map buffers_;\n \n \tControlInfoMap ctrls_;\n@@ -510,6 +518,14 @@ void IPAIPU3::unmapBuffers(const std::vector &ids)\n \t}\n }\n \n+void IPAIPU3::frameStarted([[maybe_unused]] unsigned int frame)\n+{\n+}\n+\n+void IPAIPU3::frameCompleted([[maybe_unused]] unsigned int frame)\n+{\n+}\n+\n /**\n * \\brief Process an event generated by the pipeline handler\n * \\param[in] event The event sent from pipeline handler\n@@ -525,6 +541,14 @@ void IPAIPU3::processEvent(const IPU3Event &event)\n {\n \tswitch (event.op) {\n \tcase EventProcessControls: {\n+\t\t/*\n+\t\t * To save incurring extra IPC calls, we do not send explicit events\n+\t\t * when a new request is started or completed.\n+\t\t * ProcessControls is the first event handled upon receipt of a new\n+\t\t * request, so we can handle all actions required to start processing\n+\t\t * a new frame.\n+\t\t */\n+\t\tframeStarted(event.frame);\n \t\tprocessControls(event.frame, event.controls);\n \t\tbreak;\n \t}\n@@ -558,6 +582,13 @@ void IPAIPU3::processEvent(const IPU3Event &event)\n \t\tcontext_.frameContext.agc.gain = camHelper_->gain(event.sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get());\n \n \t\tparseStatistics(event.frame, event.frameTimestamp, stats);\n+\t\t/*\n+\t\t* To save incurring extra IPC calls, we do not send explicit events\n+\t\t* when we have completed all handling of a request.\n+\t\t* Once the statistics are fully processed, we will no longer handle this\n+\t\t* frame.\n+\t\t*/\n+\t\tframeCompleted(event.frame);\n \t\tbreak;\n \t}\n \tdefault:\n","prefixes":["libcamera-devel","15/22"]}