[{"id":20725,"web_url":"https://patchwork.libcamera.org/comment/20725/","msgid":"<163638615601.275423.18312027677260359529@Monstersaurus>","date":"2021-11-08T15:42:36","subject":"Re: [libcamera-devel] [PATCH 14/22] ipa: ipu3: Introduce a queue of\n\tIPAFrameContext","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-08 13:13:42)\n> In order to have multiple frame contexts, we will need a queue to store\n> those. Introduce it in IPAIPU3 but do not use it in this commit yet.\n> \n\nI suspect this should likely be added where it gets used ... let's see\nwhat the next patches bring...\n\n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/ipu3.cpp | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index b4e0d49f..62df7819 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -11,6 +11,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -180,7 +181,10 @@ private:\n> /* Maintain the algorithms used by the IPA */\n> std::list> algorithms_;\n> \n> - /* Local parameter storage */\n> + /* Queue for storing the per-frame context */\n> + std::queue frameContextQueue;\n> +\n> + /* Local context storage */\n> struct IPAContext context_;\n> };\n> \n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D976BDB1C\n\tfor ;\n\tMon, 8 Nov 2021 15:42:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D17E26034A;\n\tMon, 8 Nov 2021 16:42:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C0416032C\n\tfor ;\n\tMon, 8 Nov 2021 16:42:39 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D84C34A6;\n\tMon, 8 Nov 2021 16:42:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"N2FgxnRb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636386158;\n\tbh=1QP+6CFaVuL+JORs35iA2uKGkmqJ8gMYYD5QrdTl6xY=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=N2FgxnRb37IcvgHrkoQzmeUtoS3nzRTHrSy8gweFGv1V08x/x7ahs/ORXxmMrE2yn\n\tbSwQR62Idn6gca1iTVQjSJBo0+10egm0QqWJ60/8AobNoUjQ1bfJTI4QiZsWYndrQl\n\t0bQNFw9mAnschDS11WFzu8dvwPdctlozoLwW7eic=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211108131350.130665-15-jeanmichel.hautbois@ideasonboard.com>","References":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211108131350.130665-15-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 08 Nov 2021 15:42:36 +0000","Message-ID":"<163638615601.275423.18312027677260359529@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH 14/22] ipa: ipu3: Introduce a queue of\n\tIPAFrameContext","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]