[{"id":20723,"web_url":"https://patchwork.libcamera.org/comment/20723/","msgid":"<163638577572.275423.4497834420757327601@Monstersaurus>","date":"2021-11-08T15:36:15","subject":"Re: [libcamera-devel] [PATCH 12/22] ipa: ipu3: Introduce a frame\n\tindex for the IPAFrameContext","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-08 13:13:40)\n> As a preliminery to the usage of a queue of IPAFrameContext introduce a\n> frame index.\n> \n> Signed-off-by: Jean-Michel Hautbois \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/ipu3/ipa_context.cpp | 5 +++++\n> src/ipa/ipu3/ipa_context.h | 2 ++\n> 2 files changed, 7 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n> index 2355a9c7..ea92be77 100644\n> --- a/src/ipa/ipu3/ipa_context.cpp\n> +++ b/src/ipa/ipu3/ipa_context.cpp\n> @@ -133,4 +133,9 @@ namespace libcamera::ipa::ipu3 {\n> * struct ipu3_uapi_gamma_corr_lut for further details.\n> */\n> \n> +/**\n> + * \\var IPAFrameContext::frameId\n> + * \\brief Frame number for this frame context\n> + */\n> +\n> } /* namespace libcamera::ipa::ipu3 */\n> diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\n> index 1e46c61a..ee8f7b55 100644\n> --- a/src/ipa/ipu3/ipa_context.h\n> +++ b/src/ipa/ipu3/ipa_context.h\n> @@ -51,6 +51,8 @@ struct IPAFrameContext {\n> double gamma;\n> struct ipu3_uapi_gamma_corr_lut gammaCorrection;\n> } toneMapping;\n> +\n> + unsigned int frameId;\n> };\n> \n> struct IPAContext {\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5187DBF415\n\tfor ;\n\tMon, 8 Nov 2021 15:36:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 144FA6035D;\n\tMon, 8 Nov 2021 16:36:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A9C0E6032C\n\tfor ;\n\tMon, 8 Nov 2021 16:36:18 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 65DD24A1;\n\tMon, 8 Nov 2021 16:36:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"O1BSsY9R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636385778;\n\tbh=Ko6C6rAdynYC1q/9W6ZQm2I50GwibO6zlG5x9sOuJ/s=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=O1BSsY9RejIyQT9dSU96cwl7Ff9531jET1yJxwHFse/yLYWkd+SP7HK62CT7590yN\n\tCfDU720FIQtm9jY4IsQBg2sd+J1RzRJy2Dq+plOv9Pl8E1HzF1GmU2Al/ybFuNiOoG\n\tfUTMY4S/OGz+JSiM58IUcJOA81hSLP0LkYFCPsyo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211108131350.130665-13-jeanmichel.hautbois@ideasonboard.com>","References":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211108131350.130665-13-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 08 Nov 2021 15:36:15 +0000","Message-ID":"<163638577572.275423.4497834420757327601@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH 12/22] ipa: ipu3: Introduce a frame\n\tindex for the IPAFrameContext","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]