[{"id":20724,"web_url":"https://patchwork.libcamera.org/comment/20724/","msgid":"<163638609436.275423.471991148079704921@Monstersaurus>","date":"2021-11-08T15:41:34","subject":"Re: [libcamera-devel] [PATCH 13/22] ipa: ipu3: Do not access\n\tIPAFrameContext in configure","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-08 13:13:41)\n> The IPAContext contains a SessionConfiguration and a FrameContext. The\n> configure call can populate the SessionConfiguration, but there is not\n> yet a frame.\n> \n> Do not use the IPAFrameContext to prepare the next patches which will\n> introduce per-frame controls.\n\n\"\"\"\nThe IPAContext contains a SessionConfiguration and a FrameContext. The\nconfigure call can populate the SessionConfiguration, but the\nFrameContext stores frame specific data, which should not be managed at\nconfiguration time.\n\nUpdate the algorithm configure calls for AGC and ToneMapping to remove\naccesses to the FrameContext data.\n\"\"\"\n\n\nBut ... can this patch standalone? Are other parts of the algorithm\nrelying upon those values being initialised? Or are they safe to remove\nlike this?\n\n\n\n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/algorithms/agc.cpp | 8 --------\n> src/ipa/ipu3/algorithms/tone_mapping.cpp | 5 +----\n> 2 files changed, 1 insertion(+), 12 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\n> index 3a15f5d9..52cf2753 100644\n> --- a/src/ipa/ipu3/algorithms/agc.cpp\n> +++ b/src/ipa/ipu3/algorithms/agc.cpp\n> @@ -96,14 +96,6 @@ int Agc::configure(IPAContext &context, const IPAConfigInfo &configInfo)\n> minAnalogueGain_ = std::max(context.configuration.agc.minAnalogueGain, kMinAnalogueGain);\n> maxAnalogueGain_ = std::min(context.configuration.agc.maxAnalogueGain, kMaxAnalogueGain);\n> \n> - /* Configure the default exposure and gain. */\n> - context.frameContext.agc.gain = minAnalogueGain_;\n> - context.frameContext.agc.exposure = minShutterSpeed_ / lineDuration_;\n> -\n> - prevExposureValue_ = context.frameContext.agc.gain\n> - * context.frameContext.agc.exposure\n> - * lineDuration_;\n> -\n> return 0;\n> }\n> \n> diff --git a/src/ipa/ipu3/algorithms/tone_mapping.cpp b/src/ipa/ipu3/algorithms/tone_mapping.cpp\n> index 2040eda5..5d74c552 100644\n> --- a/src/ipa/ipu3/algorithms/tone_mapping.cpp\n> +++ b/src/ipa/ipu3/algorithms/tone_mapping.cpp\n> @@ -38,12 +38,9 @@ ToneMapping::ToneMapping()\n> *\n> * \\return 0\n> */\n> -int ToneMapping::configure(IPAContext &context,\n> +int ToneMapping::configure([[maybe_unused]] IPAContext &context,\n> [[maybe_unused]] const IPAConfigInfo &configInfo)\n> {\n> - /* Initialise tone mapping gamma value. */\n> - context.frameContext.toneMapping.gamma = 0.0;\n> -\n> return 0;\n> }\n> \n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0BD9BDB1C\n\tfor ;\n\tMon, 8 Nov 2021 15:41:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 033666035D;\n\tMon, 8 Nov 2021 16:41:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 721E96032C\n\tfor ;\n\tMon, 8 Nov 2021 16:41:37 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17F824A1;\n\tMon, 8 Nov 2021 16:41:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SY0ue+D2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636386097;\n\tbh=u0EFypLklaBwt6jcU0PyploSzAL8G4jMv6ScbS7iamU=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=SY0ue+D2OecLf604FqBaTpOQ8Rn+QRsXhwNCaOmRBMeu1xLRadTh3Dd3X7tNm3VhS\n\tWMYLrHIShVjp2gHSwDh36eoxL9l2hD7dUOa3rAVP1YssY4X5eGXqkQpBMasDRZHcFK\n\tHt4gO7/rVsLqX2IxmXZmURUQn/Lw3GFWaGiFeyGM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211108131350.130665-14-jeanmichel.hautbois@ideasonboard.com>","References":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211108131350.130665-14-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 08 Nov 2021 15:41:34 +0000","Message-ID":"<163638609436.275423.471991148079704921@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH 13/22] ipa: ipu3: Do not access\n\tIPAFrameContext in configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]