{"id":14481,"url":"https://patchwork.libcamera.org/api/patches/14481/?format=json","web_url":"https://patchwork.libcamera.org/patch/14481/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211108131350.130665-14-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-08T13:13:41","name":"[libcamera-devel,13/22] ipa: ipu3: Do not access IPAFrameContext in configure","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"57c672cc2e91fbb25f31ef2df85fc4d1064aa1ec","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14481/mbox/","series":[{"id":2696,"url":"https://patchwork.libcamera.org/api/series/2696/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2696","date":"2021-11-08T13:13:28","name":"IPA: IPU3: Introduce per-frame controls","version":1,"mbox":"https://patchwork.libcamera.org/series/2696/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14481/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14481/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F202C324E\n\tfor ;\n\tMon, 8 Nov 2021 13:14:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 554016038C;\n\tMon, 8 Nov 2021 14:14:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BCDE46034A\n\tfor ;\n\tMon, 8 Nov 2021 14:14:01 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:c2bb:76d0:68d7:a9a5])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F7041BBB;\n\tMon, 8 Nov 2021 14:14:01 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EO1nxSlj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636377241;\n\tbh=RfWb2qBLypl+lelXAetoohvrf7uE+ckZ1qI+84ozJhY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=EO1nxSljFm6l1E2pdy8AVSpv1jbbtCkm+ocjYE9vPYavDImXLchwV8VeQavtMLEFA\n\t5luT8TGaSARSWBJ7vDInc66OItauTsaO1HJGQIXiO+iSn7U/O4P9BT3iH9cudOw51q\n\tZrLqYCvUSt3EE2uxdRYUvAWAcMkxiMGxG88OY+3Y=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 8 Nov 2021 14:13:41 +0100","Message-Id":"<20211108131350.130665-14-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 13/22] ipa: ipu3: Do not access\n\tIPAFrameContext in configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The IPAContext contains a SessionConfiguration and a FrameContext. The\nconfigure call can populate the SessionConfiguration, but there is not\nyet a frame.\n\nDo not use the IPAFrameContext to prepare the next patches which will\nintroduce per-frame controls.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/algorithms/agc.cpp | 8 --------\n src/ipa/ipu3/algorithms/tone_mapping.cpp | 5 +----\n 2 files changed, 1 insertion(+), 12 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 3a15f5d9..52cf2753 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -96,14 +96,6 @@ int Agc::configure(IPAContext &context, const IPAConfigInfo &configInfo)\n \tminAnalogueGain_ = std::max(context.configuration.agc.minAnalogueGain, kMinAnalogueGain);\n \tmaxAnalogueGain_ = std::min(context.configuration.agc.maxAnalogueGain, kMaxAnalogueGain);\n \n-\t/* Configure the default exposure and gain. */\n-\tcontext.frameContext.agc.gain = minAnalogueGain_;\n-\tcontext.frameContext.agc.exposure = minShutterSpeed_ / lineDuration_;\n-\n-\tprevExposureValue_ = context.frameContext.agc.gain\n-\t\t\t * context.frameContext.agc.exposure\n-\t\t\t * lineDuration_;\n-\n \treturn 0;\n }\n \ndiff --git a/src/ipa/ipu3/algorithms/tone_mapping.cpp b/src/ipa/ipu3/algorithms/tone_mapping.cpp\nindex 2040eda5..5d74c552 100644\n--- a/src/ipa/ipu3/algorithms/tone_mapping.cpp\n+++ b/src/ipa/ipu3/algorithms/tone_mapping.cpp\n@@ -38,12 +38,9 @@ ToneMapping::ToneMapping()\n *\n * \\return 0\n */\n-int ToneMapping::configure(IPAContext &context,\n+int ToneMapping::configure([[maybe_unused]] IPAContext &context,\n \t\t\t [[maybe_unused]] const IPAConfigInfo &configInfo)\n {\n-\t/* Initialise tone mapping gamma value. */\n-\tcontext.frameContext.toneMapping.gamma = 0.0;\n-\n \treturn 0;\n }\n \n","prefixes":["libcamera-devel","13/22"]}