[{"id":20712,"web_url":"https://patchwork.libcamera.org/comment/20712/","msgid":"<163637967355.275423.18312448860888119728@Monstersaurus>","date":"2021-11-08T13:54:33","subject":"Re: [libcamera-devel] [PATCH 03/22] ipa: ipu3: Use sensor controls\n\tto update frameContext","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-08 13:13:31)\n> The pipeline handler populates the new sensrControls ControlList, to\n\nsensorControls\n\n> have the effective exposure and gain values for the current frame. This\n> is done when a statistics buffer is received.\n> \n> Make those values the frameContext::agc values for the frame when the\n> EventStatReady event is received.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/ipu3.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index bcc3863b..b4e0d49f 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -549,6 +549,10 @@ void IPAIPU3::processEvent(const IPU3Event &event)\n> const ipu3_uapi_stats_3a *stats =\n> reinterpret_cast(mem.data());\n> \n> + /* \\todo move those into processControls */\n\nWhat's preventing this from being done directly?\n\n> + context_.frameContext.agc.exposure = event.sensorControls.get(V4L2_CID_EXPOSURE).get();\n> + context_.frameContext.agc.gain = camHelper_->gain(event.sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get());\n> +\n> parseStatistics(event.frame, event.frameTimestamp, stats);\n> break;\n> }\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0AE02BF415\n\tfor ;\n\tMon, 8 Nov 2021 13:54:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB3FB60369;\n\tMon, 8 Nov 2021 14:54:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59B7260368\n\tfor ;\n\tMon, 8 Nov 2021 14:54:36 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 168A71853;\n\tMon, 8 Nov 2021 14:54:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LAmZ0RSC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636379676;\n\tbh=6we8GLx2fOZTPLG9LYzjsxo+scpSHFXYa74CGTR/pFg=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=LAmZ0RSCZgk4VNtaQAPwpJz6raz3AYa/7NteNtupcElTPkFerIQWQvQFM0NI1aVRX\n\tkVxX3IQ0Oyi05pT3/HNOqgZm4Mj2/S0hWQvNnSZKPT/RZoHaYrXMYmIW2xVrhsvMLb\n\tvXdSbvYSdc6QzSIo3XH8dDqoAQPwL9Pnx+Xu/6Pg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211108131350.130665-4-jeanmichel.hautbois@ideasonboard.com>","References":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211108131350.130665-4-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 08 Nov 2021 13:54:33 +0000","Message-ID":"<163637967355.275423.18312448860888119728@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH 03/22] ipa: ipu3: Use sensor controls\n\tto update frameContext","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]