{"id":14471,"url":"https://patchwork.libcamera.org/api/patches/14471/?format=json","web_url":"https://patchwork.libcamera.org/patch/14471/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211108131350.130665-3-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-08T13:13:30","name":"[libcamera-devel,02/22] ipu3: ipa: Report effective sensor controls with statistics to IPA","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b9896c449966dbad2362097d27a36e541e9364b8","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14471/mbox/","series":[{"id":2696,"url":"https://patchwork.libcamera.org/api/series/2696/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2696","date":"2021-11-08T13:13:28","name":"IPA: IPU3: Introduce per-frame controls","version":1,"mbox":"https://patchwork.libcamera.org/series/2696/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14471/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14471/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67961BDB1C\n\tfor ;\n\tMon, 8 Nov 2021 13:14:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 050336038B;\n\tMon, 8 Nov 2021 14:14:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D4A0F6034D\n\tfor ;\n\tMon, 8 Nov 2021 14:13:59 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:c2bb:76d0:68d7:a9a5])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8F47B187C;\n\tMon, 8 Nov 2021 14:13:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cIHWJto5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636377239;\n\tbh=JTIA8hYd6p2uyv0s7SYTkhlea7VrdT5sCViiG0lNHxA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cIHWJto5+Xc595D/RiTYWzzGP+zLv7GOUaswrzAEbhqVaCtEgnpVqU24bW2chGPyV\n\tysVK0F6n8tdzMmn0Fru2mmTzB8+s+FsRG+w0JErZX2nBC1yofFPDvaZVI61zvYlKFO\n\toCJZoz6eGRi/5BgUsxI57TFvefBPrq3DscwRyE08=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 8 Nov 2021 14:13:30 +0100","Message-Id":"<20211108131350.130665-3-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 02/22] ipu3: ipa: Report effective sensor\n\tcontrols with statistics to IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Han-Lin Chen \n\nThe Intel close sourced IPA requires the effective controls applied to\nthe sensor when the statistics are generated. Report effective sensor controls\nwith the stastistics to IPA.\n\nSigned-off-by: Han-Lin Chen \n[Jean-Michel: Reword s/stastistics/statistics]\nSigned-off-by: Jean-Michel Hautbois \n---\n src/libcamera/pipeline/ipu3/frames.h | 3 +++\n src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++++\n 2 files changed, 8 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/frames.h b/src/libcamera/pipeline/ipu3/frames.h\nindex 3ef7e445..a897e307 100644\n--- a/src/libcamera/pipeline/ipu3/frames.h\n+++ b/src/libcamera/pipeline/ipu3/frames.h\n@@ -12,6 +12,7 @@\n #include \n #include \n \n+#include \n #include \n \n namespace libcamera {\n@@ -34,6 +35,8 @@ public:\n \t\tFrameBuffer *paramBuffer;\n \t\tFrameBuffer *statBuffer;\n \n+\t\tControlList effectiveSensorControls;\n+\n \t\tbool paramDequeued;\n \t\tbool metadataProcessed;\n \t};\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 8816efc5..6a7f5b9a 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -667,6 +667,8 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \t\treturn ret;\n \t}\n \n+\tdata->delayedCtrls_->reset();\n+\n \treturn updateControls(data);\n }\n \n@@ -1363,6 +1365,8 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer)\n \trequest->metadata().set(controls::SensorTimestamp,\n \t\t\t\tbuffer->metadata().timestamp);\n \n+\tinfo->effectiveSensorControls = delayedCtrls_->get(buffer->metadata().sequence);\n+\n \tif (request->findBuffer(&rawStream_))\n \t\tpipe()->completeBuffer(request, buffer);\n \n@@ -1419,6 +1423,7 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)\n \tev.frame = info->id;\n \tev.bufferId = info->statBuffer->cookie();\n \tev.frameTimestamp = request->metadata().get(controls::SensorTimestamp);\n+\tev.sensorControls = info->effectiveSensorControls;\n \tipa_->processEvent(ev);\n }\n \n","prefixes":["libcamera-devel","02/22"]}