[{"id":20787,"web_url":"https://patchwork.libcamera.org/comment/20787/","msgid":"<20211110100334.GC4088@pyrite.rasen.tech>","date":"2021-11-10T10:03:34","subject":"Re: [libcamera-devel] [PATCH 01/22] ipa: ipu3: Extend ipu3 ipa\n\tinterface for sensor controls","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nOn Mon, Nov 08, 2021 at 02:13:29PM +0100, Jean-Michel Hautbois wrote:\n> From: Han-Lin Chen \n> \n> IPU3Event and IPU3Action use single ControlList for both libcamera and\n> V4L2 controls, and it's content could be either one based on the\n> context. Extend IPU3Event and IPU3Action for sensor V4L2 controls, and\n> preserve the original one for only libcamera Controls to make the\n> content of an event more specific.\n> \n> Signed-off-by: Han-Lin Chen \n> [Jean-Michel: remove lensControls from the original patch]\n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/ipa/ipu3.mojom | 2 ++\n> src/ipa/ipu3/ipu3.cpp | 2 +-\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 3 files changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n> index 2f254ed4..16e3462e 100644\n> --- a/include/libcamera/ipa/ipu3.mojom\n> +++ b/include/libcamera/ipa/ipu3.mojom\n> @@ -23,11 +23,13 @@ struct IPU3Event {\n> \tint64 frameTimestamp;\n> \tuint32 bufferId;\n> \tlibcamera.ControlList controls;\n> +\tlibcamera.ControlList sensorControls;\n> };\n> \n> struct IPU3Action {\n> \tIPU3Operations op;\n> \tlibcamera.ControlList controls;\n> +\tlibcamera.ControlList sensorControls;\n> };\n> \n> struct IPAConfigInfo {\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 93b700bd..bcc3863b 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -653,7 +653,7 @@ void IPAIPU3::setControls(unsigned int frame)\n> \tControlList ctrls(ctrls_);\n> \tctrls.set(V4L2_CID_EXPOSURE, static_cast(exposure_));\n> \tctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast(gain_));\n> -\top.controls = ctrls;\n> +\top.sensorControls = ctrls;\n> \n> \tqueueFrameAction.emit(frame, op);\n> }\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index eb714aa6..8816efc5 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1248,7 +1248,7 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n> {\n> \tswitch (action.op) {\n> \tcase ipa::ipu3::ActionSetSensorControls: {\n> -\t\tconst ControlList &controls = action.controls;\n> +\t\tconst ControlList &controls = action.sensorControls;\n> \t\tdelayedCtrls_->push(controls);\n> \t\tbreak;\n> \t}\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19ECDBF415\n\tfor ;\n\tWed, 10 Nov 2021 10:03:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C8EB860128;\n\tWed, 10 Nov 2021 11:03:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D339260128\n\tfor ;\n\tWed, 10 Nov 2021 11:03:42 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F6E6D8B;\n\tWed, 10 Nov 2021 11:03:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YrgPMdsI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636538622;\n\tbh=wNs1td1TFNtEz3UKDsRg/jdVzjw+hxbV6UMdw81uoBU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YrgPMdsIxuSzHI34UQPoARlmpuS1XJVjB1sTrk9nIAkFkTqD5XZTX4Y3l+6XtapPO\n\tCqeMn1mO6GfyjQuEhPwHfPhSzRr4nXpaD76plNrWlbOK9sC74sfttjeQZ7UyM9fe1O\n\tvsjMibamu1tCZTZ3Ew2u8zdDtzF9GLoluudahYJg=","Date":"Wed, 10 Nov 2021 19:03:34 +0900","From":"paul.elder@ideasonboard.com","To":"Jean-Michel Hautbois ","Message-ID":"<20211110100334.GC4088@pyrite.rasen.tech>","References":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211108131350.130665-2-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20211108131350.130665-2-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 01/22] ipa: ipu3: Extend ipu3 ipa\n\tinterface for sensor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]