{"id":14467,"url":"https://patchwork.libcamera.org/api/patches/14467/?format=json","web_url":"https://patchwork.libcamera.org/patch/14467/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211105163625.545541-1-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-05T16:36:25","name":"[libcamera-devel,v2] ipa: ipu3: List the events in their order of calling","commit_ref":"a5b323e05dae6d9579b230514485cb04c6a764da","pull_url":null,"state":"accepted","archived":false,"hash":"569363229b56a763740b34eb3eabb14a6c568422","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14467/mbox/","series":[{"id":2694,"url":"https://patchwork.libcamera.org/api/series/2694/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2694","date":"2021-11-05T16:36:25","name":"[libcamera-devel,v2] ipa: ipu3: List the events in their order of calling","version":2,"mbox":"https://patchwork.libcamera.org/series/2694/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14467/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14467/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1AE4BBF415\n\tfor ;\n\tFri, 5 Nov 2021 16:36:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 76C3A6032C;\n\tFri, 5 Nov 2021 17:36:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 78465600B8\n\tfor ;\n\tFri, 5 Nov 2021 17:36:29 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:bd59:f4c6:2152:cf32])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2086D110E;\n\tFri, 5 Nov 2021 17:36:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Cgg5D75Q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636130189;\n\tbh=pljLW2ueKj8mk+M+Bp0OAbiSV6cyw8oYl2peO+rvT/g=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Cgg5D75QBnSbRCNS5C9LR+AUSHOjcDjKrNmiYK1lZA/649SHo9PYzzhj1BhRcRHOa\n\tyyC/OHNk8KxL+DdxldHFlWmo1pxDgyUjI7DcjWqN3IZcB6PxV/lVCmYTsKrdX+yCy6\n\tv5fOZGdYj9NJ5VWrTIND9RwG7jMkVlR/UhZrZRPY=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 5 Nov 2021 17:36:25 +0100","Message-Id":"<20211105163625.545541-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2] ipa: ipu3: List the events in their\n\torder of calling","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The IPU3 IPA has three events which are handled from the pipeline\nhandler.\n\nThe events are received in the sequence, EventProcessControls,\nEventFillParams, and finally EventStatReady, while the code lists these\nin a different order.\n\nUpdate the flow of IPAIPU3::processEvent() to match the expected\nsequence of events, to help support the reader in interpreting the flow\nof events through the IPA.\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Kieran Bingham \n---\n src/ipa/ipu3/ipu3.cpp | 27 +++++++++++++++++----------\n 1 file changed, 17 insertions(+), 10 deletions(-)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 5c51607d..93b700bd 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -509,6 +509,13 @@ void IPAIPU3::unmapBuffers(const std::vector &ids)\n /**\n * \\brief Process an event generated by the pipeline handler\n * \\param[in] event The event sent from pipeline handler\n+ *\n+ * The expected event handling over the lifetime of a Request has\n+ * the following sequence:\n+ *\n+ * - EventProcessControls : Handle controls from a new Request\n+ * - EventFillParams : Prepare the ISP to process the Request\n+ * - EventStatReady : Process statistics after ISP completion\n */\n void IPAIPU3::processEvent(const IPU3Event &event)\n {\n@@ -517,32 +524,32 @@ void IPAIPU3::processEvent(const IPU3Event &event)\n \t\tprocessControls(event.frame, event.controls);\n \t\tbreak;\n \t}\n-\tcase EventStatReady: {\n+\tcase EventFillParams: {\n \t\tauto it = buffers_.find(event.bufferId);\n \t\tif (it == buffers_.end()) {\n-\t\t\tLOG(IPAIPU3, Error) << \"Could not find stats buffer!\";\n+\t\t\tLOG(IPAIPU3, Error) << \"Could not find param buffer!\";\n \t\t\treturn;\n \t\t}\n \n \t\tSpan mem = it->second.planes()[0];\n-\t\tconst ipu3_uapi_stats_3a *stats =\n-\t\t\treinterpret_cast(mem.data());\n+\t\tipu3_uapi_params *params =\n+\t\t\treinterpret_cast(mem.data());\n \n-\t\tparseStatistics(event.frame, event.frameTimestamp, stats);\n+\t\tfillParams(event.frame, params);\n \t\tbreak;\n \t}\n-\tcase EventFillParams: {\n+\tcase EventStatReady: {\n \t\tauto it = buffers_.find(event.bufferId);\n \t\tif (it == buffers_.end()) {\n-\t\t\tLOG(IPAIPU3, Error) << \"Could not find param buffer!\";\n+\t\t\tLOG(IPAIPU3, Error) << \"Could not find stats buffer!\";\n \t\t\treturn;\n \t\t}\n \n \t\tSpan mem = it->second.planes()[0];\n-\t\tipu3_uapi_params *params =\n-\t\t\treinterpret_cast(mem.data());\n+\t\tconst ipu3_uapi_stats_3a *stats =\n+\t\t\treinterpret_cast(mem.data());\n \n-\t\tfillParams(event.frame, params);\n+\t\tparseStatistics(event.frame, event.frameTimestamp, stats);\n \t\tbreak;\n \t}\n \tdefault:\n","prefixes":["libcamera-devel","v2"]}