[{"id":20684,"web_url":"https://patchwork.libcamera.org/comment/20684/","msgid":"","date":"2021-11-05T08:43:21","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: ipu3: Extend ipu3 ipa\n\tinterface for sensor controls","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Han-Lin,\n\nAs you can see, I missed an introduction in the mail with the patch I \nsent :-/.\n\nI would like the sensor controls part to be integrated very soon, so I \nhave amended your commit, to remove the lens specific part, and a bit of \nthe commit message too...\n\nOn 05/11/2021 09:39, Jean-Michel Hautbois wrote:\n> From: Han-Lin Chen \n> \n> IPU3Event and IPU3Action use single ControlList for both libcamera and\n> V4L2 controls, and it's content could be either one based on the\n> context. Extend IPU3Event and IPU3Action for sensor V4L2 controls, and\n> preserve the original one for only libcamera Controls to make the\n> content of an event more specific.\n> \n> Signed-off-by: Han-Lin Chen \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> include/libcamera/ipa/ipu3.mojom | 2 ++\n> src/ipa/ipu3/ipu3.cpp | 2 +-\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 3 files changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n> index 2f254ed4..16e3462e 100644\n> --- a/include/libcamera/ipa/ipu3.mojom\n> +++ b/include/libcamera/ipa/ipu3.mojom\n> @@ -23,11 +23,13 @@ struct IPU3Event {\n> \tint64 frameTimestamp;\n> \tuint32 bufferId;\n> \tlibcamera.ControlList controls;\n> +\tlibcamera.ControlList sensorControls;\n> };\n> \n> struct IPU3Action {\n> \tIPU3Operations op;\n> \tlibcamera.ControlList controls;\n> +\tlibcamera.ControlList sensorControls;\n> };\n> \n> struct IPAConfigInfo {\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 5c51607d..6775570e 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -646,7 +646,7 @@ void IPAIPU3::setControls(unsigned int frame)\n> \tControlList ctrls(ctrls_);\n> \tctrls.set(V4L2_CID_EXPOSURE, static_cast(exposure_));\n> \tctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast(gain_));\n> -\top.controls = ctrls;\n> +\top.sensorControls = ctrls;\n> \n> \tqueueFrameAction.emit(frame, op);\n> }\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index eb714aa6..8816efc5 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1248,7 +1248,7 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n> {\n> \tswitch (action.op) {\n> \tcase ipa::ipu3::ActionSetSensorControls: {\n> -\t\tconst ControlList &controls = action.controls;\n> +\t\tconst ControlList &controls = action.sensorControls;\n> \t\tdelayedCtrls_->push(controls);\n> \t\tbreak;\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90582BDB1C\n\tfor ;\n\tFri, 5 Nov 2021 08:43:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E26E16034D;\n\tFri, 5 Nov 2021 09:43:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C21260121\n\tfor ;\n\tFri, 5 Nov 2021 09:43:24 +0100 (CET)","from [IPV6:2a01:e0a:169:7140:bd59:f4c6:2152:cf32] (unknown\n\t[IPv6:2a01:e0a:169:7140:bd59:f4c6:2152:cf32])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2DFA73E7;\n\tFri, 5 Nov 2021 09:43:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AXTC6Z30\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636101804;\n\tbh=h0NkwOvwJ6avJo/qsjRQ6Ijdu85ZUQNBvb+hlroYn9I=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=AXTC6Z30MfYfWfMytstjUyPPsyYt2i5PHaqX5WBfL80fjpDuv4WIbHlxdQhiqFmoZ\n\ty2KRkneLZhGTDW4+LryUVrgfo4Aqs0GiGmOeUDNsJMn0aGH2CUmbCz4A3+7xNL5sec\n\tH20We+cgg1/Cwg4foZ2Bowva0VZgzs/NVq0IGkDI=","Message-ID":"","Date":"Fri, 5 Nov 2021 09:43:21 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.2.1","Content-Language":"en-US","To":"Han-Lin Chen ","References":"<3590607b-58fe-72a1-e497-c2548fa0d139@ideasonboard.com>\n\t<20211105083954.26216-1-jeanmichel.hautbois@ideasonboard.com>","From":"Jean-Michel Hautbois ","In-Reply-To":"<20211105083954.26216-1-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: ipu3: Extend ipu3 ipa\n\tinterface for sensor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20692,"web_url":"https://patchwork.libcamera.org/comment/20692/","msgid":"<163611846517.275423.5977555257302665874@Monstersaurus>","date":"2021-11-05T13:21:05","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: ipu3: Extend ipu3 ipa\n\tinterface for sensor controls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-05 08:39:54)\n> From: Han-Lin Chen \n> \n> IPU3Event and IPU3Action use single ControlList for both libcamera and\n> V4L2 controls, and it's content could be either one based on the\n> context. Extend IPU3Event and IPU3Action for sensor V4L2 controls, and\n> preserve the original one for only libcamera Controls to make the\n> content of an event more specific.\n> \n> Signed-off-by: Han-Lin Chen \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> include/libcamera/ipa/ipu3.mojom | 2 ++\n> src/ipa/ipu3/ipu3.cpp | 2 +-\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 3 files changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n> index 2f254ed4..16e3462e 100644\n> --- a/include/libcamera/ipa/ipu3.mojom\n> +++ b/include/libcamera/ipa/ipu3.mojom\n> @@ -23,11 +23,13 @@ struct IPU3Event {\n> int64 frameTimestamp;\n> uint32 bufferId;\n> libcamera.ControlList controls;\n> + libcamera.ControlList sensorControls;\n\nIt makes me wonder if we shouldn't be more explicit over the type of\ncontrols stored in a ControlList.\n\ncontrols are libcamera controls, while sensorControls are (I think) V4L2\ncontrols..\n\nBut that's not a blocker for this patch. That's a larger change to the\ncontrol frameworks...\n\nReviewed-by: Kieran Bingham \n\n\n> };\n> \n> struct IPU3Action {\n> IPU3Operations op;\n> libcamera.ControlList controls;\n> + libcamera.ControlList sensorControls;\n> };\n> \n> struct IPAConfigInfo {\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 5c51607d..6775570e 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -646,7 +646,7 @@ void IPAIPU3::setControls(unsigned int frame)\n> ControlList ctrls(ctrls_);\n> ctrls.set(V4L2_CID_EXPOSURE, static_cast(exposure_));\n> ctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast(gain_));\n> - op.controls = ctrls;\n> + op.sensorControls = ctrls;\n> \n> queueFrameAction.emit(frame, op);\n> }\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index eb714aa6..8816efc5 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1248,7 +1248,7 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n> {\n> switch (action.op) {\n> case ipa::ipu3::ActionSetSensorControls: {\n> - const ControlList &controls = action.controls;\n> + const ControlList &controls = action.sensorControls;\n> delayedCtrls_->push(controls);\n> break;\n> }\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E010BF415\n\tfor ;\n\tFri, 5 Nov 2021 13:21:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3C2716032C;\n\tFri, 5 Nov 2021 14:21:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91B36600B8\n\tfor ;\n\tFri, 5 Nov 2021 14:21:08 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1C97FE7;\n\tFri, 5 Nov 2021 14:21:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VFG2ef3o\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636118468;\n\tbh=2w6c+9EcrlY1Y7B5+nE75SWlFmKXsgG8wKTk/gCKFGw=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=VFG2ef3odTpEVTXkuZeyklp/izKoEmE6MQHplI7rV3ohid3fo/yf3UJMcKSDMislW\n\tOg5KsZK3E69jJEbhF4i57+3yIxz7+NJTRZ+Q/ynWkS3MaNgVZMSQx1BZUTyek0JFj+\n\thebFvkgPaGEq65tEcXre+qKSsKPJDuR5GyRh66YQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211105083954.26216-1-jeanmichel.hautbois@ideasonboard.com>","References":"<3590607b-58fe-72a1-e497-c2548fa0d139@ideasonboard.com>\n\t<20211105083954.26216-1-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 05 Nov 2021 13:21:05 +0000","Message-ID":"<163611846517.275423.5977555257302665874@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: ipu3: Extend ipu3 ipa\n\tinterface for sensor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20693,"web_url":"https://patchwork.libcamera.org/comment/20693/","msgid":"<163611850527.275423.6090906413651533273@Monstersaurus>","date":"2021-11-05T13:21:45","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: ipu3: Extend ipu3 ipa\n\tinterface for sensor controls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-05 08:43:21)\n> Hi Han-Lin,\n> \n> As you can see, I missed an introduction in the mail with the patch I \n> sent :-/.\n> \n\n\nIt's marked 1/2, was there a second patch as well?\n--\nKieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 110A5BF415\n\tfor ;\n\tFri, 5 Nov 2021 13:21:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE51D6034A;\n\tFri, 5 Nov 2021 14:21:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE701600B8\n\tfor ;\n\tFri, 5 Nov 2021 14:21:47 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A451AE7;\n\tFri, 5 Nov 2021 14:21:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qYq1a6zv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636118507;\n\tbh=uST0/42W36N7tp+BAhxEdlXqG0f7SyuF2cW+4pT1e4g=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=qYq1a6zveUHpMOXIQBmjv9S17BH1qwYnBcr5UnQjZvFrEoY3DmpflslEO9/fcne3h\n\tvh+zDyeOu+D7i8R1sJucW5gpdz4CwRcj7eI2ErTxwdq3gURvzpD55FvlqXDgINU9wv\n\tKYYKkkkUS5XbCNel1ysVTfwz/7j25nyRuKHii5RU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<3590607b-58fe-72a1-e497-c2548fa0d139@ideasonboard.com>\n\t<20211105083954.26216-1-jeanmichel.hautbois@ideasonboard.com>\n\t","From":"Kieran Bingham ","To":"Han-Lin Chen ,\n\tJean-Michel Hautbois ","Date":"Fri, 05 Nov 2021 13:21:45 +0000","Message-ID":"<163611850527.275423.6090906413651533273@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: ipu3: Extend ipu3 ipa\n\tinterface for sensor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20696,"web_url":"https://patchwork.libcamera.org/comment/20696/","msgid":"<2512e18b-be7d-8889-90d8-59425f8fac44@ideasonboard.com>","date":"2021-11-05T20:37:50","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: ipu3: Extend ipu3 ipa\n\tinterface for sensor controls","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi,\n\nOn 05/11/2021 14:21, Kieran Bingham wrote:\n> Quoting Jean-Michel Hautbois (2021-11-05 08:43:21)\n>> Hi Han-Lin,\n>>\n>> As you can see, I missed an introduction in the mail with the patch I\n>> sent :-/.\n>>\n> \n> \n> It's marked 1/2, was there a second patch as well?\n\nThe second one is the same as the original \"[PATCH v2 2/4] ipu3: ipa: \nReport effective sensor\" \n(<20211029115917.2467936-2-hanlinchen@chromium.org>)\n\nSorry for that...\n\nJM","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 131D3BDB1C\n\tfor ;\n\tFri, 5 Nov 2021 20:37:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4857D6032C;\n\tFri, 5 Nov 2021 21:37:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A306E600B8\n\tfor ;\n\tFri, 5 Nov 2021 21:37:53 +0100 (CET)","from [IPV6:2a01:e0a:169:7140:bd59:f4c6:2152:cf32] (unknown\n\t[IPv6:2a01:e0a:169:7140:bd59:f4c6:2152:cf32])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4D770192B;\n\tFri, 5 Nov 2021 21:37:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mBlZ/tqT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636144673;\n\tbh=mOueT6XXcMczbOkl2n1/++MkkYsFjl1FuC0rRxa2c1s=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=mBlZ/tqTr4nRqtLuoP84f5ElHpOObjLxlQ8PdXPtLvUTD5ci7SuRHP4Vg73ocNAI/\n\tkACLnJUs5S6moinb0brBIz2jWD5YyMLVO/Zc4p2GXqXLEbqlTqMs3NSyo4TXqfSGfu\n\tx1+B94arajcY93ekhzXda7Csg2o5ONt1qPXMnIwk=","Message-ID":"<2512e18b-be7d-8889-90d8-59425f8fac44@ideasonboard.com>","Date":"Fri, 5 Nov 2021 21:37:50 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.2.1","Content-Language":"en-US","To":"Kieran Bingham ,\n\tHan-Lin Chen ","References":"<3590607b-58fe-72a1-e497-c2548fa0d139@ideasonboard.com>\n\t<20211105083954.26216-1-jeanmichel.hautbois@ideasonboard.com>\n\t\n\t<163611850527.275423.6090906413651533273@Monstersaurus>","From":"Jean-Michel Hautbois ","In-Reply-To":"<163611850527.275423.6090906413651533273@Monstersaurus>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: ipu3: Extend ipu3 ipa\n\tinterface for sensor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]