[{"id":20737,"web_url":"https://patchwork.libcamera.org/comment/20737/","msgid":"<163641412290.948064.4152474882069594422@Monstersaurus>","date":"2021-11-08T23:28:42","subject":"Re: [libcamera-devel] [PATCH v2] ipa: ipu3: agc: Limit the number\n\tof saturated cells","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-04 11:36:21)\n> When the histogram is calculated, we check if a cell is saturated or not\n> before cumulating its green value. This is wrong, and it can lead to an\n> empty histogram in case of a fully saturated frame.\n> \n> Use a constant to limit the amount of pixels within a cell before\n> considering it saturated. If at the end of the loop we still have an\n> empty histogram, then make it a fully saturated one.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=84\n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/algorithms/agc.cpp | 16 ++++++++++++++--\n> 1 file changed, 14 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\n> index b5d736c1..dcdfb95c 100644\n> --- a/src/ipa/ipu3/algorithms/agc.cpp\n> +++ b/src/ipa/ipu3/algorithms/agc.cpp\n> @@ -63,6 +63,12 @@ static constexpr uint32_t knumHistogramBins = 256;\n> /* Target value to reach for the top 2% of the histogram */\n> static constexpr double kEvGainTarget = 0.5;\n> \n> +/*\n> + * Maximum ratio of saturated pixels in a cell for the cell to be considered\n> + * non-saturated and counted by the AGC algorithm.\n> + */\n> +static constexpr uint32_t kMinCellsPerZoneRatio = 255 * 50 / 100;\n\nI think I see in your latest series that this is now set to 20%, Can i\nassume this version of the patch is superseeded?\n\nShould this 'fix' be integrated separately from the large control series\nas it fixes a known bug?\n\n--\nKieran\n\n> +\n> Agc::Agc()\n> : frameCount_(0), lastFrame_(0), iqMean_(0.0), lineDuration_(0s),\n> minExposureLines_(0), maxExposureLines_(0), filteredExposure_(0s),\n> @@ -124,7 +130,7 @@ void Agc::measureBrightness(const ipu3_uapi_stats_3a *stats,\n> &stats->awb_raw_buffer.meta_data[cellPosition]\n> );\n> \n> - if (cell->sat_ratio == 0) {\n> + if (cell->sat_ratio <= kMinCellsPerZoneRatio) {\n> uint8_t gr = cell->Gr_avg;\n> uint8_t gb = cell->Gb_avg;\n> /*\n> @@ -137,8 +143,14 @@ void Agc::measureBrightness(const ipu3_uapi_stats_3a *stats,\n> }\n> }\n> \n> + Histogram cumulativeHist = Histogram(Span(hist));\n> /* Estimate the quantile mean of the top 2% of the histogram */\n> - iqMean_ = Histogram(Span(hist)).interQuantileMean(0.98, 1.0);\n> + if (cumulativeHist.total() == 0) {\n> + /* Force the value as histogram is empty */\n> + iqMean_ = knumHistogramBins - 0.5;\n> + } else {\n> + iqMean_ = cumulativeHist.interQuantileMean(0.98, 1.0);\n> + }\n> }\n> \n> /**\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E44FBBF415\n\tfor ;\n\tMon, 8 Nov 2021 23:28:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53DA76034A;\n\tTue, 9 Nov 2021 00:28:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 324E760121\n\tfor ;\n\tTue, 9 Nov 2021 00:28:45 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CE38C8D4;\n\tTue, 9 Nov 2021 00:28:44 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"P2kLPpAo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636414124;\n\tbh=NcZlbDbxHbQ5bOz0AodHbQ0fieuLa/yUtrAa+/iU3xo=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=P2kLPpAo89ru3X84NGJoCNljwRMXhZbSvmyd666SAYzvuHFiQFehU7x1LI75giBti\n\tClrcyRPe/nS9fN9RWL8wLlYqJMuMTjVGm7NXVZqV0nbIjPMvujuR9eLtvQ/K566fFG\n\t6NlLiq4oaDsMWZxMmE9DkBsSWzXh1a4vVJjlNVkA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211104113621.60730-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211104113621.60730-1-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 08 Nov 2021 23:28:42 +0000","Message-ID":"<163641412290.948064.4152474882069594422@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v2] ipa: ipu3: agc: Limit the number\n\tof saturated cells","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]