[{"id":20679,"web_url":"https://patchwork.libcamera.org/comment/20679/","msgid":"<20211104160922.wecdmhxsyzvuhi4p@uno.localdomain>","date":"2021-11-04T16:09:22","subject":"Re: [libcamera-devel] [PATCH] libcamera: framebuffer: Fix\n\tiscontiguous log message","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi\n\nOn Thu, Nov 04, 2021 at 11:13:47AM +0000, Kieran Bingham wrote:\n> The isContiguous debug message is inverted.\n> Correct the logic.\n>\n> Reported-by: Roman Stratiienko \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/framebuffer.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp\n> index d44a98babd05..337ea1155a38 100644\n> --- a/src/libcamera/framebuffer.cpp\n> +++ b/src/libcamera/framebuffer.cpp\n> @@ -247,7 +247,7 @@ FrameBuffer::FrameBuffer(const std::vector &planes, unsigned int cookie)\n> \t}\n>\n> \tLOG(Buffer, Debug)\n> -\t\t<< \"Buffer is \" << (isContiguous ? \"not \" : \"\") << \"contiguous\";\n> +\t\t<< \"Buffer is \" << (isContiguous ? \"\" : \"not \") << \"contiguous\";\n>\n> \t_d()->isContiguous_ = isContiguous;\n> }\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47A1ABDB1C\n\tfor ;\n\tThu, 4 Nov 2021 16:08:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42AAC60347;\n\tThu, 4 Nov 2021 17:08:33 +0100 (CET)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6AA260128\n\tfor ;\n\tThu, 4 Nov 2021 17:08:31 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 854771C0008;\n\tThu, 4 Nov 2021 16:08:30 +0000 (UTC)"],"Date":"Thu, 4 Nov 2021 17:09:22 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20211104160922.wecdmhxsyzvuhi4p@uno.localdomain>","References":"<20211104111347.3781990-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211104111347.3781990-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: framebuffer: Fix\n\tiscontiguous log message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ,\n\tRoman Stratiienko ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20680,"web_url":"https://patchwork.libcamera.org/comment/20680/","msgid":"","date":"2021-11-04T16:14:26","subject":"Re: [libcamera-devel] [PATCH] libcamera: framebuffer: Fix\n\tiscontiguous log message","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Kieran and Roman !\n\nOn 04/11/2021 12:13, Kieran Bingham wrote:\n> The isContiguous debug message is inverted.\n> Correct the logic.\n> \n> Reported-by: Roman Stratiienko \n> Signed-off-by: Kieran Bingham \n\nThanks a lot !\nReviewed-by: Jean-Michel Hautbois \n\n> ---\n> src/libcamera/framebuffer.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp\n> index d44a98babd05..337ea1155a38 100644\n> --- a/src/libcamera/framebuffer.cpp\n> +++ b/src/libcamera/framebuffer.cpp\n> @@ -247,7 +247,7 @@ FrameBuffer::FrameBuffer(const std::vector &planes, unsigned int cookie)\n> \t}\n> \n> \tLOG(Buffer, Debug)\n> -\t\t<< \"Buffer is \" << (isContiguous ? \"not \" : \"\") << \"contiguous\";\n> +\t\t<< \"Buffer is \" << (isContiguous ? \"\" : \"not \") << \"contiguous\";\n> \n> \t_d()->isContiguous_ = isContiguous;\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2238FBF415\n\tfor ;\n\tThu, 4 Nov 2021 16:14:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6018660347;\n\tThu, 4 Nov 2021 17:14:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71B5B60128\n\tfor ;\n\tThu, 4 Nov 2021 17:14:29 +0100 (CET)","from [IPV6:2a01:e0a:169:7140:3875:cc64:ce12:aabc] (unknown\n\t[IPv6:2a01:e0a:169:7140:3875:cc64:ce12:aabc])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E43741A38;\n\tThu, 4 Nov 2021 17:14:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Mhh91TTE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636042469;\n\tbh=XjvanUrNDv2cmLQUhtbziP/szuKIYsdREvqwkdEZxDk=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=Mhh91TTE1xecd7xCRgdKfYKBnFiM38710U9xuDNdAI86BV3IoTvKCF5pRat8ZHlrG\n\t46/yO+t8PObZy25qi4bC8PkdoKLwt5+Q+ll3EAKkslqV6eUMDNC1EJCQt2NQrmxWZ7\n\tQg6OEpd2OLGo94emisIzxJ32x/ohgM8OnwsOY4xA=","Message-ID":"","Date":"Thu, 4 Nov 2021 17:14:26 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.1.2","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20211104111347.3781990-1-kieran.bingham@ideasonboard.com>","From":"Jean-Michel Hautbois ","In-Reply-To":"<20211104111347.3781990-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: framebuffer: Fix\n\tiscontiguous log message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Roman Stratiienko ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20681,"web_url":"https://patchwork.libcamera.org/comment/20681/","msgid":"<163604261165.275423.2309249838490300525@Monstersaurus>","date":"2021-11-04T16:16:51","subject":"Re: [libcamera-devel] [PATCH] libcamera: framebuffer: Fix\n\tiscontiguous log message","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"When applying I'll modify s/iscontiguous/isContiguous/ in the $SUBJECT\nline.\n\n--\nKB\n\nQuoting Kieran Bingham (2021-11-04 11:13:47)\n> The isContiguous debug message is inverted.\n> Correct the logic.\n> \n> Reported-by: Roman Stratiienko \n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/framebuffer.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp\n> index d44a98babd05..337ea1155a38 100644\n> --- a/src/libcamera/framebuffer.cpp\n> +++ b/src/libcamera/framebuffer.cpp\n> @@ -247,7 +247,7 @@ FrameBuffer::FrameBuffer(const std::vector &planes, unsigned int cookie)\n> }\n> \n> LOG(Buffer, Debug)\n> - << \"Buffer is \" << (isContiguous ? \"not \" : \"\") << \"contiguous\";\n> + << \"Buffer is \" << (isContiguous ? \"\" : \"not \") << \"contiguous\";\n> \n> _d()->isContiguous_ = isContiguous;\n> }\n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB508BF415\n\tfor ;\n\tThu, 4 Nov 2021 16:16:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32EA360347;\n\tThu, 4 Nov 2021 17:16:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C80560128\n\tfor ;\n\tThu, 4 Nov 2021 17:16:54 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 233F61A38;\n\tThu, 4 Nov 2021 17:16:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qVF0YCpg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636042614;\n\tbh=x4sMPaTsaGUAxYIDindIrXEiOJNA0yfmqu6bs9VVCEI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=qVF0YCpgIfaw6q0KiCHscY9a7V0OaBzlhEZmdM92rSQU/TVHzXDygXx5sIqP8auj2\n\tvMSPVp+qr/SZbgIvHg5hrJ5FLFLA1Ufv17yvrKrWfXVRQArx5r+KEeKG6jYgLy5lTT\n\tA1tXA+GYAl8lPs3XULJPcteHMQhBvzuH/QJ4/Pt4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211104111347.3781990-1-kieran.bingham@ideasonboard.com>","References":"<20211104111347.3781990-1-kieran.bingham@ideasonboard.com>","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Thu, 04 Nov 2021 16:16:51 +0000","Message-ID":"<163604261165.275423.2309249838490300525@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH] libcamera: framebuffer: Fix\n\tiscontiguous log message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Roman Stratiienko ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]