[{"id":20646,"web_url":"https://patchwork.libcamera.org/comment/20646/","msgid":"<163576602241.228827.1896632024554495152@Monstersaurus>","date":"2021-11-01T11:27:02","subject":"Re: [libcamera-devel] [PATCH v5 03/11] libcamera: formats: Add\n\tR10_CSI2P format","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nQuoting Naushir Patuck (2021-11-01 09:15:02)\n> This new formats corresponds to the V4L2 V4L2_PIX_FMT_Y10P format, and is a\n> CSI2-packed version of the DRM_FORMAT_R10 format.\n\nThanks for the update. Indeed this matches what I had expected.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/formats.cpp | 13 +++++++++++++\n> src/libcamera/formats.yaml | 4 ++++\n> 2 files changed, 17 insertions(+)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index d4781dfb3874..afcaabc519f7 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -510,6 +510,19 @@ const std::map pixelFormatInfo{\n> .pixelsPerGroup = 1,\n> .planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n> } },\n> + { formats::R10_CSI2P, {\n> + .name = \"R10_CSI2P\",\n> + .format = formats::R10,\n> + .v4l2Formats = {\n> + .single = V4L2PixelFormat(V4L2_PIX_FMT_Y10P),\n> + .multi = V4L2PixelFormat(),\n> + },\n> + .bitsPerPixel = 10,\n> + .colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> + .packed = true,\n> + .pixelsPerGroup = 4,\n> + .planes = {{ { 5, 1 }, { 0, 0 }, { 0, 0 } }},\n> + } },\n> \n> /* Bayer formats. */\n> { formats::SBGGR8, {\n> diff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\n> index 22a8e473a183..1f3f043302c3 100644\n> --- a/src/libcamera/formats.yaml\n> +++ b/src/libcamera/formats.yaml\n> @@ -109,6 +109,10 @@ formats:\n> - SBGGR16:\n> fourcc: DRM_FORMAT_SBGGR16\n> \n> + - R10_CSI2P:\n> + fourcc: DRM_FORMAT_R10\n> + mod: MIPI_FORMAT_MOD_CSI2_PACKED\n> +\n> - SRGGB10_CSI2P:\n> fourcc: DRM_FORMAT_SRGGB10\n> mod: MIPI_FORMAT_MOD_CSI2_PACKED\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE970BDB1C\n\tfor ;\n\tMon, 1 Nov 2021 11:27:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F3B2600C3;\n\tMon, 1 Nov 2021 12:27:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1BF2600B3\n\tfor ;\n\tMon, 1 Nov 2021 12:27:05 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5BC14DFF;\n\tMon, 1 Nov 2021 12:27:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AfAF1NhK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635766025;\n\tbh=LRAV1TIxBGkreV03jcpKWHRBR1lVgQKh1fREAmwS4Eg=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=AfAF1NhK6RVA/drVvJDrMLjSVkw90/c8tqAEPbfMSgXPWki6ClQSEtSyFKRvzcrNN\n\tDe7IVzCgzU7SlZdCDy7yVre8qNu+YQlPFM+eBnz/HdEjouL0LfKjOsVJSP+1u1b5cM\n\t9Du1Co9pO/BtgraYuRavq8tTcnJvwSURsYSYAkVw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211101091510.23204-4-naush@raspberrypi.com>","References":"<20211101091510.23204-1-naush@raspberrypi.com>\n\t<20211101091510.23204-4-naush@raspberrypi.com>","From":"Kieran Bingham ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 01 Nov 2021 11:27:02 +0000","Message-ID":"<163576602241.228827.1896632024554495152@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v5 03/11] libcamera: formats: Add\n\tR10_CSI2P format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]