[{"id":20669,"web_url":"https://patchwork.libcamera.org/comment/20669/","msgid":"<163597852383.1378115.4854881441147091304@Monstersaurus>","date":"2021-11-03T22:28:43","subject":"Re: [libcamera-devel] [PATCH v2 6/6] ipu3: Use gbce and tone\n\tmapping from the tuning files","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Han-Lin Chen (2021-10-29 13:00:01)\n> Change the flags to gbce algorithm to use the global brightness and tone\n> mapping from the tunint files.\n\ns/tunint/tuning/\n\n> Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org>\n> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n>  aiq/aiq_input_parameters.cpp | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/aiq/aiq_input_parameters.cpp b/aiq/aiq_input_parameters.cpp\n> index 5dd2f6c..7a6a1fa 100644\n> --- a/aiq/aiq_input_parameters.cpp\n> +++ b/aiq/aiq_input_parameters.cpp\n> @@ -170,8 +170,8 @@ void AiqInputParameters::setAeAwbAfDefaults()\n>         };\n>  \n>         /* GBCE Params */\n> -       gbceParams.gbce_level = ia_aiq_gbce_level_bypass;\n> -       gbceParams.tone_map_level = ia_aiq_tone_map_level_default;\n> +       gbceParams.gbce_level = ia_aiq_gbce_level_use_tuning;\n> +       gbceParams.tone_map_level = ia_aiq_tone_map_level_use_tuning;\n>         gbceParams.frame_use = ia_aiq_frame_use_preview;\n>         gbceParams.ev_shift = 0;\n>  \n> -- \n> 2.33.1.1089.g2158813163f-goog\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87F98BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  3 Nov 2021 22:28:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3DCDE600BF;\n\tWed,  3 Nov 2021 23:28:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CEE2B600B5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  3 Nov 2021 23:28:46 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8DE63501;\n\tWed,  3 Nov 2021 23:28:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"L0K9H8ue\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635978526;\n\tbh=7dVLlvsvxjEmt0tiES69q8Df3IJr02wNVyY6unSQgzY=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=L0K9H8ue4CmN+POUcM78hVmendSh2x/uhjnmBvqSMBXaEkpFVG5vGWNJFuUUGP3pI\n\tbyjSwa7iIUoUy5vyF7yYD9om8DWb8uZfNo0rV5mhHvcpqIeh8/rOYu52fTKYNOah6E\n\tRGxpGTdLZ2UL7Pqvl1bFNKgTr9GyaK52X/cvnWAA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211029120001.2469018-6-hanlinchen@chromium.org>","References":"<20211029120001.2469018-1-hanlinchen@chromium.org>\n\t<20211029120001.2469018-6-hanlinchen@chromium.org>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"Han-Lin Chen <hanlinchen@chromium.org>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 03 Nov 2021 22:28:43 +0000","Message-ID":"<163597852383.1378115.4854881441147091304@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v2 6/6] ipu3: Use gbce and tone\n\tmapping from the tuning files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]