[{"id":20663,"web_url":"https://patchwork.libcamera.org/comment/20663/","msgid":"<163585983392.275423.11844224116887008509@Monstersaurus>","date":"2021-11-02T13:30:33","subject":"Re: [libcamera-devel] [PATCH v2 1/6] ipu3: Use\n\tia_aiq_frame_use_preview as default mode for AIQ","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Han-Lin,\n\nQuoting Han-Lin Chen (2021-10-29 12:59:56)\n> The frame use mode is set according to Android Capture Intent in Intel\n> HAL's implememtation. The current default mode ia_aiq_frame_use_still is\n> only used with the single capture request. For preview use case, it has\n\n'has a hard time' (missing 'a').\n\n> hard time converging AE and AF smoothly. Change the default mode to\n> ia_aiq_frame_use_preview for better user experience.\n\nI see that on the first version, Umang offered his RB tag:\n\nReviewed-by: Umang Jain \n\nWhen you post a new version of a series, could you aim to collect tags\nthat have been provided, and add them to your commit message please?\n\nOtherwise, (unless otherwise spotted) they will get lost.\n\n\nCould you also try to add a cover letter to any multipatch series\nplease? It really helps group the series together, and provides a space\nto write any commentary or notes about the series.\n\nFinally, for IPU3-IPA patches, could you add a prefix to the patches to\nclearly mark them when sending? They are distinct from the main\nlibcamera project.\n\nYou can make sure it's set by running this in your ipu3-ipa checkout:\n git config format.subjectPrefix \"IPU3-IPA PATCH\"\n\nWe 'could' set up a separate list - but I think that's overkill right\nnow.\n\n\nBut this patch looks fine.\n\n\nReviewed-by: Kieran Bingham \n\n\n> \n> Signed-off-by: Han-Lin Chen \n> ---\n> aiq/aiq_input_parameters.cpp | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/aiq/aiq_input_parameters.cpp b/aiq/aiq_input_parameters.cpp\n> index 36e2b07..bc87b31 100644\n> --- a/aiq/aiq_input_parameters.cpp\n> +++ b/aiq/aiq_input_parameters.cpp\n> @@ -132,7 +132,7 @@ void AiqInputParameters::setAeAwbAfDefaults()\n> {\n> /*Ae Params */\n> aeInputParams.num_exposures = NUM_EXPOSURES;\n> - aeInputParams.frame_use = ia_aiq_frame_use_still;\n> + aeInputParams.frame_use = ia_aiq_frame_use_preview;\n> aeInputParams.flash_mode = ia_aiq_flash_mode_off;\n> aeInputParams.operation_mode = ia_aiq_ae_operation_mode_automatic;\n> aeInputParams.metering_mode = ia_aiq_ae_metering_mode_evaluative;\n> @@ -153,7 +153,7 @@ void AiqInputParameters::setAeAwbAfDefaults()\n> aeInputParams.manual_convergence_time = -1;\n> \n> /* AWB Params */\n> - awbParams.frame_use = ia_aiq_frame_use_still;\n> + awbParams.frame_use = ia_aiq_frame_use_preview;\n> awbParams.scene_mode = ia_aiq_awb_operation_mode_auto;\n> awbParams.manual_convergence_time = -1.0;\n> awbParams.manual_cct_range = nullptr;\n> @@ -161,7 +161,7 @@ void AiqInputParameters::setAeAwbAfDefaults()\n> \n> /* AF Params */\n> afParams = {\n> - ia_aiq_frame_use_still, 0, 1500,\n> + ia_aiq_frame_use_preview, 0, 1500,\n> ia_aiq_af_operation_mode_auto,\n> ia_aiq_af_range_normal,\n> ia_aiq_af_metering_mode_auto,\n> @@ -172,11 +172,11 @@ void AiqInputParameters::setAeAwbAfDefaults()\n> /* GBCE Params */\n> gbceParams.gbce_level = ia_aiq_gbce_level_bypass;\n> gbceParams.tone_map_level = ia_aiq_tone_map_level_default;\n> - gbceParams.frame_use = ia_aiq_frame_use_still;\n> + gbceParams.frame_use = ia_aiq_frame_use_preview;\n> gbceParams.ev_shift = 0;\n> \n> /* SA Params */\n> - saParams.frame_use = ia_aiq_frame_use_still;\n> + saParams.frame_use = ia_aiq_frame_use_preview;\n> }\n> \n> } /* namespace ipa::ipu3::aiq */\n> -- \n> 2.33.1.1089.g2158813163f-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D4BBBF415\n\tfor ;\n\tTue, 2 Nov 2021 13:30:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC4CD600C2;\n\tTue, 2 Nov 2021 14:30:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55A68600B8\n\tfor ;\n\tTue, 2 Nov 2021 14:30:36 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF8BE2CF;\n\tTue, 2 Nov 2021 14:30:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JKnfsIuJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635859836;\n\tbh=bynJwLSD/HqM+kv9eRXbwQtchz+f13WqI7E2IRXNuwI=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=JKnfsIuJNOXzhckMEGRHstayxvaty5yooYhuyYdrL1fNAm8N23jB1F3qGLh1Sh+UP\n\txOuEdsK/mUia/jTQwUDGqrbI28SjLH4e+pDq/irp8zS6ffFHvAoOiEs/313dnCfW8D\n\tzcLbRg3mL2I6ajH9nlTZp5ihuEAYp9Nte7bkAJcU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211029120001.2469018-1-hanlinchen@chromium.org>","References":"<20211029120001.2469018-1-hanlinchen@chromium.org>","From":"Kieran Bingham ","To":"Han-Lin Chen ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 02 Nov 2021 13:30:33 +0000","Message-ID":"<163585983392.275423.11844224116887008509@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v2 1/6] ipu3: Use\n\tia_aiq_frame_use_preview as default mode for AIQ","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]