[{"id":20878,"web_url":"https://patchwork.libcamera.org/comment/20878/","msgid":"<11bb69bf-f681-760d-6827-90e2363fb4b2@ideasonboard.com>","date":"2021-11-11T18:09:10","subject":"Re: [libcamera-devel] [RFC PATCH 6/6] android: camera_request: Add\n\tthread safety annotation","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn 10/29/21 9:44 AM, Hirokazu Honda wrote:\n> This applies clang thread safety annotation to\n> Camera3RequestDescriptor. Mutex and MutexLocker there are\n> replaced with Mutex2 and MutexLocer2.\n>\n> Signed-off-by: Hirokazu Honda \n\n\nLooks fine to me,\n\nReviewed-by: Umang Jain \n\n> ---\n> src/android/camera_request.h | 7 ++++---\n> 1 file changed, 4 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/android/camera_request.h b/src/android/camera_request.h\n> index cfafa445..0c8e7287 100644\n> --- a/src/android/camera_request.h\n> +++ b/src/android/camera_request.h\n> @@ -9,10 +9,11 @@\n> \n> #include \n> #include \n> -#include \n> #include \n> \n> #include \n> +#include \n> +#include \n> \n> #include \n> #include \n> @@ -46,8 +47,8 @@ public:\n> \t};\n> \n> \t/* Keeps track of streams requiring post-processing. */\n> -\tstd::map pendingStreamsToProcess_;\n> -\tstd::mutex streamsProcessMutex_;\n> +\tstd::map pendingStreamsToProcess_ GUARDED_BY(streamsProcessMutex_);\n> +\tlibcamera::Mutex2 streamsProcessMutex_;\n> \n> \tCamera3RequestDescriptor(libcamera::Camera *camera,\n> \t\t\t\t const camera3_capture_request_t *camera3Request);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77FA8BF415\n\tfor ;\n\tThu, 11 Nov 2021 18:09:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A18CE6035A;\n\tThu, 11 Nov 2021 19:09:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CDED600B5\n\tfor ;\n\tThu, 11 Nov 2021 19:09:17 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.254])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DCC084A6;\n\tThu, 11 Nov 2021 19:09:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d6MTzhku\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636654156;\n\tbh=XZ/DBegrF83E0QybvUPFNpOld2pUwZmvr5nuugL69Uc=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=d6MTzhkuN+nftmCNE5z/WzkZh84KjQWyUBG9qYOM155Z3cG9uPOMGcW0DYOIyOX5i\n\tEFVU1/LpXg9ttSR+paNXCIMaM05pbHzpoeMeHeYpud+D7Mvw/5wbdZVVsQ3CTG3hTJ\n\tfjTdYNSbcfuNuYln7GIUzthckI9SnNE/x7uh+OYs=","To":"Hirokazu Honda , libcamera-devel@lists.libcamera.org","References":"<20211029041424.1430886-1-hiroh@chromium.org>\n\t<20211029041424.1430886-7-hiroh@chromium.org>","From":"Umang Jain ","Message-ID":"<11bb69bf-f681-760d-6827-90e2363fb4b2@ideasonboard.com>","Date":"Thu, 11 Nov 2021 23:39:10 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211029041424.1430886-7-hiroh@chromium.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [RFC PATCH 6/6] android: camera_request: Add\n\tthread safety annotation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]