[{"id":20617,"web_url":"https://patchwork.libcamera.org/comment/20617/","msgid":"","date":"2021-10-28T17:38:16","subject":"Re: [libcamera-devel] [PATCH v3] android: Camera3RequestDescriptor:\n\tProvide a constructor for StreamBuffer","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Thu, Oct 28, 2021 at 10:32:54PM +0530, Umang Jain wrote:\n> Provide a constructor for StreamBuffer and use that while populating\n> Camera3RequestDescriptor::buffers_ vector. Also provide the default\n> move-constructor (required as StreamBuffer is stored in a vector in\n> Camera3RequestDescriptor) and destructor for the StreamBuffer struct.\n> \n> Also declare a default move assignment operator and disable the\n> copy constructor and move operator explicitly with\n> LIBCAMERA_DISABLE_COPY().\n> \n> While at it, initialize pointers members in the StreamBuffer struct\n> to nullptr, with StreamBuffer::status set to Status::Success by default.\n> \n> Signed-off-by: Umang Jain \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/android/camera_request.cpp | 19 ++++++++++++++++---\n> src/android/camera_request.h | 17 ++++++++++++++---\n> 2 files changed, 30 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/android/camera_request.cpp b/src/android/camera_request.cpp\n> index 5bac1b8f..8eced51d 100644\n> --- a/src/android/camera_request.cpp\n> +++ b/src/android/camera_request.cpp\n> @@ -37,9 +37,7 @@ Camera3RequestDescriptor::Camera3RequestDescriptor(\n> \t\tCameraStream *stream =\n> \t\t\tstatic_cast(buffer.stream->priv);\n> \n> -\t\tbuffers_.push_back({ stream, buffer.buffer, nullptr,\n> -\t\t\t\t buffer.acquire_fence, Status::Success,\n> -\t\t\t\t nullptr, nullptr, nullptr, this });\n> +\t\tbuffers_.emplace_back(stream, buffer, this);\n> \t}\n> \n> \t/* Clone the controls associated with the camera3 request. */\n> @@ -54,3 +52,18 @@ Camera3RequestDescriptor::Camera3RequestDescriptor(\n> }\n> \n> Camera3RequestDescriptor::~Camera3RequestDescriptor() = default;\n> +\n> +Camera3RequestDescriptor::StreamBuffer::StreamBuffer(\n> +\tCameraStream *stream, const camera3_stream_buffer_t &buffer,\n> +\tCamera3RequestDescriptor *request)\n> +\t: camera3Buffer(buffer.buffer), fence(buffer.acquire_fence),\n> +\t stream(stream), request(request)\n> +{\n> +}\n> +\n> +Camera3RequestDescriptor::StreamBuffer::~StreamBuffer() = default;\n> +\n> +Camera3RequestDescriptor::StreamBuffer::StreamBuffer(StreamBuffer &&other) = default;\n> +\n> +Camera3RequestDescriptor::StreamBuffer &\n> +Camera3RequestDescriptor::StreamBuffer::operator=(Camera3RequestDescriptor::StreamBuffer &&) = default;\n> diff --git a/src/android/camera_request.h b/src/android/camera_request.h\n> index cfafa445..d2935c99 100644\n> --- a/src/android/camera_request.h\n> +++ b/src/android/camera_request.h\n> @@ -34,15 +34,26 @@ public:\n> \t};\n> \n> \tstruct StreamBuffer {\n> +\t\tStreamBuffer(CameraStream *stream,\n> +\t\t\t const camera3_stream_buffer_t &buffer,\n> +\t\t\t Camera3RequestDescriptor *request);\n> +\t\t~StreamBuffer();\n> +\n> +\t\tStreamBuffer(StreamBuffer &&other);\n> +\t\tStreamBuffer &operator=(StreamBuffer &&);\n\n\t\tStreamBuffer &operator=(StreamBuffer &&other);\n\nand possibly the same in the .cpp file (although I won't object if you\ninstead remove the variable name from the move constructor there).\n\n> +\n> \t\tCameraStream *stream;\n> \t\tbuffer_handle_t *camera3Buffer;\n> \t\tstd::unique_ptr frameBuffer;\n> \t\tint fence;\n> -\t\tStatus status;\n> -\t\tlibcamera::FrameBuffer *internalBuffer;\n> -\t\tconst libcamera::FrameBuffer *srcBuffer;\n> +\t\tStatus status = Status::Success;\n> +\t\tlibcamera::FrameBuffer *internalBuffer = nullptr;\n> +\t\tconst libcamera::FrameBuffer *srcBuffer = nullptr;\n> \t\tstd::unique_ptr dstBuffer;\n> \t\tCamera3RequestDescriptor *request;\n> +\n> +\tprivate:\n> +\t\tLIBCAMERA_DISABLE_COPY(StreamBuffer)\n> \t};\n> \n> \t/* Keeps track of streams requiring post-processing. */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE6A6BF415\n\tfor ;\n\tThu, 28 Oct 2021 17:38:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10CD4600BA;\n\tThu, 28 Oct 2021 19:38:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09E7E600B5\n\tfor ;\n\tThu, 28 Oct 2021 19:38:41 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 74FF3513;\n\tThu, 28 Oct 2021 19:38:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WUtDWG7v\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635442720;\n\tbh=L8OnCXgNkRO6TStg0p6tcjY4rdNLGm+nOC57HT2DQeU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WUtDWG7vuYd9JYWPDFEucy5qHoycbIXoYBbYcxurPAf7/kQzueju8gl26c2sTE2iK\n\t7IbM1fwhUvPD0McUUQEEkK9D1geWMfgY46wbD2ZPhev9g+0z8Hb99LmYfEyO7s4p5N\n\twFU2BLpzRYLbCJnTgD9sWzgb8dNAAG2qy7vWyGN0=","Date":"Thu, 28 Oct 2021 20:38:16 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20211028170254.502151-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211028170254.502151-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3] android: Camera3RequestDescriptor:\n\tProvide a constructor for StreamBuffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20622,"web_url":"https://patchwork.libcamera.org/comment/20622/","msgid":"","date":"2021-10-29T02:54:10","subject":"Re: [libcamera-devel] [PATCH v3] android: Camera3RequestDescriptor:\n\tProvide a constructor for StreamBuffer","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"HI Umang,\n\nOn Fri, Oct 29, 2021 at 2:38 AM Laurent Pinchart\n wrote:\n>\n> Hi Umang,\n>\n> Thank you for the patch.\n>\n> On Thu, Oct 28, 2021 at 10:32:54PM +0530, Umang Jain wrote:\n> > Provide a constructor for StreamBuffer and use that while populating\n> > Camera3RequestDescriptor::buffers_ vector. Also provide the default\n> > move-constructor (required as StreamBuffer is stored in a vector in\n> > Camera3RequestDescriptor) and destructor for the StreamBuffer struct.\n> >\n> > Also declare a default move assignment operator and disable the\n> > copy constructor and move operator explicitly with\n> > LIBCAMERA_DISABLE_COPY().\n> >\n> > While at it, initialize pointers members in the StreamBuffer struct\n> > to nullptr, with StreamBuffer::status set to Status::Success by default.\n> >\n> > Signed-off-by: Umang Jain \n> > Reviewed-by: Laurent Pinchart \n> > ---\n> > src/android/camera_request.cpp | 19 ++++++++++++++++---\n> > src/android/camera_request.h | 17 ++++++++++++++---\n> > 2 files changed, 30 insertions(+), 6 deletions(-)\n> >\n> > diff --git a/src/android/camera_request.cpp b/src/android/camera_request.cpp\n> > index 5bac1b8f..8eced51d 100644\n> > --- a/src/android/camera_request.cpp\n> > +++ b/src/android/camera_request.cpp\n> > @@ -37,9 +37,7 @@ Camera3RequestDescriptor::Camera3RequestDescriptor(\n> > CameraStream *stream =\n> > static_cast(buffer.stream->priv);\n> >\n> > - buffers_.push_back({ stream, buffer.buffer, nullptr,\n> > - buffer.acquire_fence, Status::Success,\n> > - nullptr, nullptr, nullptr, this });\n> > + buffers_.emplace_back(stream, buffer, this);\n> > }\n> >\n> > /* Clone the controls associated with the camera3 request. */\n> > @@ -54,3 +52,18 @@ Camera3RequestDescriptor::Camera3RequestDescriptor(\n> > }\n> >\n> > Camera3RequestDescriptor::~Camera3RequestDescriptor() = default;\n> > +\n> > +Camera3RequestDescriptor::StreamBuffer::StreamBuffer(\n> > + CameraStream *stream, const camera3_stream_buffer_t &buffer,\n> > + Camera3RequestDescriptor *request)\n> > + : camera3Buffer(buffer.buffer), fence(buffer.acquire_fence),\n> > + stream(stream), request(request)\n> > +{\n> > +}\n> > +\n> > +Camera3RequestDescriptor::StreamBuffer::~StreamBuffer() = default;\n> > +\n> > +Camera3RequestDescriptor::StreamBuffer::StreamBuffer(StreamBuffer &&other) = default;\n> > +\n> > +Camera3RequestDescriptor::StreamBuffer &\n> > +Camera3RequestDescriptor::StreamBuffer::operator=(Camera3RequestDescriptor::StreamBuffer &&) = default;\n> > diff --git a/src/android/camera_request.h b/src/android/camera_request.h\n> > index cfafa445..d2935c99 100644\n> > --- a/src/android/camera_request.h\n> > +++ b/src/android/camera_request.h\n> > @@ -34,15 +34,26 @@ public:\n> > };\n> >\n> > struct StreamBuffer {\n> > + StreamBuffer(CameraStream *stream,\n> > + const camera3_stream_buffer_t &buffer,\n> > + Camera3RequestDescriptor *request);\n> > + ~StreamBuffer();\n> > +\n> > + StreamBuffer(StreamBuffer &&other);\n> > + StreamBuffer &operator=(StreamBuffer &&);\n>\n> StreamBuffer &operator=(StreamBuffer &&other);\n>\n> and possibly the same in the .cpp file (although I won't object if you\n> instead remove the variable name from the move constructor there).\n>\n\nReviewed-by: Hirokazu Honda \n> > +\n> > CameraStream *stream;\n> > buffer_handle_t *camera3Buffer;\n> > std::unique_ptr frameBuffer;\n> > int fence;\n> > - Status status;\n> > - libcamera::FrameBuffer *internalBuffer;\n> > - const libcamera::FrameBuffer *srcBuffer;\n> > + Status status = Status::Success;\n> > + libcamera::FrameBuffer *internalBuffer = nullptr;\n> > + const libcamera::FrameBuffer *srcBuffer = nullptr;\n> > std::unique_ptr dstBuffer;\n> > Camera3RequestDescriptor *request;\n> > +\n> > + private:\n> > + LIBCAMERA_DISABLE_COPY(StreamBuffer)\n> > };\n> >\n> > /* Keeps track of streams requiring post-processing. */\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6047ABDB1C\n\tfor ;\n\tFri, 29 Oct 2021 02:54:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 97B83600BB;\n\tFri, 29 Oct 2021 04:54:23 +0200 (CEST)","from mail-ed1-x536.google.com (mail-ed1-x536.google.com\n\t[IPv6:2a00:1450:4864:20::536])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E664C600B6\n\tfor ;\n\tFri, 29 Oct 2021 04:54:21 +0200 (CEST)","by mail-ed1-x536.google.com with SMTP id w1so14413961edd.0\n\tfor ;\n\tThu, 28 Oct 2021 19:54:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"ZR/2dEQj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=s6aZF1TWSdPVg5VW7CYnwVYGu9rs2eZGpztjmc8gmoY=;\n\tb=ZR/2dEQjCfz/r47zA+TndQS6cuW4AwTm/GMZ7v5p6v1NUsZ2aTEZi5ME1+cTnxL2y2\n\ts3ETLOY1QwKhy96hArM/NfAcZtHWlreTo4ZyQ5zParpJFoSgeDvZwILfyXAbJ9/6AY1j\n\tMrh8wP06ZT3fY8j09pBkDGI3fdmCOzmdWt6lE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=s6aZF1TWSdPVg5VW7CYnwVYGu9rs2eZGpztjmc8gmoY=;\n\tb=zHOPCivrZtyAhGXu7x603L8G4VsRPhgYbNtSucZsUF1AuKD0bfP7V0MhTnsZsW92c6\n\t+lacmGY6mknuoxEvwiAtkwdZ0Coef/B9HmYwFzenDOrCioy6fdTUL2WIkDM94nuIXPD6\n\tW77ccfw+lTXEAcIsJo/SOrHpZF59MlNSqu+Zr9ZjYdUEeXzJpAIzrJJJii0/ZNqb+xh7\n\tBiZ+Ct9CpaONkIXFha9l49oW+DR9BdJ6MqbCzJOz2jsL6E+J6bCisPYOYcKEGyywZ3uw\n\tWgC/xTNQPlzn8B6yQmTxKiYmG6chXxqAZrccTm3iMykVO0akJ0XwFFXDSV6tmHzgGh8K\n\t8iBA==","X-Gm-Message-State":"AOAM530iG+bbN6bhYj5G+/rO4ZOtoS+p0He6xRcTnR+KpO5NEoQIdoUM\n\t+NPYhqtqMDH6KEc98DMKsK/8qyRVMjschtBCjxmyTg==","X-Google-Smtp-Source":"ABdhPJzPWRSrlpyl8ndxnN9t5C38DfAFgkdKZHaA84wnZoRQWk4ek5zHkl8wD+mhNCtxxygYgw/zNBT3aDr/2O33o4w=","X-Received":"by 2002:a17:906:26ce:: with SMTP id\n\tu14mr10449792ejc.559.1635476061420; \n\tThu, 28 Oct 2021 19:54:21 -0700 (PDT)","MIME-Version":"1.0","References":"<20211028170254.502151-1-umang.jain@ideasonboard.com>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Fri, 29 Oct 2021 11:54:10 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v3] android: Camera3RequestDescriptor:\n\tProvide a constructor for StreamBuffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20623,"web_url":"https://patchwork.libcamera.org/comment/20623/","msgid":"<20211029074246.5josqpr7djs6d6e2@uno.localdomain>","date":"2021-10-29T07:42:46","subject":"Re: [libcamera-devel] [PATCH v3] android: Camera3RequestDescriptor:\n\tProvide a constructor for StreamBuffer","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Uman,\n\nOn Thu, Oct 28, 2021 at 10:32:54PM +0530, Umang Jain wrote:\n> Provide a constructor for StreamBuffer and use that while populating\n> Camera3RequestDescriptor::buffers_ vector. Also provide the default\n> move-constructor (required as StreamBuffer is stored in a vector in\n> Camera3RequestDescriptor) and destructor for the StreamBuffer struct.\n>\n> Also declare a default move assignment operator and disable the\n> copy constructor and move operator explicitly with\n> LIBCAMERA_DISABLE_COPY().\n>\n> While at it, initialize pointers members in the StreamBuffer struct\n> to nullptr, with StreamBuffer::status set to Status::Success by default.\n>\n> Signed-off-by: Umang Jain \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/camera_request.cpp | 19 ++++++++++++++++---\n> src/android/camera_request.h | 17 ++++++++++++++---\n> 2 files changed, 30 insertions(+), 6 deletions(-)\n>\n> diff --git a/src/android/camera_request.cpp b/src/android/camera_request.cpp\n> index 5bac1b8f..8eced51d 100644\n> --- a/src/android/camera_request.cpp\n> +++ b/src/android/camera_request.cpp\n> @@ -37,9 +37,7 @@ Camera3RequestDescriptor::Camera3RequestDescriptor(\n> \t\tCameraStream *stream =\n> \t\t\tstatic_cast(buffer.stream->priv);\n>\n> -\t\tbuffers_.push_back({ stream, buffer.buffer, nullptr,\n> -\t\t\t\t buffer.acquire_fence, Status::Success,\n> -\t\t\t\t nullptr, nullptr, nullptr, this });\n> +\t\tbuffers_.emplace_back(stream, buffer, this);\n> \t}\n>\n> \t/* Clone the controls associated with the camera3 request. */\n> @@ -54,3 +52,18 @@ Camera3RequestDescriptor::Camera3RequestDescriptor(\n> }\n>\n> Camera3RequestDescriptor::~Camera3RequestDescriptor() = default;\n> +\n> +Camera3RequestDescriptor::StreamBuffer::StreamBuffer(\n> +\tCameraStream *stream, const camera3_stream_buffer_t &buffer,\n> +\tCamera3RequestDescriptor *request)\n> +\t: camera3Buffer(buffer.buffer), fence(buffer.acquire_fence),\n> +\t stream(stream), request(request)\n> +{\n> +}\n> +\n> +Camera3RequestDescriptor::StreamBuffer::~StreamBuffer() = default;\n> +\n> +Camera3RequestDescriptor::StreamBuffer::StreamBuffer(StreamBuffer &&other) = default;\n> +\n> +Camera3RequestDescriptor::StreamBuffer &\n> +Camera3RequestDescriptor::StreamBuffer::operator=(Camera3RequestDescriptor::StreamBuffer &&) = default;\n> diff --git a/src/android/camera_request.h b/src/android/camera_request.h\n> index cfafa445..d2935c99 100644\n> --- a/src/android/camera_request.h\n> +++ b/src/android/camera_request.h\n> @@ -34,15 +34,26 @@ public:\n> \t};\n>\n> \tstruct StreamBuffer {\n> +\t\tStreamBuffer(CameraStream *stream,\n> +\t\t\t const camera3_stream_buffer_t &buffer,\n> +\t\t\t Camera3RequestDescriptor *request);\n> +\t\t~StreamBuffer();\n> +\n> +\t\tStreamBuffer(StreamBuffer &&other);\n> +\t\tStreamBuffer &operator=(StreamBuffer &&);\n> +\n> \t\tCameraStream *stream;\n> \t\tbuffer_handle_t *camera3Buffer;\n> \t\tstd::unique_ptr frameBuffer;\n> \t\tint fence;\n> -\t\tStatus status;\n> -\t\tlibcamera::FrameBuffer *internalBuffer;\n> -\t\tconst libcamera::FrameBuffer *srcBuffer;\n> +\t\tStatus status = Status::Success;\n> +\t\tlibcamera::FrameBuffer *internalBuffer = nullptr;\n> +\t\tconst libcamera::FrameBuffer *srcBuffer = nullptr;\n> \t\tstd::unique_ptr dstBuffer;\n> \t\tCamera3RequestDescriptor *request;\n> +\n> +\tprivate:\n> +\t\tLIBCAMERA_DISABLE_COPY(StreamBuffer)\n> \t};\n>\n> \t/* Keeps track of streams requiring post-processing. */\n> --\n> 2.31.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5DBBBDB1C\n\tfor ;\n\tFri, 29 Oct 2021 07:41:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2994F600BB;\n\tFri, 29 Oct 2021 09:41:58 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C013600B4\n\tfor ;\n\tFri, 29 Oct 2021 09:41:57 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id C5FE320000C;\n\tFri, 29 Oct 2021 07:41:56 +0000 (UTC)"],"Date":"Fri, 29 Oct 2021 09:42:46 +0200","From":"Jacopo Mondi ","To":"Umang Jain ","Message-ID":"<20211029074246.5josqpr7djs6d6e2@uno.localdomain>","References":"<20211028170254.502151-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211028170254.502151-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3] android: Camera3RequestDescriptor:\n\tProvide a constructor for StreamBuffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]