[{"id":20609,"web_url":"https://patchwork.libcamera.org/comment/20609/","msgid":"","date":"2021-10-28T13:29:36","subject":"Re: [libcamera-devel] [PATCH 6/6] ipu3: Use gbce and tone mapping\n\tfrom the tuning files","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Han-Lin,\n\nThank you for the patch.\n\nOn 10/28/21 3:33 PM, Han-Lin Chen wrote:\n> Change the flags to gbce algorithm to use the global brightness and tone\n> mapping from the tunint files.\n>\n> Signed-off-by: Han-Lin Chen \n\n\nReviewed-by: Umang Jain \n> ---\n> aiq/aiq_input_parameters.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/aiq/aiq_input_parameters.cpp b/aiq/aiq_input_parameters.cpp\n> index 5dd2f6c..7a6a1fa 100644\n> --- a/aiq/aiq_input_parameters.cpp\n> +++ b/aiq/aiq_input_parameters.cpp\n> @@ -170,8 +170,8 @@ void AiqInputParameters::setAeAwbAfDefaults()\n> \t};\n> \n> \t/* GBCE Params */\n> -\tgbceParams.gbce_level = ia_aiq_gbce_level_bypass;\n> -\tgbceParams.tone_map_level = ia_aiq_tone_map_level_default;\n> +\tgbceParams.gbce_level = ia_aiq_gbce_level_use_tuning;\n> +\tgbceParams.tone_map_level = ia_aiq_tone_map_level_use_tuning;\n> \tgbceParams.frame_use = ia_aiq_frame_use_preview;\n> \tgbceParams.ev_shift = 0;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36E71BDB1C\n\tfor ;\n\tThu, 28 Oct 2021 13:29:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D651600B7;\n\tThu, 28 Oct 2021 15:29:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F575600B5\n\tfor ;\n\tThu, 28 Oct 2021 15:29:44 +0200 (CEST)","from [192.168.43.203] (unknown [157.33.50.95])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 77D76513;\n\tThu, 28 Oct 2021 15:29:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UIekPBTw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635427783;\n\tbh=xxNa/Zdis75f0CA9qTLGD7eMRlwC7gZ1nyPiHX4LLPc=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=UIekPBTwzjSWmRrIktwYjUvcij1sonaKU5an/4HRZvwXQxFldlGyEfk5svjVleEGf\n\tLDbLr9CuXIiLh55XFtpesxp2nY7+ym5Zvyt3jVnPNeX548wifEwQ1CJ7JAgdeKbLoY\n\t9MpMwvrX4snYYlcTQv/q+6UaHwb6zw+Cq+LBd62c=","To":"Han-Lin Chen ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211028100349.1098545-1-hanlinchen@chromium.org>\n\t<20211028100349.1098545-6-hanlinchen@chromium.org>","From":"Umang Jain ","Message-ID":"","Date":"Thu, 28 Oct 2021 18:59:36 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211028100349.1098545-6-hanlinchen@chromium.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 6/6] ipu3: Use gbce and tone mapping\n\tfrom the tuning files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Han-Lin Chen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]