[{"id":20579,"web_url":"https://patchwork.libcamera.org/comment/20579/","msgid":"<1365b929-0f01-0076-d7d9-d6336ae12f8f@ideasonboard.com>","date":"2021-10-27T13:14:24","subject":"Re: [libcamera-devel] [PATCH] libcamera: pixel_format: remove\n\tduplicated return documentation","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hello,\n\nThank you for the patch\n\nOn 10/27/21 6:41 PM, Kieran Bingham wrote:\n> The PixelFormat::toString() has two \\return statements in its\n> doxygen documentation.\n>\n> Remove the redundant one.\n>\n> Signed-off-by: Kieran Bingham \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/pixel_format.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n>\n> diff --git a/src/libcamera/pixel_format.cpp b/src/libcamera/pixel_format.cpp\n> index 54763fbf8e33..997aeb8a9290 100644\n> --- a/src/libcamera/pixel_format.cpp\n> +++ b/src/libcamera/pixel_format.cpp\n> @@ -132,7 +132,6 @@ std::string PixelFormat::toString() const\n> \n> /**\n> * \\brief Create a PixelFormat from a string\n> - * \\return Pixel format\n> * \\return The PixelFormat represented by the \\a name if known, or an\n> * invalid pixel format otherwise.\n> */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3463BBF415\n\tfor ;\n\tWed, 27 Oct 2021 13:14:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D5E964882;\n\tWed, 27 Oct 2021 15:14:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35E1260123\n\tfor ;\n\tWed, 27 Oct 2021 15:14:29 +0200 (CEST)","from [192.168.1.106] (unknown [103.251.226.211])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 42221596;\n\tWed, 27 Oct 2021 15:14:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fEU+ClvQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635340468;\n\tbh=BFQprWOFCXHe9pbkbOWpfEIPHadASRP6BwXL7TzN6Gw=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=fEU+ClvQf8vWCokF5fk3OxO3XU3/EWoXFueNVySUUBkpuZwYxjxuGESXrMSD22Oym\n\tuZO7rcp5NwROq4QbxvkbSr3c+KkWaZRfB6ZJmesNRffUFsocASJA6vwRpTDuua+2nx\n\tx84F0w6wbJp3ASuVWgm7MIWks/hFlBQKfEfulEG4=","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20211027131113.2275437-1-kieran.bingham@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<1365b929-0f01-0076-d7d9-d6336ae12f8f@ideasonboard.com>","Date":"Wed, 27 Oct 2021 18:44:24 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211027131113.2275437-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pixel_format: remove\n\tduplicated return documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20581,"web_url":"https://patchwork.libcamera.org/comment/20581/","msgid":"","date":"2021-10-27T13:18:36","subject":"Re: [libcamera-devel] [PATCH] libcamera: pixel_format: remove\n\tduplicated return documentation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Oct 27, 2021 at 02:11:13PM +0100, Kieran Bingham wrote:\n> The PixelFormat::toString() has two \\return statements in its\n> doxygen documentation.\n\nI would have expected doxygen to warn about that.\n\n> Remove the redundant one.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n\nReviewed-by: Laurent Pinchart \n\n> src/libcamera/pixel_format.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/libcamera/pixel_format.cpp b/src/libcamera/pixel_format.cpp\n> index 54763fbf8e33..997aeb8a9290 100644\n> --- a/src/libcamera/pixel_format.cpp\n> +++ b/src/libcamera/pixel_format.cpp\n> @@ -132,7 +132,6 @@ std::string PixelFormat::toString() const\n> \n> /**\n> * \\brief Create a PixelFormat from a string\n> - * \\return Pixel format\n> * \\return The PixelFormat represented by the \\a name if known, or an\n> * invalid pixel format otherwise.\n> */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32885BDB1C\n\tfor ;\n\tWed, 27 Oct 2021 13:19:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A32076487F;\n\tWed, 27 Oct 2021 15:19:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 52F3160123\n\tfor ;\n\tWed, 27 Oct 2021 15:19:00 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B7D4E596;\n\tWed, 27 Oct 2021 15:18:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NiQDmh2T\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635340739;\n\tbh=gCzGo8PRV00sgLUtNdVVn+RVQdDiiO7tt1Dw++UtrHk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NiQDmh2TSk6PVN37pYAoe//Qdh2SCCeVXLAN4qUdih5srj2VRwcAqPtLBpjvqB3bR\n\tP2oHMHHfmuKGnvfj0SCKc7rNY/uaMoOKuRR+dd8JlBtOqXua1GMNl09bkKzfhEBVE2\n\tSKpaFQl2VQRUenmGFvgD7bPygoqn9IKbpdx3cXhg=","Date":"Wed, 27 Oct 2021 16:18:36 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20211027131113.2275437-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211027131113.2275437-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pixel_format: remove\n\tduplicated return documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]