[{"id":20534,"web_url":"https://patchwork.libcamera.org/comment/20534/","msgid":"","date":"2021-10-26T10:17:20","subject":"Re: [libcamera-devel] [PATCH v4 19/19] ipa: ipu3: ipa_context: Fix\n\tdoxygen references","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi JM / Kieran,\n\nOn 10/26/21 3:25 PM, Jean-Michel Hautbois wrote:\n> From: Kieran Bingham \n>\n> The IPAFrameContext uses unamed structures to group items. Doxygen can\ns/unamed/unnamed/\n> not reference the member variables of the container structures through\n> the variable names, and expects the structure type name. As this is not\n> given, the structure variables are referenced from the parent structure.\n>\n> Signed-off-by: Kieran Bingham \n> [JMH: Fix doxygen variable usage]\n> Signed-off-by: Jean-Michel Hautbois \n\n\nReviewed-by: Umang Jain \n> ---\n> src/ipa/ipu3/ipa_context.cpp | 30 +++++++++++++++---------------\n> 1 file changed, 15 insertions(+), 15 deletions(-)\n>\n> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n> index 8917ba54..68e2f4aa 100644\n> --- a/src/ipa/ipu3/ipa_context.cpp\n> +++ b/src/ipa/ipu3/ipa_context.cpp\n> @@ -59,13 +59,13 @@ namespace libcamera::ipa::ipu3 {\n> * \\var IPASessionConfiguration::grid\n> * \\brief Grid configuration of the IPA\n> *\n> - * \\var IPASessionConfiguration::grid::bdsGrid\n> + * \\var IPASessionConfiguration::grid.bdsGrid\n> * \\brief Bayer Down Scaler grid plane config used by the kernel\n> *\n> - * \\var IPASessionConfiguration::grid::bdsOutputSize\n> + * \\var IPASessionConfiguration::grid.bdsOutputSize\n> * \\brief BDS output size configured by the pipeline handler\n> *\n> - * \\var IPASessionConfiguration::grid::stride\n> + * \\var IPASessionConfiguration::grid.stride\n> * \\brief Number of cells on one line including the ImgU padding\n> */\n> \n> @@ -73,16 +73,16 @@ namespace libcamera::ipa::ipu3 {\n> * \\var IPASessionConfiguration::agc\n> * \\brief AGC parameters configuration of the IPA\n> *\n> - * \\var IPASessionConfiguration::agc::minShutterSpeed\n> + * \\var IPASessionConfiguration::agc.minShutterSpeed\n> * \\brief Minimum shutter speed supported with the configured sensor\n> *\n> - * \\var IPASessionConfiguration::grid::maxShutterSpeed\n> + * \\var IPASessionConfiguration::grid.maxShutterSpeed\n> * \\brief Maximum shutter speed supported with the configured sensor\n> *\n> - * \\var IPASessionConfiguration::grid::minAnalogueGain\n> + * \\var IPASessionConfiguration::grid.minAnalogueGain\n> * \\brief Minimum analogue gain supported with the configured sensor\n> *\n> - * \\var IPASessionConfiguration::grid::maxAnalogueGain\n> + * \\var IPASessionConfiguration::grid.maxAnalogueGain\n> * \\brief Maximum analogue gain supported with the configured sensor\n> */\n> \n> @@ -93,10 +93,10 @@ namespace libcamera::ipa::ipu3 {\n> * The exposure and gain determined are expected to be applied to the sensor\n> * at the earliest opportunity.\n> *\n> - * \\var IPAFrameContext::agc::exposure\n> + * \\var IPAFrameContext::agc.exposure\n> * \\brief Exposure time expressed as a number of lines\n> *\n> - * \\var IPAFrameContext::agc::gain\n> + * \\var IPAFrameContext::agc.gain\n> * \\brief Analogue gain multiplier\n> *\n> * The gain should be adapted to the sensor specific gain code before applying.\n> @@ -106,16 +106,16 @@ namespace libcamera::ipa::ipu3 {\n> * \\var IPAFrameContext::awb\n> * \\brief Context for the Automatic White Balance algorithm\n> *\n> - * \\struct IPAFrameContext::awb::gains\n> + * \\struct IPAFrameContext::awb.gains\n> * \\brief White balance gains\n> *\n> - * \\var IPAFrameContext::awb::gains::red\n> + * \\var IPAFrameContext::awb.gains.red\n> * \\brief White balance gain for R channel\n> *\n> - * \\var IPAFrameContext::awb::gains::green\n> + * \\var IPAFrameContext::awb.gains.green\n> * \\brief White balance gain for G channel\n> *\n> - * \\var IPAFrameContext::awb::gains::blue\n> + * \\var IPAFrameContext::awb.gains.blue\n> * \\brief White balance gain for B channel\n> */\n> \n> @@ -123,10 +123,10 @@ namespace libcamera::ipa::ipu3 {\n> * \\var IPAFrameContext::toneMapping\n> * \\brief Context for ToneMapping and Gamma control\n> *\n> - * \\var IPAFrameContext::toneMapping::gamma\n> + * \\var IPAFrameContext::toneMapping.gamma\n> * \\brief Gamma value for the LUT\n> *\n> - * \\var IPAFrameContext::toneMapping::gammaCorrection\n> + * \\var IPAFrameContext::toneMapping.gammaCorrection\n> * \\brief Per-pixel tone mapping implemented as a LUT\n> *\n> * The LUT structure is defined by the IPU3 kernel interface. See","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC918BF415\n\tfor ;\n\tTue, 26 Oct 2021 10:17:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 97BEA60237;\n\tTue, 26 Oct 2021 12:17:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C252760123\n\tfor ;\n\tTue, 26 Oct 2021 12:17:24 +0200 (CEST)","from [192.168.1.106] (unknown [103.251.226.211])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C4DB3292;\n\tTue, 26 Oct 2021 12:17:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CoDNBI7L\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635243444;\n\tbh=5cmy/0s74JmXgV78t+mPzUF0E/5vUY4/aipc0hzIOxo=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=CoDNBI7Lvy1vvpjLkAB8IpW51qfNpW1swaiN1eQnxK2KK+qzJF+gjaIUps4n0XxeT\n\trsQKmlBjriJdVu/xWxKUW3yJ4+lfwYL69LDQ4KaU1Tme2DAYHiePEDbzk3ImsfUhds\n\tD4sYc4EHalBH6ze8Kia7NVGUoti/L/8QKj5XXgYI=","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211026095534.90348-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211026095534.90348-20-jeanmichel.hautbois@ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Tue, 26 Oct 2021 15:47:20 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211026095534.90348-20-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v4 19/19] ipa: ipu3: ipa_context: Fix\n\tdoxygen references","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20536,"web_url":"https://patchwork.libcamera.org/comment/20536/","msgid":"","date":"2021-10-26T10:26:47","subject":"Re: [libcamera-devel] [PATCH v4 19/19] ipa: ipu3: ipa_context: Fix\n\tdoxygen references","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Tue, Oct 26, 2021 at 11:55:34AM +0200, Jean-Michel Hautbois wrote:\n> From: Kieran Bingham \n> \n> The IPAFrameContext uses unamed structures to group items. Doxygen can\n> not reference the member variables of the container structures through\n> the variable names, and expects the structure type name. As this is not\n> given, the structure variables are referenced from the parent structure.\n\nI'd explain here that there's a doxygen issue.\n\nThe IPAFrameContext uses unamed structures to group items. Doxygen\ndoesn't seem to support this properly, documentation isn't properly\ngenerated and warnings are output during compilation. Suppress the\nwarning with a workaround that still results in incorrect generated\ndocumentation until Doxygen gets fixed.\n\n\nYou may also want to s/references/warnings/ in the subject line.\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Kieran Bingham \n> [JMH: Fix doxygen variable usage]\n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/ipa_context.cpp | 30 +++++++++++++++---------------\n> 1 file changed, 15 insertions(+), 15 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n> index 8917ba54..68e2f4aa 100644\n> --- a/src/ipa/ipu3/ipa_context.cpp\n> +++ b/src/ipa/ipu3/ipa_context.cpp\n> @@ -59,13 +59,13 @@ namespace libcamera::ipa::ipu3 {\n> * \\var IPASessionConfiguration::grid\n> * \\brief Grid configuration of the IPA\n> *\n> - * \\var IPASessionConfiguration::grid::bdsGrid\n> + * \\var IPASessionConfiguration::grid.bdsGrid\n> * \\brief Bayer Down Scaler grid plane config used by the kernel\n> *\n> - * \\var IPASessionConfiguration::grid::bdsOutputSize\n> + * \\var IPASessionConfiguration::grid.bdsOutputSize\n> * \\brief BDS output size configured by the pipeline handler\n> *\n> - * \\var IPASessionConfiguration::grid::stride\n> + * \\var IPASessionConfiguration::grid.stride\n> * \\brief Number of cells on one line including the ImgU padding\n> */\n> \n> @@ -73,16 +73,16 @@ namespace libcamera::ipa::ipu3 {\n> * \\var IPASessionConfiguration::agc\n> * \\brief AGC parameters configuration of the IPA\n> *\n> - * \\var IPASessionConfiguration::agc::minShutterSpeed\n> + * \\var IPASessionConfiguration::agc.minShutterSpeed\n> * \\brief Minimum shutter speed supported with the configured sensor\n> *\n> - * \\var IPASessionConfiguration::grid::maxShutterSpeed\n> + * \\var IPASessionConfiguration::grid.maxShutterSpeed\n> * \\brief Maximum shutter speed supported with the configured sensor\n> *\n> - * \\var IPASessionConfiguration::grid::minAnalogueGain\n> + * \\var IPASessionConfiguration::grid.minAnalogueGain\n> * \\brief Minimum analogue gain supported with the configured sensor\n> *\n> - * \\var IPASessionConfiguration::grid::maxAnalogueGain\n> + * \\var IPASessionConfiguration::grid.maxAnalogueGain\n> * \\brief Maximum analogue gain supported with the configured sensor\n> */\n> \n> @@ -93,10 +93,10 @@ namespace libcamera::ipa::ipu3 {\n> * The exposure and gain determined are expected to be applied to the sensor\n> * at the earliest opportunity.\n> *\n> - * \\var IPAFrameContext::agc::exposure\n> + * \\var IPAFrameContext::agc.exposure\n> * \\brief Exposure time expressed as a number of lines\n> *\n> - * \\var IPAFrameContext::agc::gain\n> + * \\var IPAFrameContext::agc.gain\n> * \\brief Analogue gain multiplier\n> *\n> * The gain should be adapted to the sensor specific gain code before applying.\n> @@ -106,16 +106,16 @@ namespace libcamera::ipa::ipu3 {\n> * \\var IPAFrameContext::awb\n> * \\brief Context for the Automatic White Balance algorithm\n> *\n> - * \\struct IPAFrameContext::awb::gains\n> + * \\struct IPAFrameContext::awb.gains\n> * \\brief White balance gains\n> *\n> - * \\var IPAFrameContext::awb::gains::red\n> + * \\var IPAFrameContext::awb.gains.red\n> * \\brief White balance gain for R channel\n> *\n> - * \\var IPAFrameContext::awb::gains::green\n> + * \\var IPAFrameContext::awb.gains.green\n> * \\brief White balance gain for G channel\n> *\n> - * \\var IPAFrameContext::awb::gains::blue\n> + * \\var IPAFrameContext::awb.gains.blue\n> * \\brief White balance gain for B channel\n> */\n> \n> @@ -123,10 +123,10 @@ namespace libcamera::ipa::ipu3 {\n> * \\var IPAFrameContext::toneMapping\n> * \\brief Context for ToneMapping and Gamma control\n> *\n> - * \\var IPAFrameContext::toneMapping::gamma\n> + * \\var IPAFrameContext::toneMapping.gamma\n> * \\brief Gamma value for the LUT\n> *\n> - * \\var IPAFrameContext::toneMapping::gammaCorrection\n> + * \\var IPAFrameContext::toneMapping.gammaCorrection\n> * \\brief Per-pixel tone mapping implemented as a LUT\n> *\n> * The LUT structure is defined by the IPU3 kernel interface. See","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B267DBF415\n\tfor ;\n\tTue, 26 Oct 2021 10:27:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 282DA60237;\n\tTue, 26 Oct 2021 12:27:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40D7360123\n\tfor ;\n\tTue, 26 Oct 2021 12:27:10 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B908D3F0;\n\tTue, 26 Oct 2021 12:27:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i0+C1oqS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635244029;\n\tbh=TIhZwa6geiyhLc1kBrFATr48jZ1BdMqN71dGaJYc5pg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=i0+C1oqS1d4LXdXa3bmkOk/1sxez9MKVgiz9mmy4MfIA07MNqdkwv1TkgsmjYpX9S\n\tOeMF1VvoUD/4BErvVmzG4+WATr1ZU2B3z8Lt4VZO3ty2xIMFEDqJ16cw2vUOu+1CE5\n\tYtBsddktk5qqVbc0PQVnD8z0KhuVnxPuuYfItRw8=","Date":"Tue, 26 Oct 2021 13:26:47 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20211026095534.90348-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211026095534.90348-20-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211026095534.90348-20-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 19/19] ipa: ipu3: ipa_context: Fix\n\tdoxygen references","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20542,"web_url":"https://patchwork.libcamera.org/comment/20542/","msgid":"<163524500670.1184428.16264349293217970913@Monstersaurus>","date":"2021-10-26T10:43:26","subject":"Re: [libcamera-devel] [PATCH v4 19/19] ipa: ipu3: ipa_context: Fix\n\tdoxygen references","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-10-26 11:26:47)\n> Hi Jean-Michel,\n> \n> Thank you for the patch.\n> \n> On Tue, Oct 26, 2021 at 11:55:34AM +0200, Jean-Michel Hautbois wrote:\n> > From: Kieran Bingham \n> > \n> > The IPAFrameContext uses unamed structures to group items. Doxygen can\n> > not reference the member variables of the container structures through\n> > the variable names, and expects the structure type name. As this is not\n> > given, the structure variables are referenced from the parent structure.\n> \n> I'd explain here that there's a doxygen issue.\n> \n> The IPAFrameContext uses unamed structures to group items. Doxygen\n> doesn't seem to support this properly, documentation isn't properly\n> generated and warnings are output during compilation. Suppress the\n> warning with a workaround that still results in incorrect generated\n> documentation until Doxygen gets fixed.\n> \n> \n> You may also want to s/references/warnings/ in the subject line.\n> \n> Reviewed-by: Laurent Pinchart \n> \n> > Signed-off-by: Kieran Bingham \n> > [JMH: Fix doxygen variable usage]\n\nI like the new implementation/solution.\n\nWith Laurent's paragraph included too:\n\nReviewed-by: Kieran Bingham \n\n> > Signed-off-by: Jean-Michel Hautbois \n> > ---\n> > src/ipa/ipu3/ipa_context.cpp | 30 +++++++++++++++---------------\n> > 1 file changed, 15 insertions(+), 15 deletions(-)\n> > \n> > diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n> > index 8917ba54..68e2f4aa 100644\n> > --- a/src/ipa/ipu3/ipa_context.cpp\n> > +++ b/src/ipa/ipu3/ipa_context.cpp\n> > @@ -59,13 +59,13 @@ namespace libcamera::ipa::ipu3 {\n> > * \\var IPASessionConfiguration::grid\n> > * \\brief Grid configuration of the IPA\n> > *\n> > - * \\var IPASessionConfiguration::grid::bdsGrid\n> > + * \\var IPASessionConfiguration::grid.bdsGrid\n> > * \\brief Bayer Down Scaler grid plane config used by the kernel\n> > *\n> > - * \\var IPASessionConfiguration::grid::bdsOutputSize\n> > + * \\var IPASessionConfiguration::grid.bdsOutputSize\n> > * \\brief BDS output size configured by the pipeline handler\n> > *\n> > - * \\var IPASessionConfiguration::grid::stride\n> > + * \\var IPASessionConfiguration::grid.stride\n> > * \\brief Number of cells on one line including the ImgU padding\n> > */\n> > \n> > @@ -73,16 +73,16 @@ namespace libcamera::ipa::ipu3 {\n> > * \\var IPASessionConfiguration::agc\n> > * \\brief AGC parameters configuration of the IPA\n> > *\n> > - * \\var IPASessionConfiguration::agc::minShutterSpeed\n> > + * \\var IPASessionConfiguration::agc.minShutterSpeed\n> > * \\brief Minimum shutter speed supported with the configured sensor\n> > *\n> > - * \\var IPASessionConfiguration::grid::maxShutterSpeed\n> > + * \\var IPASessionConfiguration::grid.maxShutterSpeed\n> > * \\brief Maximum shutter speed supported with the configured sensor\n> > *\n> > - * \\var IPASessionConfiguration::grid::minAnalogueGain\n> > + * \\var IPASessionConfiguration::grid.minAnalogueGain\n> > * \\brief Minimum analogue gain supported with the configured sensor\n> > *\n> > - * \\var IPASessionConfiguration::grid::maxAnalogueGain\n> > + * \\var IPASessionConfiguration::grid.maxAnalogueGain\n> > * \\brief Maximum analogue gain supported with the configured sensor\n> > */\n> > \n> > @@ -93,10 +93,10 @@ namespace libcamera::ipa::ipu3 {\n> > * The exposure and gain determined are expected to be applied to the sensor\n> > * at the earliest opportunity.\n> > *\n> > - * \\var IPAFrameContext::agc::exposure\n> > + * \\var IPAFrameContext::agc.exposure\n> > * \\brief Exposure time expressed as a number of lines\n> > *\n> > - * \\var IPAFrameContext::agc::gain\n> > + * \\var IPAFrameContext::agc.gain\n> > * \\brief Analogue gain multiplier\n> > *\n> > * The gain should be adapted to the sensor specific gain code before applying.\n> > @@ -106,16 +106,16 @@ namespace libcamera::ipa::ipu3 {\n> > * \\var IPAFrameContext::awb\n> > * \\brief Context for the Automatic White Balance algorithm\n> > *\n> > - * \\struct IPAFrameContext::awb::gains\n> > + * \\struct IPAFrameContext::awb.gains\n> > * \\brief White balance gains\n> > *\n> > - * \\var IPAFrameContext::awb::gains::red\n> > + * \\var IPAFrameContext::awb.gains.red\n> > * \\brief White balance gain for R channel\n> > *\n> > - * \\var IPAFrameContext::awb::gains::green\n> > + * \\var IPAFrameContext::awb.gains.green\n> > * \\brief White balance gain for G channel\n> > *\n> > - * \\var IPAFrameContext::awb::gains::blue\n> > + * \\var IPAFrameContext::awb.gains.blue\n> > * \\brief White balance gain for B channel\n> > */\n> > \n> > @@ -123,10 +123,10 @@ namespace libcamera::ipa::ipu3 {\n> > * \\var IPAFrameContext::toneMapping\n> > * \\brief Context for ToneMapping and Gamma control\n> > *\n> > - * \\var IPAFrameContext::toneMapping::gamma\n> > + * \\var IPAFrameContext::toneMapping.gamma\n> > * \\brief Gamma value for the LUT\n> > *\n> > - * \\var IPAFrameContext::toneMapping::gammaCorrection\n> > + * \\var IPAFrameContext::toneMapping.gammaCorrection\n> > * \\brief Per-pixel tone mapping implemented as a LUT\n> > *\n> > * The LUT structure is defined by the IPU3 kernel interface. See\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5BEBBDB1C\n\tfor ;\n\tTue, 26 Oct 2021 10:43:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FB3F60237;\n\tTue, 26 Oct 2021 12:43:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C91FD60123\n\tfor ;\n\tTue, 26 Oct 2021 12:43:28 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 613D53F0;\n\tTue, 26 Oct 2021 12:43:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZhQmgGQD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635245008;\n\tbh=xKsryXKfkH6nx9ePdYJXJRRdmVxfGiQVhxvizDJ1Ulc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ZhQmgGQDjFClFDBvpOBd1VMx2bixGMaMCURyfwLPANA72xm4/Lv0FrgTmvZFaDu4a\n\t/adnnIku9TEhrTMdU13emSSYpAwQ9a9K8QRQWK3UaJ37kVHY7F60OqqzMKGoXauKWC\n\txVKvD+1BdGwbSs2iosMoJDe3IgIaa5sAGdHGjOUI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20211026095534.90348-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211026095534.90348-20-jeanmichel.hautbois@ideasonboard.com>\n\t","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tLaurent Pinchart ","Date":"Tue, 26 Oct 2021 11:43:26 +0100","Message-ID":"<163524500670.1184428.16264349293217970913@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v4 19/19] ipa: ipu3: ipa_context: Fix\n\tdoxygen references","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]