[{"id":20530,"web_url":"https://patchwork.libcamera.org/comment/20530/","msgid":"","date":"2021-10-26T10:10:35","subject":"Re: [libcamera-devel] [PATCH v4 17/19] ipa: ipu3: Implement an\n\tempty stop() function","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Tue, Oct 26, 2021 at 11:55:32AM +0200, Jean-Michel Hautbois wrote:\n> While the stop() function does not currently perform any action, it forms\n> part of the IPA interface and is a public function in the class.\n> \n> Promote it to a full (but basic) function implementation and begin the\n> documentation accordingly so that there is an appropriate stub to\n> perform stop operations if they come up.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 9 ++++++++-\n> 1 file changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index a10fdd4a..5c51607d 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -135,7 +135,7 @@ public:\n> \t\t ControlInfoMap *ipaControls) override;\n> \n> \tint start() override;\n> -\tvoid stop() override {}\n> +\tvoid stop() override;\n> \n> \tint configure(const IPAConfigInfo &configInfo,\n> \t\t ControlInfoMap *ipaControls) override;\n> @@ -323,6 +323,13 @@ int IPAIPU3::start()\n> \treturn 0;\n> }\n> \n> +/**\n> + * \\brief Ensure that all processing has completed\n> + */\n> +void IPAIPU3::stop()\n> +{\n> +}\n> +\n> /**\n> * \\brief Calculate a grid for the AWB statistics\n> *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B214BDB1C\n\tfor ;\n\tTue, 26 Oct 2021 10:11:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6481C60237;\n\tTue, 26 Oct 2021 12:11:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B256660123\n\tfor ;\n\tTue, 26 Oct 2021 12:10:58 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 241083F0;\n\tTue, 26 Oct 2021 12:10:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DRxnNnKl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635243058;\n\tbh=ePGtfPak4w8iv0+rU0In69E297CXmZjzEPEJpizBRUY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DRxnNnKlh5JkEioTQbKrTpi0vSbG8dnm0Eom3Q9fGz1ubg41vpwYy7Tr71Ud5BBOt\n\tB/PkgNGJ5EOVBwOqwL3GzG3RX4FlGlQSF640ijpMqlOAAefmKszL6/9w2uAmrJtzMd\n\tjYn4pvbkUPv9SaMJXwDf/ZRWwgjiGMoO9RAwimbU=","Date":"Tue, 26 Oct 2021 13:10:35 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20211026095534.90348-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211026095534.90348-18-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211026095534.90348-18-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 17/19] ipa: ipu3: Implement an\n\tempty stop() function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20532,"web_url":"https://patchwork.libcamera.org/comment/20532/","msgid":"<769a3e35-aeb4-96ec-ba81-f5da895311e6@ideasonboard.com>","date":"2021-10-26T10:13:53","subject":"Re: [libcamera-devel] [PATCH v4 17/19] ipa: ipu3: Implement an\n\tempty stop() function","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi JM,\n\nOn 10/26/21 3:25 PM, Jean-Michel Hautbois wrote:\n> While the stop() function does not currently perform any action, it forms\n> part of the IPA interface and is a public function in the class.\n>\n> Promote it to a full (but basic) function implementation and begin the\n> documentation accordingly so that there is an appropriate stub to\n> perform stop operations if they come up.\n>\n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Kieran Bingham \n> ---\n> src/ipa/ipu3/ipu3.cpp | 9 ++++++++-\n> 1 file changed, 8 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index a10fdd4a..5c51607d 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -135,7 +135,7 @@ public:\n> \t\t ControlInfoMap *ipaControls) override;\n> \n> \tint start() override;\n> -\tvoid stop() override {}\n> +\tvoid stop() override;\n> \n> \tint configure(const IPAConfigInfo &configInfo,\n> \t\t ControlInfoMap *ipaControls) override;\n> @@ -323,6 +323,13 @@ int IPAIPU3::start()\n> \treturn 0;\n> }\n> \n> +/**\n> + * \\brief Ensure that all processing has completed\n\n\nThis sounds less like a \\brief but more like a \\todo. Since, it's a stub \nfunction, I am not sure how well we can document it as of now.\n\nDo we have some \"stopping\" criteria which needs to be satisfied to \nensure we have stopped the IPA?\n\n> + */\n> +void IPAIPU3::stop()\n> +{\n> +}\n> +\n> /**\n> * \\brief Calculate a grid for the AWB statistics\n> *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6EAC5BDB1C\n\tfor ;\n\tTue, 26 Oct 2021 10:14:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 272A660237;\n\tTue, 26 Oct 2021 12:14:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F01C660123\n\tfor ;\n\tTue, 26 Oct 2021 12:13:58 +0200 (CEST)","from [192.168.1.106] (unknown [103.251.226.211])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E4DF3F0;\n\tTue, 26 Oct 2021 12:13:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aiCgjsdF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635243238;\n\tbh=SQwZ6iT7fhg4HvMKLRR57TUp4qZpJBo/fB0L5FD2X/A=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=aiCgjsdF9jrmP1LFnpEV4JsG6lFtpAtrNDNl3YJdKU2nZQzK94vM/N27GZKE+PvY5\n\tpjaN6MsGjbzFEApjJiRzjKsyyxP259sS6gvRp4Sjp3TDZL94JcnO0klBwi9TYy/Xqq\n\thU7Iu0LDxEiBQJnCZ2Qg34HHRyJJUcP5iaQ8i/oA=","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211026095534.90348-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211026095534.90348-18-jeanmichel.hautbois@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<769a3e35-aeb4-96ec-ba81-f5da895311e6@ideasonboard.com>","Date":"Tue, 26 Oct 2021 15:43:53 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211026095534.90348-18-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v4 17/19] ipa: ipu3: Implement an\n\tempty stop() function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20537,"web_url":"https://patchwork.libcamera.org/comment/20537/","msgid":"","date":"2021-10-26T10:30:05","subject":"Re: [libcamera-devel] [PATCH v4 17/19] ipa: ipu3: Implement an\n\tempty stop() function","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Umang,\n\nOn 26/10/2021 12:13, Umang Jain wrote:\n> Hi JM,\n> \n> On 10/26/21 3:25 PM, Jean-Michel Hautbois wrote:\n>> While the stop() function does not currently perform any action, it forms\n>> part of the IPA interface and is a public function in the class.\n>>\n>> Promote it to a full (but basic) function implementation and begin the\n>> documentation accordingly so that there is an appropriate stub to\n>> perform stop operations if they come up.\n>>\n>> Signed-off-by: Jean-Michel Hautbois \n>> \n>> Reviewed-by: Kieran Bingham \n>> ---\n>>   src/ipa/ipu3/ipu3.cpp | 9 ++++++++-\n>>   1 file changed, 8 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n>> index a10fdd4a..5c51607d 100644\n>> --- a/src/ipa/ipu3/ipu3.cpp\n>> +++ b/src/ipa/ipu3/ipu3.cpp\n>> @@ -135,7 +135,7 @@ public:\n>>            ControlInfoMap *ipaControls) override;\n>>       int start() override;\n>> -    void stop() override {}\n>> +    void stop() override;\n>>       int configure(const IPAConfigInfo &configInfo,\n>>                 ControlInfoMap *ipaControls) override;\n>> @@ -323,6 +323,13 @@ int IPAIPU3::start()\n>>       return 0;\n>>   }\n>> +/**\n>> + * \\brief Ensure that all processing has completed\n> \n> \n> This sounds less like a \\brief but more like a \\todo. Since, it's a stub \n> function, I am not sure how well we can document it as of now.\n\nIndeed, but this is a reference documentation, so we are telling the \npurpose of the function, even if not implemented yet or empty.\n\n> \n> Do we have some \"stopping\" criteria which needs to be satisfied to \n> ensure we have stopped the IPA?\n\nRight now, no, but in the future, maybe (not really thought about it yet)\n\n> \n>> + */\n>> +void IPAIPU3::stop()\n>> +{\n>> +}\n>> +\n>>   /**\n>>    * \\brief Calculate a grid for the AWB statistics\n>>    *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75671BDB1C\n\tfor ;\n\tTue, 26 Oct 2021 10:30:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0B5E60237;\n\tTue, 26 Oct 2021 12:30:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0122C60123\n\tfor ;\n\tTue, 26 Oct 2021 12:30:07 +0200 (CEST)","from [IPV6:2a01:e0a:169:7140:dce3:eb54:18d7:6f3d] (unknown\n\t[IPv6:2a01:e0a:169:7140:dce3:eb54:18d7:6f3d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B5653F0;\n\tTue, 26 Oct 2021 12:30:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qUoHoQAG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635244207;\n\tbh=O0X/0zcrVDvvIbtvQGqRcF1bqoLJfBkcXoAHT3Lr3PY=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=qUoHoQAGDQX9Mv5U50ekr75ZFEq9XmZnitAINCA2xqKUtr1Td+nZZP6TzAw9YcONb\n\t8TJK2Iu8Fuj0LlpfJP6WMMDxCBsm7cmu9IggRsaO/DLPpPzI3gKscOX3ZNabje7Bxe\n\tjBqNZlPx0EoAbCvWFMaEqX6toyTyvfxm58kq29c4=","Message-ID":"","Date":"Tue, 26 Oct 2021 12:30:05 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.1.2","Content-Language":"en-US","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211026095534.90348-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211026095534.90348-18-jeanmichel.hautbois@ideasonboard.com>\n\t<769a3e35-aeb4-96ec-ba81-f5da895311e6@ideasonboard.com>","From":"Jean-Michel Hautbois ","In-Reply-To":"<769a3e35-aeb4-96ec-ba81-f5da895311e6@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v4 17/19] ipa: ipu3: Implement an\n\tempty stop() function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20538,"web_url":"https://patchwork.libcamera.org/comment/20538/","msgid":"<686d4fec-e498-e99c-858c-793e73bc3803@ideasonboard.com>","date":"2021-10-26T10:31:33","subject":"Re: [libcamera-devel] [PATCH v4 17/19] ipa: ipu3: Implement an\n\tempty stop() function","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi JM.\n\nOn 10/26/21 4:00 PM, Jean-Michel Hautbois wrote:\n> Hi Umang,\n>\n> On 26/10/2021 12:13, Umang Jain wrote:\n>> Hi JM,\n>>\n>> On 10/26/21 3:25 PM, Jean-Michel Hautbois wrote:\n>>> While the stop() function does not currently perform any action, it \n>>> forms\n>>> part of the IPA interface and is a public function in the class.\n>>>\n>>> Promote it to a full (but basic) function implementation and begin the\n>>> documentation accordingly so that there is an appropriate stub to\n>>> perform stop operations if they come up.\n>>>\n>>> Signed-off-by: Jean-Michel Hautbois \n>>> \n>>> Reviewed-by: Kieran Bingham \n>>> ---\n>>>   src/ipa/ipu3/ipu3.cpp | 9 ++++++++-\n>>>   1 file changed, 8 insertions(+), 1 deletion(-)\n>>>\n>>> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n>>> index a10fdd4a..5c51607d 100644\n>>> --- a/src/ipa/ipu3/ipu3.cpp\n>>> +++ b/src/ipa/ipu3/ipu3.cpp\n>>> @@ -135,7 +135,7 @@ public:\n>>>            ControlInfoMap *ipaControls) override;\n>>>       int start() override;\n>>> -    void stop() override {}\n>>> +    void stop() override;\n>>>       int configure(const IPAConfigInfo &configInfo,\n>>>                 ControlInfoMap *ipaControls) override;\n>>> @@ -323,6 +323,13 @@ int IPAIPU3::start()\n>>>       return 0;\n>>>   }\n>>> +/**\n>>> + * \\brief Ensure that all processing has completed\n>>\n>>\n>> This sounds less like a \\brief but more like a \\todo. Since, it's a \n>> stub function, I am not sure how well we can document it as of now.\n>\n> Indeed, but this is a reference documentation, so we are telling the \n> purpose of the function, even if not implemented yet or empty.\n\n\nOk, sounds okay to me then\n\nReviewed-by: Umang Jain \n\n>\n>>\n>> Do we have some \"stopping\" criteria which needs to be satisfied to \n>> ensure we have stopped the IPA?\n>\n> Right now, no, but in the future, maybe (not really thought about it yet)\n>\n>>\n>>> + */\n>>> +void IPAIPU3::stop()\n>>> +{\n>>> +}\n>>> +\n>>>   /**\n>>>    * \\brief Calculate a grid for the AWB statistics\n>>>    *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3DF7BDB1C\n\tfor ;\n\tTue, 26 Oct 2021 10:31:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ADB0164879;\n\tTue, 26 Oct 2021 12:31:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 395DB60123\n\tfor ;\n\tTue, 26 Oct 2021 12:31:37 +0200 (CEST)","from [192.168.1.106] (unknown [103.251.226.211])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B2283F0;\n\tTue, 26 Oct 2021 12:31:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o8cfCOsW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635244297;\n\tbh=b9EgUmI0hwn1tVwxBuVfERHyd3UoKbbWAh+kmNk2Sis=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=o8cfCOsWEPWEUThWpM17+jUN+NPaDsxw27y4VJi8COAkMu5vuW3mBBK/zEBK50765\n\tXvX8ZSsEunu3vFPjxrxoYYGT3pFAXuKQF+JvzHHBF1YsDYjeFi8kGia86UhV+kucb0\n\tjYBvjp+RAxU5AgEiq7kukkkbXjW86NW7wa7/ZfyE=","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211026095534.90348-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211026095534.90348-18-jeanmichel.hautbois@ideasonboard.com>\n\t<769a3e35-aeb4-96ec-ba81-f5da895311e6@ideasonboard.com>\n\t","From":"Umang Jain ","Message-ID":"<686d4fec-e498-e99c-858c-793e73bc3803@ideasonboard.com>","Date":"Tue, 26 Oct 2021 16:01:33 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"8bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v4 17/19] ipa: ipu3: Implement an\n\tempty stop() function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20541,"web_url":"https://patchwork.libcamera.org/comment/20541/","msgid":"<163524489449.1184428.17089435850278564444@Monstersaurus>","date":"2021-10-26T10:41:34","subject":"Re: [libcamera-devel] [PATCH v4 17/19] ipa: ipu3: Implement an\n\tempty stop() function","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2021-10-26 11:31:33)\n> Hi JM.\n> \n> On 10/26/21 4:00 PM, Jean-Michel Hautbois wrote:\n> > Hi Umang,\n> >\n> > On 26/10/2021 12:13, Umang Jain wrote:\n> >> Hi JM,\n> >>\n> >> On 10/26/21 3:25 PM, Jean-Michel Hautbois wrote:\n> >>> While the stop() function does not currently perform any action, it \n> >>> forms\n> >>> part of the IPA interface and is a public function in the class.\n> >>>\n> >>> Promote it to a full (but basic) function implementation and begin the\n> >>> documentation accordingly so that there is an appropriate stub to\n> >>> perform stop operations if they come up.\n> >>>\n> >>> Signed-off-by: Jean-Michel Hautbois \n> >>> \n> >>> Reviewed-by: Kieran Bingham \n> >>> ---\n> >>>   src/ipa/ipu3/ipu3.cpp | 9 ++++++++-\n> >>>   1 file changed, 8 insertions(+), 1 deletion(-)\n> >>>\n> >>> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> >>> index a10fdd4a..5c51607d 100644\n> >>> --- a/src/ipa/ipu3/ipu3.cpp\n> >>> +++ b/src/ipa/ipu3/ipu3.cpp\n> >>> @@ -135,7 +135,7 @@ public:\n> >>>            ControlInfoMap *ipaControls) override;\n> >>>       int start() override;\n> >>> -    void stop() override {}\n> >>> +    void stop() override;\n> >>>       int configure(const IPAConfigInfo &configInfo,\n> >>>                 ControlInfoMap *ipaControls) override;\n> >>> @@ -323,6 +323,13 @@ int IPAIPU3::start()\n> >>>       return 0;\n> >>>   }\n> >>> +/**\n> >>> + * \\brief Ensure that all processing has completed\n> >>\n> >>\n> >> This sounds less like a \\brief but more like a \\todo. Since, it's a \n> >> stub function, I am not sure how well we can document it as of now.\n> >\n> > Indeed, but this is a reference documentation, so we are telling the \n> > purpose of the function, even if not implemented yet or empty.\n> \n> \n> Ok, sounds okay to me then\n> \n> Reviewed-by: Umang Jain \n> \n> >\n> >>\n> >> Do we have some \"stopping\" criteria which needs to be satisfied to \n> >> ensure we have stopped the IPA?\n> >\n> > Right now, no, but in the future, maybe (not really thought about it yet)\n\nThis IPA doesn't currently have any requirements to stop anything as\nnothing is run asynchronously. However - the libcamera IPA interface\n/requires/ that after stop() is called, the IPA is not allowed to do\nanything. (Think back to those IPU3 bugs I had to fix)\n\nSo I'm quite happy that this is here as a clear statement to say \"This\nis where you must stop anything that has started\".\n\n\n\n> >\n> >>\n> >>> + */\n> >>> +void IPAIPU3::stop()\n> >>> +{\n> >>> +}\n> >>> +\n> >>>   /**\n> >>>    * \\brief Calculate a grid for the AWB statistics\n> >>>    *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF877BDB1C\n\tfor ;\n\tTue, 26 Oct 2021 10:41:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5AE2660237;\n\tTue, 26 Oct 2021 12:41:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B484E60123\n\tfor ;\n\tTue, 26 Oct 2021 12:41:36 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F4073F0;\n\tTue, 26 Oct 2021 12:41:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UL5+247s\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635244896;\n\tbh=qUQi+3rj2pIRM5h9jDLaar6JF3bEdqzhcXK8B4qrXms=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=UL5+247sHF7fThWmJFpfStIECys7IT0EvdAgJSi34QsTYMkxniWu6F0F3M73kyvul\n\tA1aly/q9JA9tpBlSSegqxnzzksoglZgRXjLM12gbl8zEBMh2yLPa013GUQXZUlC0H1\n\tyvG5FZOd0ZpUlits6+o4nYQh68qRHUie1OE40sQE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<686d4fec-e498-e99c-858c-793e73bc3803@ideasonboard.com>","References":"<20211026095534.90348-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211026095534.90348-18-jeanmichel.hautbois@ideasonboard.com>\n\t<769a3e35-aeb4-96ec-ba81-f5da895311e6@ideasonboard.com>\n\t\n\t<686d4fec-e498-e99c-858c-793e73bc3803@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tUmang Jain ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 26 Oct 2021 11:41:34 +0100","Message-ID":"<163524489449.1184428.17089435850278564444@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v4 17/19] ipa: ipu3: Implement an\n\tempty stop() function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]