[{"id":20540,"web_url":"https://patchwork.libcamera.org/comment/20540/","msgid":"<163524462373.1184428.6841452003530952712@Monstersaurus>","date":"2021-10-26T10:37:03","subject":"Re: [libcamera-devel] [PATCH v4 06/19] ipa: ipu3: awb: Reword\n\taccumulator documentation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-10-26 10:55:21)\n> Now that we moved the diagram into the AWB class documentation, reword the\n> accumulator documentation to make it clear it is not meant to be used\n> only in AWB.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/ipu3/algorithms/awb.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n> index 8d22aceb..41fd5fc4 100644\n> --- a/src/ipa/ipu3/algorithms/awb.cpp\n> +++ b/src/ipa/ipu3/algorithms/awb.cpp\n> @@ -46,12 +46,12 @@ static constexpr uint32_t kMinCellsPerZoneRatio = 255 * 90 / 100;\n> * \\struct Accumulator\n> * \\brief RGB statistics for a given zone\n> *\n> - * The Accumulator structure stores the sum of the average of each cell in a\n> - * zone of the image, as well as the number of cells which were unsaturated and\n> - * therefore included in the average.\n> + * Accumulate red, green and blue values for each non-saturated item over a\n> + * zone. Items can for instance be pixels, but also the average of groups of\n> + * pixels, depending on who uses the accumulator.\n> * \\todo move this description and structure into a common header\n> *\n> - * Cells which are saturated beyond the threshold defined in\n> + * Zones which are saturated beyond the threshold defined in\n> * ipu3_uapi_awb_config_s are not included in the average.\n> *\n> * \\var Accumulator::counted\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B27EBF415\n\tfor ;\n\tTue, 26 Oct 2021 10:37:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9613160124;\n\tTue, 26 Oct 2021 12:37:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5418B60123\n\tfor ;\n\tTue, 26 Oct 2021 12:37:06 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D437B3F0;\n\tTue, 26 Oct 2021 12:37:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FvIKUHT8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635244625;\n\tbh=UBGJNob9m6GtNkFUyqdtMqGFOPAj9H62UUy6WGfxGx0=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=FvIKUHT8n95abZY+uaptjOCP8I7QeY7qD0GTKSzJpn8b7FheE0JtRPnHVxc1cLhSv\n\tjXtB14ub7CKNkMhur5VpER0L13jdXV5oecHgzJzJRsmBHXQfsZXUj1Mde1uiur4B1q\n\ts1a4rbHLwcDjYDU2ejvt1s4Qosdy8iV4c1pGpzvY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211026095534.90348-7-jeanmichel.hautbois@ideasonboard.com>","References":"<20211026095534.90348-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211026095534.90348-7-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 26 Oct 2021 11:37:03 +0100","Message-ID":"<163524462373.1184428.6841452003530952712@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v4 06/19] ipa: ipu3: awb: Reword\n\taccumulator documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]