[{"id":20481,"web_url":"https://patchwork.libcamera.org/comment/20481/","msgid":"<YXclVsmOuezpDYvc@pendragon.ideasonboard.com>","date":"2021-10-25T21:44:54","subject":"Re: [libcamera-devel] [PATCH v3 19/19] Documentation: Include IPU3\n\tin Doxygen build","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel and Kieran,\n\nThank you for the patch.\n\nOn Fri, Oct 22, 2021 at 05:12:18PM +0200, Jean-Michel Hautbois wrote:\n> From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nNow we have a From: line :-)\n\n> The IPU3 is documented using Doxygen within the code.\n> \n> Include the IPU3 IPA as part of the doxygen build sources. This will\n> ideally be split to it's own 'section' of the doxygen output.\n\ns/it's/its/\n\n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> ---\n>  Documentation/Doxyfile.in | 1 +\n>  Documentation/meson.build | 1 +\n>  2 files changed, 2 insertions(+)\n> \n> diff --git a/Documentation/Doxyfile.in b/Documentation/Doxyfile.in\n> index 6e627192..37b231bc 100644\n> --- a/Documentation/Doxyfile.in\n> +++ b/Documentation/Doxyfile.in\n> @@ -790,6 +790,7 @@ WARN_LOGFILE           =\n>  \n>  INPUT                  = \"@TOP_SRCDIR@/include/libcamera\" \\\n>  \t\t\t \"@TOP_SRCDIR@/src/ipa/libipa\" \\\n> +\t\t\t \"@TOP_SRCDIR@/src/ipa/ipu3\" \\\n\nAlphabetical order.\n\n>  \t\t\t \"@TOP_SRCDIR@/src/libcamera\" \\\n>  \t\t\t \"@TOP_BUILDDIR@/include/libcamera\" \\\n>  \t\t\t \"@TOP_BUILDDIR@/src/libcamera\"\n> diff --git a/Documentation/meson.build b/Documentation/meson.build\n> index c4bd3c7f..c174c945 100644\n> --- a/Documentation/meson.build\n> +++ b/Documentation/meson.build\n> @@ -31,6 +31,7 @@ if doxygen.found() and dot.found()\n>                        libcamera_sources,\n>                        libipa_headers,\n>                        libipa_sources,\n> +                      ipu3_ipa_sources,\n\nSame.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n>                    ],\n>                    output : 'api-html',\n>                    command : [doxygen, doxyfile],","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F317FBDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Oct 2021 21:45:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AEA3564878;\n\tMon, 25 Oct 2021 23:45:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A56160125\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Oct 2021 23:45:17 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CB406E0A;\n\tMon, 25 Oct 2021 23:45:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cuE+6fYB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635198317;\n\tbh=ata0bK8ah8o51+o3aRiPJI9oQSSYrZ436YKa7hDllag=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cuE+6fYBHiOYDdD/wh0wRM4lW3oqDxPmm1SGk/7Ph20NJTPOP3szPXNegw6Yl1baR\n\tZ315IVtbTxeMgjI1Ra3GG4FnXqBBfZpxYGfX2Yd49gHDXqX5zhCX9jKkBnSwbM5WdN\n\tU5hShonvW6KWApKVP/QbNOzDpFFMds3dltgQG4l8=","Date":"Tue, 26 Oct 2021 00:44:54 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>","Message-ID":"<YXclVsmOuezpDYvc@pendragon.ideasonboard.com>","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-20-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211022151218.111966-20-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 19/19] Documentation: Include IPU3\n\tin Doxygen build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":20484,"web_url":"https://patchwork.libcamera.org/comment/20484/","msgid":"<163519901459.1095920.16273435420092532871@Monstersaurus>","date":"2021-10-25T21:56:54","subject":"Re: [libcamera-devel] [PATCH v3 19/19] Documentation: Include IPU3\n\tin Doxygen build","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-10-25 22:44:54)\n> Hi Jean-Michel and Kieran,\n> \n> Thank you for the patch.\n> \n> On Fri, Oct 22, 2021 at 05:12:18PM +0200, Jean-Michel Hautbois wrote:\n> > From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> Now we have a From: line :-)\n> \n> > The IPU3 is documented using Doxygen within the code.\n> > \n> > Include the IPU3 IPA as part of the doxygen build sources. This will\n> > ideally be split to it's own 'section' of the doxygen output.\n> \n> s/it's/its/\n\nI bet you'd know /it's/ from me with that in there anyway ;-)\nIt's always me when it's it's isn't it's.\n\n> \n> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nThis should still have an SoB from anyone it goes through though, so as\nit's gone through you JM, it needs your SoB. (Same for any others).\n\n\n> > ---\n> >  Documentation/Doxyfile.in | 1 +\n> >  Documentation/meson.build | 1 +\n> >  2 files changed, 2 insertions(+)\n> > \n> > diff --git a/Documentation/Doxyfile.in b/Documentation/Doxyfile.in\n> > index 6e627192..37b231bc 100644\n> > --- a/Documentation/Doxyfile.in\n> > +++ b/Documentation/Doxyfile.in\n> > @@ -790,6 +790,7 @@ WARN_LOGFILE           =\n> >  \n> >  INPUT                  = \"@TOP_SRCDIR@/include/libcamera\" \\\n> >                        \"@TOP_SRCDIR@/src/ipa/libipa\" \\\n> > +                      \"@TOP_SRCDIR@/src/ipa/ipu3\" \\\n> \n> Alphabetical order.\n> \n> >                        \"@TOP_SRCDIR@/src/libcamera\" \\\n> >                        \"@TOP_BUILDDIR@/include/libcamera\" \\\n> >                        \"@TOP_BUILDDIR@/src/libcamera\"\n> > diff --git a/Documentation/meson.build b/Documentation/meson.build\n> > index c4bd3c7f..c174c945 100644\n> > --- a/Documentation/meson.build\n> > +++ b/Documentation/meson.build\n> > @@ -31,6 +31,7 @@ if doxygen.found() and dot.found()\n> >                        libcamera_sources,\n> >                        libipa_headers,\n> >                        libipa_sources,\n> > +                      ipu3_ipa_sources,\n> \n> Same.\n> \n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> >                    ],\n> >                    output : 'api-html',\n> >                    command : [doxygen, doxyfile],\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 74772BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Oct 2021 21:56:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BD45664878;\n\tMon, 25 Oct 2021 23:56:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50C5460125\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Oct 2021 23:56:57 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DC99CE0A;\n\tMon, 25 Oct 2021 23:56:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"E+z49rh/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635199016;\n\tbh=OdD6DgZvg9awLiOLw+DoLzVVf35WaeJq3mv/Eq65PXs=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=E+z49rh/rfTmehSSibmLZ7VzdHjdxJ73N2x99A1zvvyd2aphxvoI4vWCzu3FrK8xn\n\tHsw4AY1H54bRXTPygboAvrYHIfytwppVK5zV6Xvnb9/RqdNqOBp7yg3bSSUkzZ/ibX\n\tsb7UxzlCTeJTkolkLzf0VhLhc9Eg7HIJmfN0Ol3M=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<YXclVsmOuezpDYvc@pendragon.ideasonboard.com>","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-20-jeanmichel.hautbois@ideasonboard.com>\n\t<YXclVsmOuezpDYvc@pendragon.ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>","Date":"Mon, 25 Oct 2021 22:56:54 +0100","Message-ID":"<163519901459.1095920.16273435420092532871@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v3 19/19] Documentation: Include IPU3\n\tin Doxygen build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":20486,"web_url":"https://patchwork.libcamera.org/comment/20486/","msgid":"<YXcoxAytb8ENdN3F@pendragon.ideasonboard.com>","date":"2021-10-25T21:59:32","subject":"Re: [libcamera-devel] [PATCH v3 19/19] Documentation: Include IPU3\n\tin Doxygen build","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Oct 25, 2021 at 10:56:54PM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart (2021-10-25 22:44:54)\n> > Hi Jean-Michel and Kieran,\n> > \n> > Thank you for the patch.\n> > \n> > On Fri, Oct 22, 2021 at 05:12:18PM +0200, Jean-Michel Hautbois wrote:\n> > > From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > \n> > Now we have a From: line :-)\n> > \n> > > The IPU3 is documented using Doxygen within the code.\n> > > \n> > > Include the IPU3 IPA as part of the doxygen build sources. This will\n> > > ideally be split to it's own 'section' of the doxygen output.\n> > \n> > s/it's/its/\n> \n> I bet you'd know /it's/ from me with that in there anyway ;-)\n> It's always me when it's it's isn't it's.\n> \n> > \n> > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> This should still have an SoB from anyone it goes through though, so as\n> it's gone through you JM, it needs your SoB. (Same for any others).\n\nNot for the mere act of reposting the patch unmodified. An SoB should be\nadded when the poster modifies the patch, or when a committer commits\nthe patch to a git tree.\n\n> > > ---\n> > >  Documentation/Doxyfile.in | 1 +\n> > >  Documentation/meson.build | 1 +\n> > >  2 files changed, 2 insertions(+)\n> > > \n> > > diff --git a/Documentation/Doxyfile.in b/Documentation/Doxyfile.in\n> > > index 6e627192..37b231bc 100644\n> > > --- a/Documentation/Doxyfile.in\n> > > +++ b/Documentation/Doxyfile.in\n> > > @@ -790,6 +790,7 @@ WARN_LOGFILE           =\n> > >  \n> > >  INPUT                  = \"@TOP_SRCDIR@/include/libcamera\" \\\n> > >                        \"@TOP_SRCDIR@/src/ipa/libipa\" \\\n> > > +                      \"@TOP_SRCDIR@/src/ipa/ipu3\" \\\n> > \n> > Alphabetical order.\n> > \n> > >                        \"@TOP_SRCDIR@/src/libcamera\" \\\n> > >                        \"@TOP_BUILDDIR@/include/libcamera\" \\\n> > >                        \"@TOP_BUILDDIR@/src/libcamera\"\n> > > diff --git a/Documentation/meson.build b/Documentation/meson.build\n> > > index c4bd3c7f..c174c945 100644\n> > > --- a/Documentation/meson.build\n> > > +++ b/Documentation/meson.build\n> > > @@ -31,6 +31,7 @@ if doxygen.found() and dot.found()\n> > >                        libcamera_sources,\n> > >                        libipa_headers,\n> > >                        libipa_sources,\n> > > +                      ipu3_ipa_sources,\n> > \n> > Same.\n> > \n> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > \n> > >                    ],\n> > >                    output : 'api-html',\n> > >                    command : [doxygen, doxyfile],","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EE393BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Oct 2021 21:59:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B333564878;\n\tMon, 25 Oct 2021 23:59:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 34C1B60125\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Oct 2021 23:59:55 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BDCF7E0A;\n\tMon, 25 Oct 2021 23:59:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FxHRx7K4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635199195;\n\tbh=4GqqdIfjY00V84hM4/gT+qZLlMf1X8sMU7BwP7rIYWo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FxHRx7K4TB8LxL9DhwxOJm5R3U4ClfTw4reeBRqWlKrq+/p8B22Bi7BkkyADrLWJL\n\tOZS61CuNBPrQUpNRtPVNZYaq9HLtolJ6MLUMSw8hMSN9xmfk3ntL9UqYbie+AZaJJl\n\tRhMN1fr4w9jTlcKmIm0wN5o+hyEHGgP9aEwz9Km4=","Date":"Tue, 26 Oct 2021 00:59:32 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<YXcoxAytb8ENdN3F@pendragon.ideasonboard.com>","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-20-jeanmichel.hautbois@ideasonboard.com>\n\t<YXclVsmOuezpDYvc@pendragon.ideasonboard.com>\n\t<163519901459.1095920.16273435420092532871@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<163519901459.1095920.16273435420092532871@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v3 19/19] Documentation: Include IPU3\n\tin Doxygen build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":20488,"web_url":"https://patchwork.libcamera.org/comment/20488/","msgid":"<163519943924.1095920.658124644802590831@Monstersaurus>","date":"2021-10-25T22:03:59","subject":"Re: [libcamera-devel] [PATCH v3 19/19] Documentation: Include IPU3\n\tin Doxygen build","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-10-25 22:59:32)\n> On Mon, Oct 25, 2021 at 10:56:54PM +0100, Kieran Bingham wrote:\n> > Quoting Laurent Pinchart (2021-10-25 22:44:54)\n> > > Hi Jean-Michel and Kieran,\n> > > \n> > > Thank you for the patch.\n> > > \n> > > On Fri, Oct 22, 2021 at 05:12:18PM +0200, Jean-Michel Hautbois wrote:\n> > > > From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > > \n> > > Now we have a From: line :-)\n> > > \n> > > > The IPU3 is documented using Doxygen within the code.\n> > > > \n> > > > Include the IPU3 IPA as part of the doxygen build sources. This will\n> > > > ideally be split to it's own 'section' of the doxygen output.\n> > > \n> > > s/it's/its/\n> > \n> > I bet you'd know /it's/ from me with that in there anyway ;-)\n> > It's always me when it's it's isn't it's.\n> > \n> > > \n> > > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > \n> > This should still have an SoB from anyone it goes through though, so as\n> > it's gone through you JM, it needs your SoB. (Same for any others).\n> \n> Not for the mere act of reposting the patch unmodified. An SoB should be\n> added when the poster modifies the patch, or when a committer commits\n> the patch to a git tree.\n\nOk, I thought it was required if it went 'through' a route like that.\n\nAnyway, if the modifications are made below, that will become true. But\nagreed on this version.\n\n\n> \n> > > > ---\n> > > >  Documentation/Doxyfile.in | 1 +\n> > > >  Documentation/meson.build | 1 +\n> > > >  2 files changed, 2 insertions(+)\n> > > > \n> > > > diff --git a/Documentation/Doxyfile.in b/Documentation/Doxyfile.in\n> > > > index 6e627192..37b231bc 100644\n> > > > --- a/Documentation/Doxyfile.in\n> > > > +++ b/Documentation/Doxyfile.in\n> > > > @@ -790,6 +790,7 @@ WARN_LOGFILE           =\n> > > >  \n> > > >  INPUT                  = \"@TOP_SRCDIR@/include/libcamera\" \\\n> > > >                        \"@TOP_SRCDIR@/src/ipa/libipa\" \\\n> > > > +                      \"@TOP_SRCDIR@/src/ipa/ipu3\" \\\n> > > \n> > > Alphabetical order.\n> > > \n> > > >                        \"@TOP_SRCDIR@/src/libcamera\" \\\n> > > >                        \"@TOP_BUILDDIR@/include/libcamera\" \\\n> > > >                        \"@TOP_BUILDDIR@/src/libcamera\"\n> > > > diff --git a/Documentation/meson.build b/Documentation/meson.build\n> > > > index c4bd3c7f..c174c945 100644\n> > > > --- a/Documentation/meson.build\n> > > > +++ b/Documentation/meson.build\n> > > > @@ -31,6 +31,7 @@ if doxygen.found() and dot.found()\n> > > >                        libcamera_sources,\n> > > >                        libipa_headers,\n> > > >                        libipa_sources,\n> > > > +                      ipu3_ipa_sources,\n> > > \n> > > Same.\n> > > \n> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > > \n> > > >                    ],\n> > > >                    output : 'api-html',\n> > > >                    command : [doxygen, doxyfile],\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B9CBBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Oct 2021 22:04:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C0E664878;\n\tTue, 26 Oct 2021 00:04:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B9466486D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Oct 2021 00:04:02 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3DC2E4A8;\n\tTue, 26 Oct 2021 00:04:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"P91WADfR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635199441;\n\tbh=54aVt5Hc5mE2jo2JGdOVrudMaCwBWjZ4AKBsdSTEFRQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=P91WADfRjqklUpuGmT6uAcRchpwz1g+TYiHhxBjh6aNx+/H8EVoxTz8ACuFYNcK8E\n\tBXezRHgSyXJt4sZPZRpngeWMw3/akPubsMZvf4gJ4LpaKxxOs2r7JlczgSOoNoufd/\n\tlrudG0+x7O+56Kxu0dI/33Nzo1zuJ0fOtwFLi6mo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<YXcoxAytb8ENdN3F@pendragon.ideasonboard.com>","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-20-jeanmichel.hautbois@ideasonboard.com>\n\t<YXclVsmOuezpDYvc@pendragon.ideasonboard.com>\n\t<163519901459.1095920.16273435420092532871@Monstersaurus>\n\t<YXcoxAytb8ENdN3F@pendragon.ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Date":"Mon, 25 Oct 2021 23:03:59 +0100","Message-ID":"<163519943924.1095920.658124644802590831@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v3 19/19] Documentation: Include IPU3\n\tin Doxygen build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]