[{"id":20479,"web_url":"https://patchwork.libcamera.org/comment/20479/","msgid":"","date":"2021-10-25T21:43:48","subject":"Re: [libcamera-devel] [PATCH v3 18/19] ipa: ipu3: Implement an\n\tempty stop() function","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Fri, Oct 22, 2021 at 05:12:17PM +0200, Jean-Michel Hautbois wrote:\n> While the stop() method does not currently perform any action, it forms\n\ns/method/function/\n\n> part of the IPA interface and is a public function in the class.\n> \n> Promote it to a full (but basic) function implementation and begin the\n> documentation accordingly so that there is an appropriate stub to\n> perform stop operations if they come up.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/ipu3.cpp | 9 ++++++++-\n> 1 file changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 065febf8..ea54413a 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -131,7 +131,7 @@ public:\n> \t\t ControlInfoMap *ipaControls) override;\n> \n> \tint start() override;\n> -\tvoid stop() override {}\n> +\tvoid stop() override;\n> \n> \tint configure(const IPAConfigInfo &configInfo,\n> \t\t ControlInfoMap *ipaControls) override;\n> @@ -319,6 +319,13 @@ int IPAIPU3::start()\n> \treturn 0;\n> }\n> \n> +/**\n> + * \\brief Ensure that all processing has completed.\n\ns/completed./completed/\n\n> + */\n> +void IPAIPU3::stop()\n> +{\n> +}\n> +\n> /**\n> * \\brief Calculate a grid for the AWB statistics\n> *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DC59BF415\n\tfor ;\n\tMon, 25 Oct 2021 21:44:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5AD06486E;\n\tMon, 25 Oct 2021 23:44:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6345D60125\n\tfor ;\n\tMon, 25 Oct 2021 23:44:10 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB09BE0A;\n\tMon, 25 Oct 2021 23:44:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PxxM46Au\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635198250;\n\tbh=ZLa7DcaHU6A8Gwfn4XEXRrvnXM5hKDE2NCyaziOJRd8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PxxM46AukqH+hDyw6ObTgX5r1TpxzZHb5pNG/ictnId9ptaNkDLs79rrZBeEpck+q\n\tJ07+96TrCy8DI3j2KsG+HizGmcj+6Ce3FjphnyV8ywxDw5Zq9meFWqny8WqdX4hs2T\n\tJnvaARoPM3V15Hph3/Q9gE9QanXKItdoBSDw82Qo=","Date":"Tue, 26 Oct 2021 00:43:48 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-19-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211022151218.111966-19-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 18/19] ipa: ipu3: Implement an\n\tempty stop() function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20480,"web_url":"https://patchwork.libcamera.org/comment/20480/","msgid":"<163519828207.1095920.17285993705427201880@Monstersaurus>","date":"2021-10-25T21:44:42","subject":"Re: [libcamera-devel] [PATCH v3 18/19] ipa: ipu3: Implement an\n\tempty stop() function","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-10-22 16:12:17)\n> While the stop() method does not currently perform any action, it forms\n> part of the IPA interface and is a public function in the class.\n> \n> Promote it to a full (but basic) function implementation and begin the\n> documentation accordingly so that there is an appropriate stub to\n> perform stop operations if they come up.\n> \n> Signed-off-by: Jean-Michel Hautbois \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 9 ++++++++-\n> 1 file changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 065febf8..ea54413a 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -131,7 +131,7 @@ public:\n> ControlInfoMap *ipaControls) override;\n> \n> int start() override;\n> - void stop() override {}\n> + void stop() override;\n> \n> int configure(const IPAConfigInfo &configInfo,\n> ControlInfoMap *ipaControls) override;\n> @@ -319,6 +319,13 @@ int IPAIPU3::start()\n> return 0;\n> }\n> \n> +/**\n> + * \\brief Ensure that all processing has completed.\n> + */\n> +void IPAIPU3::stop()\n> +{\n> +}\n> +\n> /**\n> * \\brief Calculate a grid for the AWB statistics\n> *\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 935E2BDB1C\n\tfor ;\n\tMon, 25 Oct 2021 21:44:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4DAF864878;\n\tMon, 25 Oct 2021 23:44:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CAE260125\n\tfor ;\n\tMon, 25 Oct 2021 23:44:45 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D7D64E0A;\n\tMon, 25 Oct 2021 23:44:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o/fpIXFg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635198284;\n\tbh=Jz6jDB6dTgx4b2tLNaINle1K2jeysrnMVu91lfIEhlY=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=o/fpIXFgKpsu9vINM0+HG2HtQcoKoxiX+lixe+TpNLpL7nT5q4gXwxEiHG2lbokjK\n\tf2poxog/6S0jCV71rIYDxZKyQfdHtgQpSikPhdZ+7WinjITzT2cFxJcL1fJuKizzjb\n\tTUOttFrNyi+I51YOsVDNYRl1LtunZNyFrlsmN85I=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211022151218.111966-19-jeanmichel.hautbois@ideasonboard.com>","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-19-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 25 Oct 2021 22:44:42 +0100","Message-ID":"<163519828207.1095920.17285993705427201880@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v3 18/19] ipa: ipu3: Implement an\n\tempty stop() function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]