[{"id":20478,"web_url":"https://patchwork.libcamera.org/comment/20478/","msgid":"","date":"2021-10-25T21:42:47","subject":"Re: [libcamera-devel] [PATCH v3 17/19] ipa: ipu3: Fix badly\n\tdocumented context variables","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Fri, Oct 22, 2021 at 05:12:16PM +0200, Jean-Michel Hautbois wrote:\n> Doxygen warns us because the structures are referenced as \\struct while\n> they should be \\var. Fix it.\n> \n> Signed-off-by: Jean-Michel Hautbois \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/ipu3/ipa_context.cpp | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n> index 3c5aa89a..677c90fe 100644\n> --- a/src/ipa/ipu3/ipa_context.cpp\n> +++ b/src/ipa/ipu3/ipa_context.cpp\n> @@ -56,7 +56,7 @@ namespace libcamera::ipa::ipu3 {\n> */\n> \n> /**\n> - * \\struct IPASessionConfiguration::grid\n> + * \\var IPASessionConfiguration::grid\n> * \\brief Grid configuration of the IPA\n> *\n> * \\var IPASessionConfiguration::bdsGrid\n> @@ -70,7 +70,7 @@ namespace libcamera::ipa::ipu3 {\n> */\n> \n> /**\n> - * \\struct IPASessionConfiguration::agc\n> + * \\var IPASessionConfiguration::agc\n> * \\brief AGC parameters configuration of the IPA\n> *\n> * \\var IPASessionConfiguration::minShutterSpeed\n> @@ -87,7 +87,7 @@ namespace libcamera::ipa::ipu3 {\n> */\n> \n> /**\n> - * \\struct IPAFrameContext::agc\n> + * \\var IPAFrameContext::agc\n> * \\brief Context for the Automatic Gain Control algorithm\n> *\n> * The exposure and gain determined are expected to be applied to the sensor\n> @@ -103,10 +103,10 @@ namespace libcamera::ipa::ipu3 {\n> */\n> \n> /**\n> - * \\struct IPAFrameContext::awb\n> + * \\var IPAFrameContext::awb\n> * \\brief Context for the Automatic White Balance algorithm\n> *\n> - * \\struct IPAFrameContext::gains\n> + * \\var IPAFrameContext::gains\n> * \\brief White balance gains\n> *\n> * \\var IPAFrameContext::red\n> @@ -120,7 +120,7 @@ namespace libcamera::ipa::ipu3 {\n> */\n> \n> /**\n> - * \\struct IPAFrameContext::toneMapping\n> + * \\var IPAFrameContext::toneMapping\n> * \\brief Context for ToneMapping and Gamma control\n> *\n> * \\var IPAFrameContext::gamma","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9082BBF415\n\tfor ;\n\tMon, 25 Oct 2021 21:43:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 51CA764878;\n\tMon, 25 Oct 2021 23:43:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B3A260125\n\tfor ;\n\tMon, 25 Oct 2021 23:43:09 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 180E2E0A;\n\tMon, 25 Oct 2021 23:43:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vRgUmBbQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635198189;\n\tbh=eKhTzwQVrF2y7d8LTyeqcevGZWBgoWA2DIGSm5zjs6o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vRgUmBbQfJEPt0nMOpci6jInw/pRdtupn4Lqu0764VXaFltn0G7SvKMUIr6Daidx3\n\tQeiU4OJJCf9Jr1hJiMkdjgBOuRF56xAUqzd2Hv2Vum6BHvNbU81GFWw7EGfH75giQ4\n\tXj/odGWMo4V9ge58mbqWjjquBZ4oejQ6W5JDoEao=","Date":"Tue, 26 Oct 2021 00:42:47 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-18-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211022151218.111966-18-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 17/19] ipa: ipu3: Fix badly\n\tdocumented context variables","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20482,"web_url":"https://patchwork.libcamera.org/comment/20482/","msgid":"<163519836320.1095920.5208732624495003215@Monstersaurus>","date":"2021-10-25T21:46:03","subject":"Re: [libcamera-devel] [PATCH v3 17/19] ipa: ipu3: Fix badly\n\tdocumented context variables","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-10-22 16:12:16)\n> Doxygen warns us because the structures are referenced as \\struct while\n> they should be \\var. Fix it.\n> \n> Signed-off-by: Jean-Michel Hautbois \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/ipu3/ipa_context.cpp | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n> index 3c5aa89a..677c90fe 100644\n> --- a/src/ipa/ipu3/ipa_context.cpp\n> +++ b/src/ipa/ipu3/ipa_context.cpp\n> @@ -56,7 +56,7 @@ namespace libcamera::ipa::ipu3 {\n> */\n> \n> /**\n> - * \\struct IPASessionConfiguration::grid\n> + * \\var IPASessionConfiguration::grid\n> * \\brief Grid configuration of the IPA\n> *\n> * \\var IPASessionConfiguration::bdsGrid\n> @@ -70,7 +70,7 @@ namespace libcamera::ipa::ipu3 {\n> */\n> \n> /**\n> - * \\struct IPASessionConfiguration::agc\n> + * \\var IPASessionConfiguration::agc\n> * \\brief AGC parameters configuration of the IPA\n> *\n> * \\var IPASessionConfiguration::minShutterSpeed\n> @@ -87,7 +87,7 @@ namespace libcamera::ipa::ipu3 {\n> */\n> \n> /**\n> - * \\struct IPAFrameContext::agc\n> + * \\var IPAFrameContext::agc\n> * \\brief Context for the Automatic Gain Control algorithm\n> *\n> * The exposure and gain determined are expected to be applied to the sensor\n> @@ -103,10 +103,10 @@ namespace libcamera::ipa::ipu3 {\n> */\n> \n> /**\n> - * \\struct IPAFrameContext::awb\n> + * \\var IPAFrameContext::awb\n> * \\brief Context for the Automatic White Balance algorithm\n> *\n> - * \\struct IPAFrameContext::gains\n> + * \\var IPAFrameContext::gains\n> * \\brief White balance gains\n> *\n> * \\var IPAFrameContext::red\n> @@ -120,7 +120,7 @@ namespace libcamera::ipa::ipu3 {\n> */\n> \n> /**\n> - * \\struct IPAFrameContext::toneMapping\n> + * \\var IPAFrameContext::toneMapping\n> * \\brief Context for ToneMapping and Gamma control\n> *\n> * \\var IPAFrameContext::gamma\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8AC80BDB1C\n\tfor ;\n\tMon, 25 Oct 2021 21:46:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 489486487A;\n\tMon, 25 Oct 2021 23:46:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C4D7660125\n\tfor ;\n\tMon, 25 Oct 2021 23:46:06 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 77B00E0A;\n\tMon, 25 Oct 2021 23:46:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"f6prEW68\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635198366;\n\tbh=iCEXIxZj3WFFWkKRn/VBbmWraNvMrAnvg2eYIb157fY=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=f6prEW68YmLrbOv8vjoJdh9g2dWki3ATGTBDflrklNp/o9Z3hQqqd+ddE8WE6fEz0\n\t+KJoC5iV0HMHzL6yAkpBMcagYNY6wjfnN9zdSp2K6SLQBlGEDZ83cu09bYtWD34Uw7\n\tO4vNBX932j2eLS92Cgg9su4+z4y6Sd7gtHjLKSQ4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211022151218.111966-18-jeanmichel.hautbois@ideasonboard.com>","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-18-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 25 Oct 2021 22:46:03 +0100","Message-ID":"<163519836320.1095920.5208732624495003215@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v3 17/19] ipa: ipu3: Fix badly\n\tdocumented context variables","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]