[{"id":20474,"web_url":"https://patchwork.libcamera.org/comment/20474/","msgid":"<163519785472.1095920.7968475274097995621@Monstersaurus>","date":"2021-10-25T21:37:34","subject":"Re: [libcamera-devel] [PATCH v3 15/19] ipa: ipu3: Isolate\n\tipa_context documentation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-10-22 16:12:14)\n\nThis doesn't have a 'From' (me) line here, so I assume the commit author\nhas been set to you.\n\n\n> The IPU3 IPA core is growing with additional documentation. The\n> ipa_context documentation is stored here, but it pushes the IPU3\n> documentation and implementation further from the head of the file.\n> \n> Furthermore, the ipa_context documentation is outside of the ipa::ipu3\n> namespace and isn't identified correctly by Doxygen.\n> \n> Move the ipa_context to its own compilation object even though there\n> isn't any code, but to maintain consistency with our documentation\n> model.\n> \n> Correctly re-introduce the documentation into the libcamera::ipa::ipu3\n> namespace during the move.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nHowever, it only has my SoB ...  You'll need to add yours too ;-)\n\nI think I'm reviewing a patch I wrote here, but it still looks correct\nto me ;-) so ...\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n>  src/ipa/ipu3/ipa_context.cpp | 136 +++++++++++++++++++++++++++++++++++\n>  src/ipa/ipu3/ipu3.cpp        | 124 --------------------------------\n>  src/ipa/ipu3/meson.build     |   1 +\n>  3 files changed, 137 insertions(+), 124 deletions(-)\n>  create mode 100644 src/ipa/ipu3/ipa_context.cpp\n> \n> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n> new file mode 100644\n> index 00000000..3e154e60\n> --- /dev/null\n> +++ b/src/ipa/ipu3/ipa_context.cpp\n> @@ -0,0 +1,136 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2021, Google Inc.\n> + *\n> + * ipa_context.cpp - IPU3 IPA Context\n> + */\n> +\n> +#include \"ipa_context.h\"\n> +\n> +namespace libcamera::ipa::ipu3 {\n> +\n> +/**\n> + * \\file ipa_context.h\n> + * \\brief Context and state information shared between the algorithms\n> + */\n> +\n> +/**\n> + * \\struct IPASessionConfiguration\n> + * \\brief Session configuration for the IPA module\n> + *\n> + * The session configuration contains all IPA configuration parameters that\n> + * remain constant during the capture session, from IPA module start to stop.\n> + * It is typically set during the configure() operation of the IPA module, but\n> + * may also be updated in the start() operation.\n> + */\n> +\n> +/**\n> + * \\struct IPAFrameContext\n> + * \\brief Per-frame context for algorithms\n> + *\n> + * The frame context stores data specific to a single frame processed by the\n> + * IPA. Each frame processed by the IPA has a context associated with it,\n> + * accessible through the IPAContext structure.\n> + *\n> + * \\todo Detail how to access contexts for a particular frame\n> + *\n> + * Each of the fields in the frame context belongs to either a specific\n> + * algorithm, or to the top-level IPA module. A field may be read by any\n> + * algorithm, but should only be written by its owner.\n> + */\n> +\n> +/**\n> + * \\struct IPAContext\n> + * \\brief Global IPA context data shared between all algorithms\n> + *\n> + * \\var IPAContext::configuration\n> + * \\brief The IPA session configuration, immutable during the session\n> + *\n> + * \\var IPAContext::frameContext\n> + * \\brief The frame context for the frame being processed\n> + *\n> + * \\todo While the frame context is supposed to be per-frame, this\n> + * single frame context stores data related to both the current frame\n> + * and the previous frames, with fields being updated as the algorithms\n> + * are run. This needs to be turned into real per-frame data storage.\n> + */\n> +\n> +/**\n> + * \\struct IPASessionConfiguration::grid\n> + * \\brief Grid configuration of the IPA\n> + *\n> + * \\var IPASessionConfiguration::grid::bdsGrid\n> + * \\brief Bayer Down Scaler grid plane config used by the kernel\n> + *\n> + * \\var IPASessionConfiguration::grid::bdsOutputSize\n> + * \\brief BDS output size configured by the pipeline handler\n> + *\n> + * \\var IPASessionConfiguration::grid::stride\n> + * \\brief Number of cells on one line including the ImgU padding\n> + */\n> +\n> +/**\n> + * \\struct IPASessionConfiguration::agc\n> + * \\brief AGC parameters configuration of the IPA\n> + *\n> + * \\var IPASessionConfiguration::agc::minShutterSpeed\n> + * \\brief Minimum shutter speed supported with the configured sensor\n> + *\n> + * \\var IPASessionConfiguration::grid::maxShutterSpeed\n> + * \\brief Maximum shutter speed supported with the configured sensor\n> + *\n> + * \\var IPASessionConfiguration::grid::minAnalogueGain\n> + * \\brief Minimum analogue gain supported with the configured sensor\n> + *\n> + * \\var IPASessionConfiguration::grid::maxAnalogueGain\n> + * \\brief Maximum analogue gain supported with the configured sensor\n> + */\n> +\n> +/**\n> + * \\struct IPAFrameContext::agc\n> + * \\brief Context for the Automatic Gain Control algorithm\n> + *\n> + * The exposure and gain determined are expected to be applied to the sensor\n> + * at the earliest opportunity.\n> + *\n> + * \\var IPAFrameContext::agc::exposure\n> + * \\brief Exposure time expressed as a number of lines\n> + *\n> + * \\var IPAFrameContext::agc::gain\n> + * \\brief Analogue gain multiplier\n> + *\n> + * The gain should be adapted to the sensor specific gain code before applying.\n> + */\n> +\n> +/**\n> + * \\struct IPAFrameContext::awb\n> + * \\brief Context for the Automatic White Balance algorithm\n> + *\n> + * \\struct IPAFrameContext::awb::gains\n> + * \\brief White balance gains\n> + *\n> + * \\var IPAFrameContext::awb::gains::red\n> + * \\brief White balance gain for R channel\n> + *\n> + * \\var IPAFrameContext::awb::gains::green\n> + * \\brief White balance gain for G channel\n> + *\n> + * \\var IPAFrameContext::awb::gains::blue\n> + * \\brief White balance gain for B channel\n> + */\n> +\n> +/**\n> + * \\struct IPAFrameContext::toneMapping\n> + * \\brief Context for ToneMapping and Gamma control\n> + *\n> + * \\var IPAFrameContext::toneMapping::gamma\n> + * \\brief Gamma value for the LUT\n> + *\n> + * \\var IPAFrameContext::toneMapping::gammaCorrection\n> + * \\brief Per-pixel tone mapping implemented as a LUT\n> + *\n> + * The LUT structure is defined by the IPU3 kernel interface. See\n> + * <linux/intel-ipu3.h> struct ipu3_uapi_gamma_corr_lut for further details.\n> + */\n> +\n> +} /* namespace libcamera::ipa::ipu3 */\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index f7632bc0..065febf8 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -37,130 +37,6 @@\n>  #include \"algorithms/tone_mapping.h\"\n>  #include \"libipa/camera_sensor_helper.h\"\n>  \n> -/**\n> - * \\file ipa_context.h\n> - * \\brief Context and state information shared between the algorithms\n> - */\n> -\n> -/**\n> - * \\struct IPASessionConfiguration\n> - * \\brief Session configuration for the IPA module\n> - *\n> - * The session configuration contains all IPA configuration parameters that\n> - * remain constant during the capture session, from IPA module start to stop.\n> - * It is typically set during the configure() operation of the IPA module, but\n> - * may also be updated in the start() operation.\n> - */\n> -\n> -/**\n> - * \\struct IPAFrameContext\n> - * \\brief Per-frame context for algorithms\n> - *\n> - * The frame context stores data specific to a single frame processed by the\n> - * IPA. Each frame processed by the IPA has a context associated with it,\n> - * accessible through the IPAContext structure.\n> - *\n> - * \\todo Detail how to access contexts for a particular frame\n> - *\n> - * Each of the fields in the frame context belongs to either a specific\n> - * algorithm, or to the top-level IPA module. A field may be read by any\n> - * algorithm, but should only be written by its owner.\n> - */\n> -\n> -/**\n> - * \\struct IPAContext\n> - * \\brief Global IPA context data shared between all algorithms\n> - *\n> - * \\var IPAContext::configuration\n> - * \\brief The IPA session configuration, immutable during the session\n> - *\n> - * \\var IPAContext::frameContext\n> - * \\brief The frame context for the frame being processed\n> - *\n> - * \\todo While the frame context is supposed to be per-frame, this\n> - * single frame context stores data related to both the current frame\n> - * and the previous frames, with fields being updated as the algorithms\n> - * are run. This needs to be turned into real per-frame data storage.\n> - */\n> -\n> -/**\n> - * \\struct IPASessionConfiguration::grid\n> - * \\brief Grid configuration of the IPA\n> - *\n> - * \\var IPASessionConfiguration::grid::bdsGrid\n> - * \\brief Bayer Down Scaler grid plane config used by the kernel\n> - *\n> - * \\var IPASessionConfiguration::grid::bdsOutputSize\n> - * \\brief BDS output size configured by the pipeline handler\n> - *\n> - * \\var IPASessionConfiguration::grid::stride\n> - * \\brief Number of cells on one line including the ImgU padding\n> - */\n> -\n> -/**\n> - * \\struct IPASessionConfiguration::agc\n> - * \\brief AGC parameters configuration of the IPA\n> - *\n> - * \\var IPASessionConfiguration::agc::minShutterSpeed\n> - * \\brief Minimum shutter speed supported with the configured sensor\n> - *\n> - * \\var IPASessionConfiguration::grid::maxShutterSpeed\n> - * \\brief Maximum shutter speed supported with the configured sensor\n> - *\n> - * \\var IPASessionConfiguration::grid::minAnalogueGain\n> - * \\brief Minimum analogue gain supported with the configured sensor\n> - *\n> - * \\var IPASessionConfiguration::grid::maxAnalogueGain\n> - * \\brief Maximum analogue gain supported with the configured sensor\n> - */\n> -\n> -/**\n> - * \\struct IPAFrameContext::agc\n> - * \\brief Context for the Automatic Gain Control algorithm\n> - *\n> - * The exposure and gain determined are expected to be applied to the sensor\n> - * at the earliest opportunity.\n> - *\n> - * \\var IPAFrameContext::agc::exposure\n> - * \\brief Exposure time expressed as a number of lines\n> - *\n> - * \\var IPAFrameContext::agc::gain\n> - * \\brief Analogue gain multiplier\n> - *\n> - * The gain should be adapted to the sensor specific gain code before applying.\n> - */\n> -\n> -/**\n> - * \\struct IPAFrameContext::awb\n> - * \\brief Context for the Automatic White Balance algorithm\n> - *\n> - * \\struct IPAFrameContext::awb::gains\n> - * \\brief White balance gains\n> - *\n> - * \\var IPAFrameContext::awb::gains::red\n> - * \\brief White balance gain for R channel\n> - *\n> - * \\var IPAFrameContext::awb::gains::green\n> - * \\brief White balance gain for G channel\n> - *\n> - * \\var IPAFrameContext::awb::gains::blue\n> - * \\brief White balance gain for B channel\n> - */\n> -\n> -/**\n> - * \\struct IPAFrameContext::toneMapping\n> - * \\brief Context for ToneMapping and Gamma control\n> - *\n> - * \\var IPAFrameContext::toneMapping::gamma\n> - * \\brief Gamma value for the LUT\n> - *\n> - * \\var IPAFrameContext::toneMapping::gammaCorrection\n> - * \\brief Per-pixel tone mapping implemented as a LUT\n> - *\n> - * The LUT structure is defined by the IPU3 kernel interface. See\n> - * <linux/intel-ipu3.h> struct ipu3_uapi_gamma_corr_lut for further details.\n> - */\n> -\n>  /* Minimum grid width, expressed as a number of cells */\n>  static constexpr uint32_t kMinGridWidth = 16;\n>  /* Maximum grid width, expressed as a number of cells */\n> diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\n> index 39320980..3194111a 100644\n> --- a/src/ipa/ipu3/meson.build\n> +++ b/src/ipa/ipu3/meson.build\n> @@ -5,6 +5,7 @@ subdir('algorithms')\n>  ipa_name = 'ipa_ipu3'\n>  \n>  ipu3_ipa_sources = files([\n> +    'ipa_context.cpp',\n>      'ipu3.cpp',\n>  ])\n>  \n> -- \n> 2.32.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C972BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Oct 2021 21:37:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB84764878;\n\tMon, 25 Oct 2021 23:37:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F0A160125\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Oct 2021 23:37:37 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 35CA4E0A;\n\tMon, 25 Oct 2021 23:37:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mDy7glZq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635197857;\n\tbh=/ukYIfbpvVYIPHWeW5+UfYYSEdnIBLsHtrdK7lzu0Uc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=mDy7glZqJ0YuBkLxteMgyoPpA+m04BBVH/Ky2LzK/cnx+jt38Em7nuXX8GmzPY9pp\n\tDmna+ZrAdh9j/L79jncamflEs1wOJPuELm0y83DFtiXK4OEY5Bods4yUs9JPv3n7R1\n\t6Bz2w/YjBHiMTE0FvpXzqw04JTbweBERIv4Wt0vw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211022151218.111966-16-jeanmichel.hautbois@ideasonboard.com>","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-16-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 25 Oct 2021 22:37:34 +0100","Message-ID":"<163519785472.1095920.7968475274097995621@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v3 15/19] ipa: ipu3: Isolate\n\tipa_context documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":20475,"web_url":"https://patchwork.libcamera.org/comment/20475/","msgid":"<YXckKHRJFB7i0Wjv@pendragon.ideasonboard.com>","date":"2021-10-25T21:39:52","subject":"Re: [libcamera-devel] [PATCH v3 15/19] ipa: ipu3: Isolate\n\tipa_context documentation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel and Kieran,\n\nThank you for the patch.\n\nOn Fri, Oct 22, 2021 at 05:12:14PM +0200, Jean-Michel Hautbois wrote:\n\nNo From: line from Kieran here ?\n\n> The IPU3 IPA core is growing with additional documentation. The\n> ipa_context documentation is stored here, but it pushes the IPU3\n> documentation and implementation further from the head of the file.\n> \n> Furthermore, the ipa_context documentation is outside of the ipa::ipu3\n> namespace and isn't identified correctly by Doxygen.\n> \n> Move the ipa_context to its own compilation object even though there\n> isn't any code, but to maintain consistency with our documentation\n> model.\n> \n> Correctly re-introduce the documentation into the libcamera::ipa::ipu3\n> namespace during the move.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/ipa/ipu3/ipa_context.cpp | 136 +++++++++++++++++++++++++++++++++++\n>  src/ipa/ipu3/ipu3.cpp        | 124 --------------------------------\n>  src/ipa/ipu3/meson.build     |   1 +\n>  3 files changed, 137 insertions(+), 124 deletions(-)\n>  create mode 100644 src/ipa/ipu3/ipa_context.cpp\n> \n> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n> new file mode 100644\n> index 00000000..3e154e60\n> --- /dev/null\n> +++ b/src/ipa/ipu3/ipa_context.cpp\n> @@ -0,0 +1,136 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2021, Google Inc.\n> + *\n> + * ipa_context.cpp - IPU3 IPA Context\n> + */\n> +\n> +#include \"ipa_context.h\"\n> +\n> +namespace libcamera::ipa::ipu3 {\n> +\n> +/**\n> + * \\file ipa_context.h\n> + * \\brief Context and state information shared between the algorithms\n> + */\n\nWe usually put the \\file block before the namespace.\n\n> +\n> +/**\n> + * \\struct IPASessionConfiguration\n> + * \\brief Session configuration for the IPA module\n> + *\n> + * The session configuration contains all IPA configuration parameters that\n> + * remain constant during the capture session, from IPA module start to stop.\n> + * It is typically set during the configure() operation of the IPA module, but\n> + * may also be updated in the start() operation.\n> + */\n> +\n> +/**\n> + * \\struct IPAFrameContext\n> + * \\brief Per-frame context for algorithms\n> + *\n> + * The frame context stores data specific to a single frame processed by the\n> + * IPA. Each frame processed by the IPA has a context associated with it,\n> + * accessible through the IPAContext structure.\n> + *\n> + * \\todo Detail how to access contexts for a particular frame\n> + *\n> + * Each of the fields in the frame context belongs to either a specific\n> + * algorithm, or to the top-level IPA module. A field may be read by any\n> + * algorithm, but should only be written by its owner.\n> + */\n> +\n> +/**\n> + * \\struct IPAContext\n> + * \\brief Global IPA context data shared between all algorithms\n> + *\n> + * \\var IPAContext::configuration\n> + * \\brief The IPA session configuration, immutable during the session\n> + *\n> + * \\var IPAContext::frameContext\n> + * \\brief The frame context for the frame being processed\n> + *\n> + * \\todo While the frame context is supposed to be per-frame, this\n> + * single frame context stores data related to both the current frame\n> + * and the previous frames, with fields being updated as the algorithms\n> + * are run. This needs to be turned into real per-frame data storage.\n> + */\n> +\n> +/**\n> + * \\struct IPASessionConfiguration::grid\n> + * \\brief Grid configuration of the IPA\n> + *\n> + * \\var IPASessionConfiguration::grid::bdsGrid\n> + * \\brief Bayer Down Scaler grid plane config used by the kernel\n> + *\n> + * \\var IPASessionConfiguration::grid::bdsOutputSize\n> + * \\brief BDS output size configured by the pipeline handler\n> + *\n> + * \\var IPASessionConfiguration::grid::stride\n> + * \\brief Number of cells on one line including the ImgU padding\n> + */\n> +\n> +/**\n> + * \\struct IPASessionConfiguration::agc\n> + * \\brief AGC parameters configuration of the IPA\n> + *\n> + * \\var IPASessionConfiguration::agc::minShutterSpeed\n> + * \\brief Minimum shutter speed supported with the configured sensor\n> + *\n> + * \\var IPASessionConfiguration::grid::maxShutterSpeed\n> + * \\brief Maximum shutter speed supported with the configured sensor\n> + *\n> + * \\var IPASessionConfiguration::grid::minAnalogueGain\n> + * \\brief Minimum analogue gain supported with the configured sensor\n> + *\n> + * \\var IPASessionConfiguration::grid::maxAnalogueGain\n> + * \\brief Maximum analogue gain supported with the configured sensor\n> + */\n> +\n> +/**\n> + * \\struct IPAFrameContext::agc\n> + * \\brief Context for the Automatic Gain Control algorithm\n> + *\n> + * The exposure and gain determined are expected to be applied to the sensor\n> + * at the earliest opportunity.\n> + *\n> + * \\var IPAFrameContext::agc::exposure\n> + * \\brief Exposure time expressed as a number of lines\n> + *\n> + * \\var IPAFrameContext::agc::gain\n> + * \\brief Analogue gain multiplier\n> + *\n> + * The gain should be adapted to the sensor specific gain code before applying.\n> + */\n> +\n> +/**\n> + * \\struct IPAFrameContext::awb\n> + * \\brief Context for the Automatic White Balance algorithm\n> + *\n> + * \\struct IPAFrameContext::awb::gains\n> + * \\brief White balance gains\n> + *\n> + * \\var IPAFrameContext::awb::gains::red\n> + * \\brief White balance gain for R channel\n> + *\n> + * \\var IPAFrameContext::awb::gains::green\n> + * \\brief White balance gain for G channel\n> + *\n> + * \\var IPAFrameContext::awb::gains::blue\n> + * \\brief White balance gain for B channel\n> + */\n> +\n> +/**\n> + * \\struct IPAFrameContext::toneMapping\n> + * \\brief Context for ToneMapping and Gamma control\n> + *\n> + * \\var IPAFrameContext::toneMapping::gamma\n> + * \\brief Gamma value for the LUT\n> + *\n> + * \\var IPAFrameContext::toneMapping::gammaCorrection\n> + * \\brief Per-pixel tone mapping implemented as a LUT\n> + *\n> + * The LUT structure is defined by the IPU3 kernel interface. See\n> + * <linux/intel-ipu3.h> struct ipu3_uapi_gamma_corr_lut for further details.\n> + */\n> +\n> +} /* namespace libcamera::ipa::ipu3 */\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index f7632bc0..065febf8 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -37,130 +37,6 @@\n>  #include \"algorithms/tone_mapping.h\"\n>  #include \"libipa/camera_sensor_helper.h\"\n>  \n> -/**\n> - * \\file ipa_context.h\n> - * \\brief Context and state information shared between the algorithms\n> - */\n> -\n> -/**\n> - * \\struct IPASessionConfiguration\n> - * \\brief Session configuration for the IPA module\n> - *\n> - * The session configuration contains all IPA configuration parameters that\n> - * remain constant during the capture session, from IPA module start to stop.\n> - * It is typically set during the configure() operation of the IPA module, but\n> - * may also be updated in the start() operation.\n> - */\n> -\n> -/**\n> - * \\struct IPAFrameContext\n> - * \\brief Per-frame context for algorithms\n> - *\n> - * The frame context stores data specific to a single frame processed by the\n> - * IPA. Each frame processed by the IPA has a context associated with it,\n> - * accessible through the IPAContext structure.\n> - *\n> - * \\todo Detail how to access contexts for a particular frame\n> - *\n> - * Each of the fields in the frame context belongs to either a specific\n> - * algorithm, or to the top-level IPA module. A field may be read by any\n> - * algorithm, but should only be written by its owner.\n> - */\n> -\n> -/**\n> - * \\struct IPAContext\n> - * \\brief Global IPA context data shared between all algorithms\n> - *\n> - * \\var IPAContext::configuration\n> - * \\brief The IPA session configuration, immutable during the session\n> - *\n> - * \\var IPAContext::frameContext\n> - * \\brief The frame context for the frame being processed\n> - *\n> - * \\todo While the frame context is supposed to be per-frame, this\n> - * single frame context stores data related to both the current frame\n> - * and the previous frames, with fields being updated as the algorithms\n> - * are run. This needs to be turned into real per-frame data storage.\n> - */\n> -\n> -/**\n> - * \\struct IPASessionConfiguration::grid\n> - * \\brief Grid configuration of the IPA\n> - *\n> - * \\var IPASessionConfiguration::grid::bdsGrid\n> - * \\brief Bayer Down Scaler grid plane config used by the kernel\n> - *\n> - * \\var IPASessionConfiguration::grid::bdsOutputSize\n> - * \\brief BDS output size configured by the pipeline handler\n> - *\n> - * \\var IPASessionConfiguration::grid::stride\n> - * \\brief Number of cells on one line including the ImgU padding\n> - */\n> -\n> -/**\n> - * \\struct IPASessionConfiguration::agc\n> - * \\brief AGC parameters configuration of the IPA\n> - *\n> - * \\var IPASessionConfiguration::agc::minShutterSpeed\n> - * \\brief Minimum shutter speed supported with the configured sensor\n> - *\n> - * \\var IPASessionConfiguration::grid::maxShutterSpeed\n> - * \\brief Maximum shutter speed supported with the configured sensor\n> - *\n> - * \\var IPASessionConfiguration::grid::minAnalogueGain\n> - * \\brief Minimum analogue gain supported with the configured sensor\n> - *\n> - * \\var IPASessionConfiguration::grid::maxAnalogueGain\n> - * \\brief Maximum analogue gain supported with the configured sensor\n> - */\n> -\n> -/**\n> - * \\struct IPAFrameContext::agc\n> - * \\brief Context for the Automatic Gain Control algorithm\n> - *\n> - * The exposure and gain determined are expected to be applied to the sensor\n> - * at the earliest opportunity.\n> - *\n> - * \\var IPAFrameContext::agc::exposure\n> - * \\brief Exposure time expressed as a number of lines\n> - *\n> - * \\var IPAFrameContext::agc::gain\n> - * \\brief Analogue gain multiplier\n> - *\n> - * The gain should be adapted to the sensor specific gain code before applying.\n> - */\n> -\n> -/**\n> - * \\struct IPAFrameContext::awb\n> - * \\brief Context for the Automatic White Balance algorithm\n> - *\n> - * \\struct IPAFrameContext::awb::gains\n> - * \\brief White balance gains\n> - *\n> - * \\var IPAFrameContext::awb::gains::red\n> - * \\brief White balance gain for R channel\n> - *\n> - * \\var IPAFrameContext::awb::gains::green\n> - * \\brief White balance gain for G channel\n> - *\n> - * \\var IPAFrameContext::awb::gains::blue\n> - * \\brief White balance gain for B channel\n> - */\n> -\n> -/**\n> - * \\struct IPAFrameContext::toneMapping\n> - * \\brief Context for ToneMapping and Gamma control\n> - *\n> - * \\var IPAFrameContext::toneMapping::gamma\n> - * \\brief Gamma value for the LUT\n> - *\n> - * \\var IPAFrameContext::toneMapping::gammaCorrection\n> - * \\brief Per-pixel tone mapping implemented as a LUT\n> - *\n> - * The LUT structure is defined by the IPU3 kernel interface. See\n> - * <linux/intel-ipu3.h> struct ipu3_uapi_gamma_corr_lut for further details.\n> - */\n> -\n>  /* Minimum grid width, expressed as a number of cells */\n>  static constexpr uint32_t kMinGridWidth = 16;\n>  /* Maximum grid width, expressed as a number of cells */\n> diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\n> index 39320980..3194111a 100644\n> --- a/src/ipa/ipu3/meson.build\n> +++ b/src/ipa/ipu3/meson.build\n> @@ -5,6 +5,7 @@ subdir('algorithms')\n>  ipa_name = 'ipa_ipu3'\n>  \n>  ipu3_ipa_sources = files([\n> +    'ipa_context.cpp',\n>      'ipu3.cpp',\n>  ])\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13EE8BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Oct 2021 21:40:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 732AA6487A;\n\tMon, 25 Oct 2021 23:40:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25BB260125\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Oct 2021 23:40:15 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 962E1E0A;\n\tMon, 25 Oct 2021 23:40:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vqYtFXT5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635198014;\n\tbh=MvOXnUCtv56LqEhPafdl36KVNX+omz8ZCBugUcPX8w8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vqYtFXT5SWnG/FGTfdIvOZYWWe6zjRzTJQ32FhQpsYsQo4MBx56KucOIjn0+7dKtr\n\taXI0XVZVaHKbrp1infk6ZACQKI6RRRLgGbykUY5MtQSnBPYhbkr2zu/vIHYwdP0eiS\n\tzzZHta+4JOTtfAgCd55RPH99y3WsxwutNIjTlHq0=","Date":"Tue, 26 Oct 2021 00:39:52 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>","Message-ID":"<YXckKHRJFB7i0Wjv@pendragon.ideasonboard.com>","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-16-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211022151218.111966-16-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 15/19] ipa: ipu3: Isolate\n\tipa_context documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":20502,"web_url":"https://patchwork.libcamera.org/comment/20502/","msgid":"<2d7ef224-b0fd-bed3-24a9-af0a5cdf1636@ideasonboard.com>","date":"2021-10-26T06:51:18","subject":"Re: [libcamera-devel] [PATCH v3 15/19] ipa: ipu3: Isolate\n\tipa_context documentation","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 25/10/2021 23:37, Kieran Bingham wrote:\n> Quoting Jean-Michel Hautbois (2021-10-22 16:12:14)\n> \n> This doesn't have a 'From' (me) line here, so I assume the commit author\n> has been set to you.\n\nMmmh, I don't know why, I will change the author before v4.\n\n> \n> \n>> The IPU3 IPA core is growing with additional documentation. The\n>> ipa_context documentation is stored here, but it pushes the IPU3\n>> documentation and implementation further from the head of the file.\n>>\n>> Furthermore, the ipa_context documentation is outside of the ipa::ipu3\n>> namespace and isn't identified correctly by Doxygen.\n>>\n>> Move the ipa_context to its own compilation object even though there\n>> isn't any code, but to maintain consistency with our documentation\n>> model.\n>>\n>> Correctly re-introduce the documentation into the libcamera::ipa::ipu3\n>> namespace during the move.\n>>\n>> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> However, it only has my SoB ...  You'll need to add yours too ;-)\n> \n> I think I'm reviewing a patch I wrote here, but it still looks correct\n> to me ;-) so ...\n> \n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nAnd:\nReviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n> \n>> ---\n>>   src/ipa/ipu3/ipa_context.cpp | 136 +++++++++++++++++++++++++++++++++++\n>>   src/ipa/ipu3/ipu3.cpp        | 124 --------------------------------\n>>   src/ipa/ipu3/meson.build     |   1 +\n>>   3 files changed, 137 insertions(+), 124 deletions(-)\n>>   create mode 100644 src/ipa/ipu3/ipa_context.cpp\n>>\n>> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n>> new file mode 100644\n>> index 00000000..3e154e60\n>> --- /dev/null\n>> +++ b/src/ipa/ipu3/ipa_context.cpp\n>> @@ -0,0 +1,136 @@\n>> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n>> +/*\n>> + * Copyright (C) 2021, Google Inc.\n>> + *\n>> + * ipa_context.cpp - IPU3 IPA Context\n>> + */\n>> +\n>> +#include \"ipa_context.h\"\n>> +\n>> +namespace libcamera::ipa::ipu3 {\n>> +\n>> +/**\n>> + * \\file ipa_context.h\n>> + * \\brief Context and state information shared between the algorithms\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPASessionConfiguration\n>> + * \\brief Session configuration for the IPA module\n>> + *\n>> + * The session configuration contains all IPA configuration parameters that\n>> + * remain constant during the capture session, from IPA module start to stop.\n>> + * It is typically set during the configure() operation of the IPA module, but\n>> + * may also be updated in the start() operation.\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPAFrameContext\n>> + * \\brief Per-frame context for algorithms\n>> + *\n>> + * The frame context stores data specific to a single frame processed by the\n>> + * IPA. Each frame processed by the IPA has a context associated with it,\n>> + * accessible through the IPAContext structure.\n>> + *\n>> + * \\todo Detail how to access contexts for a particular frame\n>> + *\n>> + * Each of the fields in the frame context belongs to either a specific\n>> + * algorithm, or to the top-level IPA module. A field may be read by any\n>> + * algorithm, but should only be written by its owner.\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPAContext\n>> + * \\brief Global IPA context data shared between all algorithms\n>> + *\n>> + * \\var IPAContext::configuration\n>> + * \\brief The IPA session configuration, immutable during the session\n>> + *\n>> + * \\var IPAContext::frameContext\n>> + * \\brief The frame context for the frame being processed\n>> + *\n>> + * \\todo While the frame context is supposed to be per-frame, this\n>> + * single frame context stores data related to both the current frame\n>> + * and the previous frames, with fields being updated as the algorithms\n>> + * are run. This needs to be turned into real per-frame data storage.\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPASessionConfiguration::grid\n>> + * \\brief Grid configuration of the IPA\n>> + *\n>> + * \\var IPASessionConfiguration::grid::bdsGrid\n>> + * \\brief Bayer Down Scaler grid plane config used by the kernel\n>> + *\n>> + * \\var IPASessionConfiguration::grid::bdsOutputSize\n>> + * \\brief BDS output size configured by the pipeline handler\n>> + *\n>> + * \\var IPASessionConfiguration::grid::stride\n>> + * \\brief Number of cells on one line including the ImgU padding\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPASessionConfiguration::agc\n>> + * \\brief AGC parameters configuration of the IPA\n>> + *\n>> + * \\var IPASessionConfiguration::agc::minShutterSpeed\n>> + * \\brief Minimum shutter speed supported with the configured sensor\n>> + *\n>> + * \\var IPASessionConfiguration::grid::maxShutterSpeed\n>> + * \\brief Maximum shutter speed supported with the configured sensor\n>> + *\n>> + * \\var IPASessionConfiguration::grid::minAnalogueGain\n>> + * \\brief Minimum analogue gain supported with the configured sensor\n>> + *\n>> + * \\var IPASessionConfiguration::grid::maxAnalogueGain\n>> + * \\brief Maximum analogue gain supported with the configured sensor\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPAFrameContext::agc\n>> + * \\brief Context for the Automatic Gain Control algorithm\n>> + *\n>> + * The exposure and gain determined are expected to be applied to the sensor\n>> + * at the earliest opportunity.\n>> + *\n>> + * \\var IPAFrameContext::agc::exposure\n>> + * \\brief Exposure time expressed as a number of lines\n>> + *\n>> + * \\var IPAFrameContext::agc::gain\n>> + * \\brief Analogue gain multiplier\n>> + *\n>> + * The gain should be adapted to the sensor specific gain code before applying.\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPAFrameContext::awb\n>> + * \\brief Context for the Automatic White Balance algorithm\n>> + *\n>> + * \\struct IPAFrameContext::awb::gains\n>> + * \\brief White balance gains\n>> + *\n>> + * \\var IPAFrameContext::awb::gains::red\n>> + * \\brief White balance gain for R channel\n>> + *\n>> + * \\var IPAFrameContext::awb::gains::green\n>> + * \\brief White balance gain for G channel\n>> + *\n>> + * \\var IPAFrameContext::awb::gains::blue\n>> + * \\brief White balance gain for B channel\n>> + */\n>> +\n>> +/**\n>> + * \\struct IPAFrameContext::toneMapping\n>> + * \\brief Context for ToneMapping and Gamma control\n>> + *\n>> + * \\var IPAFrameContext::toneMapping::gamma\n>> + * \\brief Gamma value for the LUT\n>> + *\n>> + * \\var IPAFrameContext::toneMapping::gammaCorrection\n>> + * \\brief Per-pixel tone mapping implemented as a LUT\n>> + *\n>> + * The LUT structure is defined by the IPU3 kernel interface. See\n>> + * <linux/intel-ipu3.h> struct ipu3_uapi_gamma_corr_lut for further details.\n>> + */\n>> +\n>> +} /* namespace libcamera::ipa::ipu3 */\n>> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n>> index f7632bc0..065febf8 100644\n>> --- a/src/ipa/ipu3/ipu3.cpp\n>> +++ b/src/ipa/ipu3/ipu3.cpp\n>> @@ -37,130 +37,6 @@\n>>   #include \"algorithms/tone_mapping.h\"\n>>   #include \"libipa/camera_sensor_helper.h\"\n>>   \n>> -/**\n>> - * \\file ipa_context.h\n>> - * \\brief Context and state information shared between the algorithms\n>> - */\n>> -\n>> -/**\n>> - * \\struct IPASessionConfiguration\n>> - * \\brief Session configuration for the IPA module\n>> - *\n>> - * The session configuration contains all IPA configuration parameters that\n>> - * remain constant during the capture session, from IPA module start to stop.\n>> - * It is typically set during the configure() operation of the IPA module, but\n>> - * may also be updated in the start() operation.\n>> - */\n>> -\n>> -/**\n>> - * \\struct IPAFrameContext\n>> - * \\brief Per-frame context for algorithms\n>> - *\n>> - * The frame context stores data specific to a single frame processed by the\n>> - * IPA. Each frame processed by the IPA has a context associated with it,\n>> - * accessible through the IPAContext structure.\n>> - *\n>> - * \\todo Detail how to access contexts for a particular frame\n>> - *\n>> - * Each of the fields in the frame context belongs to either a specific\n>> - * algorithm, or to the top-level IPA module. A field may be read by any\n>> - * algorithm, but should only be written by its owner.\n>> - */\n>> -\n>> -/**\n>> - * \\struct IPAContext\n>> - * \\brief Global IPA context data shared between all algorithms\n>> - *\n>> - * \\var IPAContext::configuration\n>> - * \\brief The IPA session configuration, immutable during the session\n>> - *\n>> - * \\var IPAContext::frameContext\n>> - * \\brief The frame context for the frame being processed\n>> - *\n>> - * \\todo While the frame context is supposed to be per-frame, this\n>> - * single frame context stores data related to both the current frame\n>> - * and the previous frames, with fields being updated as the algorithms\n>> - * are run. This needs to be turned into real per-frame data storage.\n>> - */\n>> -\n>> -/**\n>> - * \\struct IPASessionConfiguration::grid\n>> - * \\brief Grid configuration of the IPA\n>> - *\n>> - * \\var IPASessionConfiguration::grid::bdsGrid\n>> - * \\brief Bayer Down Scaler grid plane config used by the kernel\n>> - *\n>> - * \\var IPASessionConfiguration::grid::bdsOutputSize\n>> - * \\brief BDS output size configured by the pipeline handler\n>> - *\n>> - * \\var IPASessionConfiguration::grid::stride\n>> - * \\brief Number of cells on one line including the ImgU padding\n>> - */\n>> -\n>> -/**\n>> - * \\struct IPASessionConfiguration::agc\n>> - * \\brief AGC parameters configuration of the IPA\n>> - *\n>> - * \\var IPASessionConfiguration::agc::minShutterSpeed\n>> - * \\brief Minimum shutter speed supported with the configured sensor\n>> - *\n>> - * \\var IPASessionConfiguration::grid::maxShutterSpeed\n>> - * \\brief Maximum shutter speed supported with the configured sensor\n>> - *\n>> - * \\var IPASessionConfiguration::grid::minAnalogueGain\n>> - * \\brief Minimum analogue gain supported with the configured sensor\n>> - *\n>> - * \\var IPASessionConfiguration::grid::maxAnalogueGain\n>> - * \\brief Maximum analogue gain supported with the configured sensor\n>> - */\n>> -\n>> -/**\n>> - * \\struct IPAFrameContext::agc\n>> - * \\brief Context for the Automatic Gain Control algorithm\n>> - *\n>> - * The exposure and gain determined are expected to be applied to the sensor\n>> - * at the earliest opportunity.\n>> - *\n>> - * \\var IPAFrameContext::agc::exposure\n>> - * \\brief Exposure time expressed as a number of lines\n>> - *\n>> - * \\var IPAFrameContext::agc::gain\n>> - * \\brief Analogue gain multiplier\n>> - *\n>> - * The gain should be adapted to the sensor specific gain code before applying.\n>> - */\n>> -\n>> -/**\n>> - * \\struct IPAFrameContext::awb\n>> - * \\brief Context for the Automatic White Balance algorithm\n>> - *\n>> - * \\struct IPAFrameContext::awb::gains\n>> - * \\brief White balance gains\n>> - *\n>> - * \\var IPAFrameContext::awb::gains::red\n>> - * \\brief White balance gain for R channel\n>> - *\n>> - * \\var IPAFrameContext::awb::gains::green\n>> - * \\brief White balance gain for G channel\n>> - *\n>> - * \\var IPAFrameContext::awb::gains::blue\n>> - * \\brief White balance gain for B channel\n>> - */\n>> -\n>> -/**\n>> - * \\struct IPAFrameContext::toneMapping\n>> - * \\brief Context for ToneMapping and Gamma control\n>> - *\n>> - * \\var IPAFrameContext::toneMapping::gamma\n>> - * \\brief Gamma value for the LUT\n>> - *\n>> - * \\var IPAFrameContext::toneMapping::gammaCorrection\n>> - * \\brief Per-pixel tone mapping implemented as a LUT\n>> - *\n>> - * The LUT structure is defined by the IPU3 kernel interface. See\n>> - * <linux/intel-ipu3.h> struct ipu3_uapi_gamma_corr_lut for further details.\n>> - */\n>> -\n>>   /* Minimum grid width, expressed as a number of cells */\n>>   static constexpr uint32_t kMinGridWidth = 16;\n>>   /* Maximum grid width, expressed as a number of cells */\n>> diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\n>> index 39320980..3194111a 100644\n>> --- a/src/ipa/ipu3/meson.build\n>> +++ b/src/ipa/ipu3/meson.build\n>> @@ -5,6 +5,7 @@ subdir('algorithms')\n>>   ipa_name = 'ipa_ipu3'\n>>   \n>>   ipu3_ipa_sources = files([\n>> +    'ipa_context.cpp',\n>>       'ipu3.cpp',\n>>   ])\n>>   \n>> -- \n>> 2.32.0\n>>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26B10BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 26 Oct 2021 06:51:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7254D6487A;\n\tTue, 26 Oct 2021 08:51:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAF6D6486B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Oct 2021 08:51:21 +0200 (CEST)","from [IPV6:2a01:e0a:169:7140:dce3:eb54:18d7:6f3d] (unknown\n\t[IPv6:2a01:e0a:169:7140:dce3:eb54:18d7:6f3d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6B5C13F0;\n\tTue, 26 Oct 2021 08:51:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TF5oZQG/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635231081;\n\tbh=Es66rpENEMJnnOurhXTXZJdKaQiYqR5DQ2t9rDGBbbw=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=TF5oZQG/V3jGvm7wFYun1JI+Yzr1l4dywaHNdexPHhGhjk2So8xcvQroOYYvcwiqp\n\t0jff4WUhDX3lA8AHpoQyCnYnIMcuQ7UsMmQGtShML6eG4dfEJ1n1izd+PbomZkZcyh\n\tgfPD34Lp+M1QSm9ZGVq6USl0de6rCSB/PRqDeAns=","Message-ID":"<2d7ef224-b0fd-bed3-24a9-af0a5cdf1636@ideasonboard.com>","Date":"Tue, 26 Oct 2021 08:51:18 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.1.2","Content-Language":"en-US","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-16-jeanmichel.hautbois@ideasonboard.com>\n\t<163519785472.1095920.7968475274097995621@Monstersaurus>","From":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>","In-Reply-To":"<163519785472.1095920.7968475274097995621@Monstersaurus>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 15/19] ipa: ipu3: Isolate\n\tipa_context documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]