[{"id":20473,"web_url":"https://patchwork.libcamera.org/comment/20473/","msgid":"","date":"2021-10-25T21:37:00","subject":"Re: [libcamera-devel] [PATCH v3 14/19] ipa: ipu3: algorithms: awb:\n\tPrivatize internal structures","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel and Kieran,\n\nThank you for the patch.\n\nOn Fri, Oct 22, 2021 at 05:12:13PM +0200, Jean-Michel Hautbois wrote:\n> From: Kieran Bingham \n> \n> The struct RGB and struct AwbStatus are used only by the internal\n> implementation of the AWB algorithm module.\n> \n> Move them into the private class declaration.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/ipu3/algorithms/awb.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\n> index 0c81e39e..b90782c1 100644\n> --- a/src/ipa/ipu3/algorithms/awb.h\n> +++ b/src/ipa/ipu3/algorithms/awb.h\n> @@ -42,6 +42,7 @@ public:\n> \tvoid prepare(IPAContext &context, ipu3_uapi_params *params) override;\n> \tvoid process(IPAContext &context, const ipu3_uapi_stats_3a *stats) override;\n> \n> +private:\n> \t/* \\todo Make these structs available to all the ISPs ? */\n> \tstruct RGB {\n> \t\tRGB(double _R = 0, double _G = 0, double _B = 0)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A20A2BDB1C\n\tfor ;\n\tMon, 25 Oct 2021 21:37:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 665D16486E;\n\tMon, 25 Oct 2021 23:37:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DC1560125\n\tfor ;\n\tMon, 25 Oct 2021 23:37:23 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CC5A0E0A;\n\tMon, 25 Oct 2021 23:37:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hl+mNHbj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635197843;\n\tbh=SSlFzz4UNmI9AAbE9nxFl2guNW4x2j+C+CuGMZVpItQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hl+mNHbj9iQ+fLROe9MAsjOWofomjGzG19TK0NMvC+Rfl3O7T8cd0nCTaE2HbASZs\n\tftIi5SzWe0086cXt3FXBqLsVKJGL+HJMVb0gB5gO1tnkOR8K5L0SE28KnZ9BRJ8xRt\n\tWzVrgWqTwFXVPegls5x19HuNqbTNvqoK11WKgjmE=","Date":"Tue, 26 Oct 2021 00:37:00 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-15-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211022151218.111966-15-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 14/19] ipa: ipu3: algorithms: awb:\n\tPrivatize internal structures","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20501,"web_url":"https://patchwork.libcamera.org/comment/20501/","msgid":"<5429469a-b214-8b95-ffd5-546fc5503b92@ideasonboard.com>","date":"2021-10-26T06:34:58","subject":"Re: [libcamera-devel] [PATCH v3 14/19] ipa: ipu3: algorithms: awb:\n\tPrivatize internal structures","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"On 25/10/2021 23:37, Laurent Pinchart wrote:\n> Hi Jean-Michel and Kieran,\n> \n> Thank you for the patch.\n> \n> On Fri, Oct 22, 2021 at 05:12:13PM +0200, Jean-Michel Hautbois wrote:\n>> From: Kieran Bingham \n>>\n>> The struct RGB and struct AwbStatus are used only by the internal\n>> implementation of the AWB algorithm module.\n>>\n>> Move them into the private class declaration.\n>>\n>> Signed-off-by: Kieran Bingham \n> \n> Reviewed-by: Laurent Pinchart \nReviewed-by: Jean-Michel Hautbois \n> \n>> ---\n>> src/ipa/ipu3/algorithms/awb.h | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\n>> index 0c81e39e..b90782c1 100644\n>> --- a/src/ipa/ipu3/algorithms/awb.h\n>> +++ b/src/ipa/ipu3/algorithms/awb.h\n>> @@ -42,6 +42,7 @@ public:\n>> \tvoid prepare(IPAContext &context, ipu3_uapi_params *params) override;\n>> \tvoid process(IPAContext &context, const ipu3_uapi_stats_3a *stats) override;\n>> \n>> +private:\n>> \t/* \\todo Make these structs available to all the ISPs ? */\n>> \tstruct RGB {\n>> \t\tRGB(double _R = 0, double _G = 0, double _B = 0)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29591BDB1C\n\tfor ;\n\tTue, 26 Oct 2021 06:35:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0DE264878;\n\tTue, 26 Oct 2021 08:35:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D8BA6486B\n\tfor ;\n\tTue, 26 Oct 2021 08:35:01 +0200 (CEST)","from [IPV6:2a01:e0a:169:7140:dce3:eb54:18d7:6f3d] (unknown\n\t[IPv6:2a01:e0a:169:7140:dce3:eb54:18d7:6f3d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F1A53F0;\n\tTue, 26 Oct 2021 08:35:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XHg2Mu//\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635230101;\n\tbh=yddhlC257ptP7uXqi1tTg6CxAgXBLbbTBk22v1DKPuU=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=XHg2Mu//vj4sO3bBuMbLJqQGZQvVl17i5hy9aIV2ZIvL9Dnq/SPzOEcrkMjV1F9Ms\n\teOZKZKgSLOFl9xh6CbmmQvzg29S/BZmEi7aSKSPtIipMyHlkFnilPQi5/ohRvL8ip6\n\tP+fiGg0P6Z5ymRJSMGFzL992B3DsoP5LQVUURbYI=","Message-ID":"<5429469a-b214-8b95-ffd5-546fc5503b92@ideasonboard.com>","Date":"Tue, 26 Oct 2021 08:34:58 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.1.2","Content-Language":"en-US","To":"Laurent Pinchart ","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-15-jeanmichel.hautbois@ideasonboard.com>\n\t","From":"Jean-Michel Hautbois ","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 14/19] ipa: ipu3: algorithms: awb:\n\tPrivatize internal structures","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]