[{"id":20472,"web_url":"https://patchwork.libcamera.org/comment/20472/","msgid":"","date":"2021-10-25T21:36:28","subject":"Re: [libcamera-devel] [PATCH v3 13/19] ipa: ipu3: Fix the IPU3 AWB\n\tdoxygen references","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel and Kieran,\n\nThank you for the patch.\n\nOn Fri, Oct 22, 2021 at 05:12:12PM +0200, Jean-Michel Hautbois wrote:\n> From: Kieran Bingham \n> \n> The AWB AwbStatus structure is contained within the Awb class.\n> Fix the Doxygen reference so that it can be found.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/ipu3/algorithms/awb.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n> index 101d84ca..d36271b0 100644\n> --- a/src/ipa/ipu3/algorithms/awb.cpp\n> +++ b/src/ipa/ipu3/algorithms/awb.cpp\n> @@ -71,7 +71,7 @@ static constexpr uint32_t kMinCellsPerZoneRatio = 255 * 90 / 100;\n> */\n> \n> /**\n> - * \\struct AwbStatus\n> + * \\struct Awb::AwbStatus\n> * \\brief AWB parameters calculated\n> *\n> * The AwbStatus structure is intended to store the AWB","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C8C4BDB1C\n\tfor ;\n\tMon, 25 Oct 2021 21:36:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D83FC64878;\n\tMon, 25 Oct 2021 23:36:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FFB460125\n\tfor ;\n\tMon, 25 Oct 2021 23:36:50 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F1EA0E0A;\n\tMon, 25 Oct 2021 23:36:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sauaZHTb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635197810;\n\tbh=g2L+epMzgn4ygCJiY6HJNShY7JUBQG+tpDBTuacgzpc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sauaZHTb/H3RGBKsSeUKQtWD1te5Y0E/sZlflP93WwFsBozEFPEeC2HNO/Col+s9I\n\tuy0OD05iS6LAigLqfLHJqwrvlMK34N1Lqkn8w9imqQhqjB4s3Uz8pY401x6ybx9P6D\n\tUIGm6sA54WJqfuy9GqgZFofhuaMgIT+rsl6U564Y=","Date":"Tue, 26 Oct 2021 00:36:28 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-14-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211022151218.111966-14-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 13/19] ipa: ipu3: Fix the IPU3 AWB\n\tdoxygen references","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20500,"web_url":"https://patchwork.libcamera.org/comment/20500/","msgid":"<102640fe-6aba-2fc7-31be-108a757d27d7@ideasonboard.com>","date":"2021-10-26T06:34:48","subject":"Re: [libcamera-devel] [PATCH v3 13/19] ipa: ipu3: Fix the IPU3 AWB\n\tdoxygen references","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"On 25/10/2021 23:36, Laurent Pinchart wrote:\n> Hi Jean-Michel and Kieran,\n> \n> Thank you for the patch.\n> \n> On Fri, Oct 22, 2021 at 05:12:12PM +0200, Jean-Michel Hautbois wrote:\n>> From: Kieran Bingham \n>>\n>> The AWB AwbStatus structure is contained within the Awb class.\n>> Fix the Doxygen reference so that it can be found.\n>>\n>> Signed-off-by: Kieran Bingham \n> \n> Reviewed-by: Laurent Pinchart \nReviewed-by: Jean-Michel Hautbois \n> \n>> ---\n>> src/ipa/ipu3/algorithms/awb.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n>> index 101d84ca..d36271b0 100644\n>> --- a/src/ipa/ipu3/algorithms/awb.cpp\n>> +++ b/src/ipa/ipu3/algorithms/awb.cpp\n>> @@ -71,7 +71,7 @@ static constexpr uint32_t kMinCellsPerZoneRatio = 255 * 90 / 100;\n>> */\n>> \n>> /**\n>> - * \\struct AwbStatus\n>> + * \\struct Awb::AwbStatus\n>> * \\brief AWB parameters calculated\n>> *\n>> * The AwbStatus structure is intended to store the AWB\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2156BDB1C\n\tfor ;\n\tTue, 26 Oct 2021 06:34:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E86D64878;\n\tTue, 26 Oct 2021 08:34:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 440186486B\n\tfor ;\n\tTue, 26 Oct 2021 08:34:51 +0200 (CEST)","from [IPV6:2a01:e0a:169:7140:dce3:eb54:18d7:6f3d] (unknown\n\t[IPv6:2a01:e0a:169:7140:dce3:eb54:18d7:6f3d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0556F3F0;\n\tTue, 26 Oct 2021 08:34:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"X7Zb9/CR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635230091;\n\tbh=k9FEE6eyTgH1heXJHw9ND20oW+uPXdn0slMBzlJ2zTo=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=X7Zb9/CR4OB0cQxZY/sNm5CBOyvte6Db3GTQpeIaNWscTnhSCLudJ4OZ6lmhOi3Vq\n\tA9O7ToMW2Ndl2hUd0ELV73p62ryWB/vcO+bv6KlfpGocZGLPTzSAKd3gmmn9hzrspO\n\tuvE85YdOEwfZzdty9l7xoQHizy4VZNqkm3d8pe7Y=","Message-ID":"<102640fe-6aba-2fc7-31be-108a757d27d7@ideasonboard.com>","Date":"Tue, 26 Oct 2021 08:34:48 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.1.2","Content-Language":"en-US","To":"Laurent Pinchart ","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-14-jeanmichel.hautbois@ideasonboard.com>\n\t","From":"Jean-Michel Hautbois ","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 13/19] ipa: ipu3: Fix the IPU3 AWB\n\tdoxygen references","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]