[{"id":20464,"web_url":"https://patchwork.libcamera.org/comment/20464/","msgid":"","date":"2021-10-25T21:23:59","subject":"Re: [libcamera-devel] [PATCH v3 09/19] ipa: ipu3: tonemapping:\n\tImplement configure call","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Fri, Oct 22, 2021 at 05:12:08PM +0200, Jean-Michel Hautbois wrote:\n> Let the algorithm perform its initial configuration. Implement\n> configure() to set a default gamma value and let process do the updates\n> needed.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/algorithms/tone_mapping.cpp | 16 ++++++++++++++++\n> src/ipa/ipu3/algorithms/tone_mapping.h | 1 +\n> 2 files changed, 17 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/algorithms/tone_mapping.cpp b/src/ipa/ipu3/algorithms/tone_mapping.cpp\n> index 40337f9d..8fa8c7e9 100644\n> --- a/src/ipa/ipu3/algorithms/tone_mapping.cpp\n> +++ b/src/ipa/ipu3/algorithms/tone_mapping.cpp\n> @@ -19,6 +19,22 @@ ToneMapping::ToneMapping()\n> {\n> }\n> \n> +/**\n> + * \\brief Configure the tone mapping given a configInfo\n> + * \\param[in] context The shared IPA context\n> + * \\param[in] configInfo The IPA configuration data\n> + *\n> + * \\return 0\n> + */\n> +int ToneMapping::configure(IPAContext &context,\n> +\t\t\t [[maybe_unused]] const IPAConfigInfo &configInfo)\n> +{\n> +\t/* Initialise tone mapping gamma value */\n\ns/value/value./\n\nReviewed-by: Laurent Pinchart \n\n> +\tcontext.frameContext.toneMapping.gamma = 0.0;\n> +\n> +\treturn 0;\n> +}\n> +\n> void ToneMapping::prepare([[maybe_unused]] IPAContext &context,\n> \t\t\t ipu3_uapi_params *params)\n> {\n> diff --git a/src/ipa/ipu3/algorithms/tone_mapping.h b/src/ipa/ipu3/algorithms/tone_mapping.h\n> index 1dae4f9a..46dd6171 100644\n> --- a/src/ipa/ipu3/algorithms/tone_mapping.h\n> +++ b/src/ipa/ipu3/algorithms/tone_mapping.h\n> @@ -18,6 +18,7 @@ class ToneMapping : public Algorithm\n> public:\n> \tToneMapping();\n> \n> +\tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n> \tvoid prepare(IPAContext &context, ipu3_uapi_params *params) override;\n> \tvoid process(IPAContext &context, const ipu3_uapi_stats_3a *stats) override;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 74796BF415\n\tfor ;\n\tMon, 25 Oct 2021 21:24:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E68064878;\n\tMon, 25 Oct 2021 23:24:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6763260125\n\tfor ;\n\tMon, 25 Oct 2021 23:24:22 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F08B0E0A;\n\tMon, 25 Oct 2021 23:24:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HB1EzA4i\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635197062;\n\tbh=TCyy8SCFkeb/Q58pNgi3++nw5mCTbHOHGWtPWmIxeM4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HB1EzA4ifYWoaARxCpbYP9bAMPN1FkdqJV7JFDkFSWf9NvXbydh+pC/oymd/UPiRz\n\t8fiNgFtp3rd8K+DSbCgBPHvLq5fBR6sb44W7buul2eiPI7NcsjUxiG5krdmSCe5R0c\n\tVb2fqzrR8Unp8KGJEuhbsKMt5OiZx2fEoGmsSmV8=","Date":"Tue, 26 Oct 2021 00:23:59 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-10-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211022151218.111966-10-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 09/19] ipa: ipu3: tonemapping:\n\tImplement configure call","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20469,"web_url":"https://patchwork.libcamera.org/comment/20469/","msgid":"<163519750112.1095920.12905657796570213262@Monstersaurus>","date":"2021-10-25T21:31:41","subject":"Re: [libcamera-devel] [PATCH v3 09/19] ipa: ipu3: tonemapping:\n\tImplement configure call","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-10-22 16:12:08)\n> Let the algorithm perform its initial configuration. Implement\n> configure() to set a default gamma value and let process do the updates\n> needed.\n> \n> Signed-off-by: Jean-Michel Hautbois \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/ipu3/algorithms/tone_mapping.cpp | 16 ++++++++++++++++\n> src/ipa/ipu3/algorithms/tone_mapping.h | 1 +\n> 2 files changed, 17 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/algorithms/tone_mapping.cpp b/src/ipa/ipu3/algorithms/tone_mapping.cpp\n> index 40337f9d..8fa8c7e9 100644\n> --- a/src/ipa/ipu3/algorithms/tone_mapping.cpp\n> +++ b/src/ipa/ipu3/algorithms/tone_mapping.cpp\n> @@ -19,6 +19,22 @@ ToneMapping::ToneMapping()\n> {\n> }\n> \n> +/**\n> + * \\brief Configure the tone mapping given a configInfo\n> + * \\param[in] context The shared IPA context\n> + * \\param[in] configInfo The IPA configuration data\n> + *\n> + * \\return 0\n> + */\n> +int ToneMapping::configure(IPAContext &context,\n> + [[maybe_unused]] const IPAConfigInfo &configInfo)\n> +{\n> + /* Initialise tone mapping gamma value */\n> + context.frameContext.toneMapping.gamma = 0.0;\n> +\n> + return 0;\n> +}\n> +\n> void ToneMapping::prepare([[maybe_unused]] IPAContext &context,\n> ipu3_uapi_params *params)\n> {\n> diff --git a/src/ipa/ipu3/algorithms/tone_mapping.h b/src/ipa/ipu3/algorithms/tone_mapping.h\n> index 1dae4f9a..46dd6171 100644\n> --- a/src/ipa/ipu3/algorithms/tone_mapping.h\n> +++ b/src/ipa/ipu3/algorithms/tone_mapping.h\n> @@ -18,6 +18,7 @@ class ToneMapping : public Algorithm\n> public:\n> ToneMapping();\n> \n> + int configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n> void prepare(IPAContext &context, ipu3_uapi_params *params) override;\n> void process(IPAContext &context, const ipu3_uapi_stats_3a *stats) override;\n> \n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ED439BF415\n\tfor ;\n\tMon, 25 Oct 2021 21:31:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ADE556486E;\n\tMon, 25 Oct 2021 23:31:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5A4E60125\n\tfor ;\n\tMon, 25 Oct 2021 23:31:44 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5583BE0A;\n\tMon, 25 Oct 2021 23:31:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bS+S5bdu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635197504;\n\tbh=/V9k34Dese1Ugrad/okrs1eHBqW48RQDhRUYQ3GoWLA=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=bS+S5bdu3s2A1VMTlZZKkqhSYuPUQ51SZ1Bou7NNaUMcONm3z6HD1BKG1LUjMER9N\n\tBEixQoccs/FUaN2n8qlEMyR1I+jlULTdbw2eMyP8RyTwQhb4CvtunJXITHKCVvWa8q\n\tgQkUY3/P8cZ9avrJkweEW+0k/8dZd6/O7y0neLkU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211022151218.111966-10-jeanmichel.hautbois@ideasonboard.com>","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-10-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 25 Oct 2021 22:31:41 +0100","Message-ID":"<163519750112.1095920.12905657796570213262@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v3 09/19] ipa: ipu3: tonemapping:\n\tImplement configure call","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]