[{"id":20459,"web_url":"https://patchwork.libcamera.org/comment/20459/","msgid":"<163519290301.1095920.13633668868831810323@Monstersaurus>","date":"2021-10-25T20:15:03","subject":"Re: [libcamera-devel] [PATCH v3 06/19] ipa: ipu3: awb: Reword\n\taccumulator documentation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-10-22 16:12:05)\n> Now that we moved the diagram into the AWB class documentation, reword the\n> accumulator documentation to make it clear it is not meant to be used\n> only in AWB.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/algorithms/awb.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n> index 7e10460f..101d84ca 100644\n> --- a/src/ipa/ipu3/algorithms/awb.cpp\n> +++ b/src/ipa/ipu3/algorithms/awb.cpp\n> @@ -46,9 +46,9 @@ static constexpr uint32_t kMinCellsPerZoneRatio = 255 * 90 / 100;\n> * \\struct Accumulator\n> * \\brief RGB statistics for a given zone\n> *\n> - * The Accumulator structure stores the sum of the average of each cell in a\n> - * zone of the image, as well as the number of cells which were unsaturated and\n> - * therefore included in the average.\n> + * Accumulate red, green and blue values for each non-saturated items over a\n\ns/items/item/\n\n> + * zone. Items can for instance be pixels, but also the average of groups of\n> + * pixels, depending on who uses the accumulator.\n> * \\todo move this description and structure into a common header\n> *\n> * Cells which are saturated beyond the threshold defined in\n\nAre these 'cells' references still valid here too?\n\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7CE85BF415\n\tfor ;\n\tMon, 25 Oct 2021 20:15:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E175C64878;\n\tMon, 25 Oct 2021 22:15:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 763DA60125\n\tfor ;\n\tMon, 25 Oct 2021 22:15:05 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 12EE2E0A;\n\tMon, 25 Oct 2021 22:15:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"miygL4N6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635192905;\n\tbh=6mg6+Fz7gzEEK/QQWNvL/3zkmV02hRcaUpZKvyEhdFA=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=miygL4N6fMnWsQj+bQHSbA3CeS6UG0OYbSEf6uwkq60uqc5obZRJXQ54r8wvx11Nf\n\tcDyqVoB0VnZp2NNxfQA5m7vu5CtmNCR4uhFi3bFI+90WnKDm0omQJPdJrBA+i3Yk3c\n\t1xseZC9SAuybOZCAJjLo1vqWDJXsaNm+EB7CQ62o=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211022151218.111966-7-jeanmichel.hautbois@ideasonboard.com>","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-7-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 25 Oct 2021 21:15:03 +0100","Message-ID":"<163519290301.1095920.13633668868831810323@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v3 06/19] ipa: ipu3: awb: Reword\n\taccumulator documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20461,"web_url":"https://patchwork.libcamera.org/comment/20461/","msgid":"","date":"2021-10-25T20:36:29","subject":"Re: [libcamera-devel] [PATCH v3 06/19] ipa: ipu3: awb: Reword\n\taccumulator documentation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Oct 25, 2021 at 09:15:03PM +0100, Kieran Bingham wrote:\n> Quoting Jean-Michel Hautbois (2021-10-22 16:12:05)\n> > Now that we moved the diagram into the AWB class documentation, reword the\n> > accumulator documentation to make it clear it is not meant to be used\n> > only in AWB.\n> > \n> > Signed-off-by: Jean-Michel Hautbois \n> > ---\n> > src/ipa/ipu3/algorithms/awb.cpp | 6 +++---\n> > 1 file changed, 3 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n> > index 7e10460f..101d84ca 100644\n> > --- a/src/ipa/ipu3/algorithms/awb.cpp\n> > +++ b/src/ipa/ipu3/algorithms/awb.cpp\n> > @@ -46,9 +46,9 @@ static constexpr uint32_t kMinCellsPerZoneRatio = 255 * 90 / 100;\n> > * \\struct Accumulator\n> > * \\brief RGB statistics for a given zone\n> > *\n> > - * The Accumulator structure stores the sum of the average of each cell in a\n> > - * zone of the image, as well as the number of cells which were unsaturated and\n> > - * therefore included in the average.\n> > + * Accumulate red, green and blue values for each non-saturated items over a\n> \n> s/items/item/\n> \n> > + * zone. Items can for instance be pixels, but also the average of groups of\n> > + * pixels, depending on who uses the accumulator.\n> > * \\todo move this description and structure into a common header\n> > *\n> > * Cells which are saturated beyond the threshold defined in\n> \n> Are these 'cells' references still valid here too?\n\nI think this should now be zones.\n\nReviewed-by: Laurent Pinchart ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFD43BF415\n\tfor ;\n\tMon, 25 Oct 2021 20:36:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 376C064878;\n\tMon, 25 Oct 2021 22:36:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C42B60125\n\tfor ;\n\tMon, 25 Oct 2021 22:36:52 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C8A3CE0A;\n\tMon, 25 Oct 2021 22:36:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bIT0Z3T4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635194212;\n\tbh=CM1Da4NOJO1swgxPC3Np2dXWSXJHdlbQORqq1osnvYo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bIT0Z3T44k1Laj5ZKBwj1CEjJa60Sf/rvpmBpABy6yYlE+7hIIzvdzy1R6armiBiY\n\tk73LqLYAdfxReMJdz8Vf9xzTdabJX4Y0Ty4K61/TqqyxX2hVuBZ2eql4riq5W1vWNl\n\t4i8aIrx0CrEpCPSSc0OakYGrY/gFva18S4qJGwFw=","Date":"Mon, 25 Oct 2021 23:36:29 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-7-jeanmichel.hautbois@ideasonboard.com>\n\t<163519290301.1095920.13633668868831810323@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<163519290301.1095920.13633668868831810323@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v3 06/19] ipa: ipu3: awb: Reword\n\taccumulator documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]