{"id":14272,"url":"https://patchwork.libcamera.org/api/patches/14272/?format=json","web_url":"https://patchwork.libcamera.org/patch/14272/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211022151218.111966-7-jeanmichel.hautbois@ideasonboard.com>","date":"2021-10-22T15:12:05","name":"[libcamera-devel,v3,06/19] ipa: ipu3: awb: Reword accumulator documentation","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"d0fdfd4af452185d6aa4ec0baf0966d691612c08","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14272/mbox/","series":[{"id":2651,"url":"https://patchwork.libcamera.org/api/series/2651/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2651","date":"2021-10-22T15:11:59","name":"Document IPU3 IPA","version":3,"mbox":"https://patchwork.libcamera.org/series/2651/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14272/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14272/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8EDEFBF415\n\tfor ;\n\tFri, 22 Oct 2021 15:12:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1BAB268F61;\n\tFri, 22 Oct 2021 17:12:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D61E168F5C\n\tfor ;\n\tFri, 22 Oct 2021 17:12:23 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:22cc:3af6:5ccb:8367])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 991C189A;\n\tFri, 22 Oct 2021 17:12:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c9tKl0N3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634915543;\n\tbh=qPeuLijXA17mtOuZ2datd9REf3z0/MMyO2ol6N2gCvw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=c9tKl0N370AgOXQRPVok8YfH1oCevpxCIqV4TCEEL65TkFFwHNRr4hR6ckqHRn1xz\n\t0JHxrWDpWvTjFi/LxYvc5tZV9H5j3Av2E6V1qf0o7nbsj8t9jttnAjrpoe5NjP2fC7\n\tbFB/bgE/ZarwXtCKYFHq5lqT6Sgh2Dy5Aqgg65q0=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 22 Oct 2021 17:12:05 +0200","Message-Id":"<20211022151218.111966-7-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 06/19] ipa: ipu3: awb: Reword\n\taccumulator documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that we moved the diagram into the AWB class documentation, reword the\naccumulator documentation to make it clear it is not meant to be used\nonly in AWB.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/algorithms/awb.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 7e10460f..101d84ca 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -46,9 +46,9 @@ static constexpr uint32_t kMinCellsPerZoneRatio = 255 * 90 / 100;\n * \\struct Accumulator\n * \\brief RGB statistics for a given zone\n *\n- * The Accumulator structure stores the sum of the average of each cell in a\n- * zone of the image, as well as the number of cells which were unsaturated and\n- * therefore included in the average.\n+ * Accumulate red, green and blue values for each non-saturated items over a\n+ * zone. Items can for instance be pixels, but also the average of groups of\n+ * pixels, depending on who uses the accumulator.\n * \\todo move this description and structure into a common header\n *\n * Cells which are saturated beyond the threshold defined in\n","prefixes":["libcamera-devel","v3","06/19"]}