[{"id":20454,"web_url":"https://patchwork.libcamera.org/comment/20454/","msgid":"<163519224936.1095920.9040255854705708322@Monstersaurus>","date":"2021-10-25T20:04:09","subject":"Re: [libcamera-devel] [PATCH v3 04/19] ipa: ipu3: Explicitly use\n\tthe statistics parameter","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-10-22 16:12:03)\n> The stats pointer is marked as [[maybe_unused]]. This is a leftover from\n> a previous commit which was here to keep the compatibility while\n> transitioning to the new iterative algorithms.\n> \n> Remove this attribute to make it explicit that stats are really used to\n> feed the algorithms.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Kieran Bingham \n\n> Reviewed-by: Laurent Pinchart \n> ---\n> src/ipa/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index c5461d8e..cd27872b 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -715,7 +715,7 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)\n> */\n> void IPAIPU3::parseStatistics(unsigned int frame,\n> [[maybe_unused]] int64_t frameTimestamp,\n> - [[maybe_unused]] const ipu3_uapi_stats_3a *stats)\n> + const ipu3_uapi_stats_3a *stats)\n> {\n> ControlList ctrls(controls::controls);\n> \n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41D85BDB1C\n\tfor ;\n\tMon, 25 Oct 2021 20:04:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 82A4264878;\n\tMon, 25 Oct 2021 22:04:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EFA6260125\n\tfor ;\n\tMon, 25 Oct 2021 22:04:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9115AE0A;\n\tMon, 25 Oct 2021 22:04:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GOODfF+N\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635192251;\n\tbh=m7CaxX/ey9Qv328J4mTtz3ALvNJ7iCQhUKWzArbI3Wk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=GOODfF+NYCXZURuQPmhLtxHBQafxqYh5zPEGKIs0GZ2i+yOkskrYnJ1XtFbbceTid\n\t6Z9ip7ZUmZP8QkjcvDsADDObNY3ZPJ3D73Vu/ciWga24oG/DXKMfq8d0c3dfxLKCPE\n\tyIbdnMCKgP4d2NPdsre1RAqTzIR4IvY0TzKUBVPQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211022151218.111966-5-jeanmichel.hautbois@ideasonboard.com>","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-5-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 25 Oct 2021 21:04:09 +0100","Message-ID":"<163519224936.1095920.9040255854705708322@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v3 04/19] ipa: ipu3: Explicitly use\n\tthe statistics parameter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20514,"web_url":"https://patchwork.libcamera.org/comment/20514/","msgid":"<45bcab98-2fe4-2fa2-b874-083d28ff4fbf@ideasonboard.com>","date":"2021-10-26T07:59:59","subject":"Re: [libcamera-devel] [PATCH v3 04/19] ipa: ipu3: Explicitly use\n\tthe statistics parameter","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi JM,\n\nThank you for the patch\n\nOn 10/22/21 8:42 PM, Jean-Michel Hautbois wrote:\n> The stats pointer is marked as [[maybe_unused]]. This is a leftover from\n> a previous commit which was here to keep the compatibility while\n\n\nnit: When we talk about previous commits, probably it's best to mention \ncommit id (\"subject\") as well\n\nAnyways change is good so,\n\nReviewed-by: Umang Jain \n> transitioning to the new iterative algorithms.\n>\n> Remove this attribute to make it explicit that stats are really used to\n> feed the algorithms.\n>\n> Signed-off-by: Jean-Michel Hautbois \n> Signed-off-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/ipa/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index c5461d8e..cd27872b 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -715,7 +715,7 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)\n> */\n> void IPAIPU3::parseStatistics(unsigned int frame,\n> \t\t\t [[maybe_unused]] int64_t frameTimestamp,\n> -\t\t\t [[maybe_unused]] const ipu3_uapi_stats_3a *stats)\n> +\t\t\t const ipu3_uapi_stats_3a *stats)\n> {\n> \tControlList ctrls(controls::controls);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E01DBDB1C\n\tfor ;\n\tTue, 26 Oct 2021 08:00:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6188364878;\n\tTue, 26 Oct 2021 10:00:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8B6760123\n\tfor ;\n\tTue, 26 Oct 2021 10:00:03 +0200 (CEST)","from [192.168.1.106] (unknown [103.251.226.211])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A6073F0;\n\tTue, 26 Oct 2021 10:00:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"djztj09m\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635235203;\n\tbh=Ok4erUx7vnGYowS//22axFT7BZUOzbzm6h+r7cr3gK4=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=djztj09mFXacVeee5/2nN8HJtN21bIkpue0ItJ9nxOYUjlwiJ4MlvTzhw6WODx8Xo\n\tvYi/SYCt4Pz2VdeO/vpci3SEz8lNKf+yvdYXlfgShXPiurdWQRTvMjNdPy3zi7tF/a\n\t63wGUXvL+VhoacwfEC5IwwHLr5IA4xNaVw5Njawc=","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-5-jeanmichel.hautbois@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<45bcab98-2fe4-2fa2-b874-083d28ff4fbf@ideasonboard.com>","Date":"Tue, 26 Oct 2021 13:29:59 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211022151218.111966-5-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v3 04/19] ipa: ipu3: Explicitly use\n\tthe statistics parameter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]