[{"id":20453,"web_url":"https://patchwork.libcamera.org/comment/20453/","msgid":"","date":"2021-10-25T19:59:16","subject":"Re: [libcamera-devel] [PATCH v3 02/19] ipa: ipu3: Document\n\tIPAIPU3::configure","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Fri, Oct 22, 2021 at 05:12:01PM +0200, Jean-Michel Hautbois wrote:\n> Further extend the documentation for the IPAIPU3::configure operation.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 15 +++++++++++++++\n> 1 file changed, 15 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index b5438ed1..6e28a5aa 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -502,6 +502,21 @@ void IPAIPU3::calculateBdsGrid(const Size &bdsOutputSize)\n> \t\t\t << (int)bdsGrid.height << \" << \" << (int)bdsGrid.block_height_log2 << \")\";\n> }\n> \n> +/**\n> + * \\brief Configure the IPU3 IPA\n> + * \\param[in] configInfo The IPA configuration data, received from the pipeline\n> + * handler\n> + * \\param[in] ipaControls The IPA controls to update\n> + *\n> + * Calculate the best grid for the statistics based on the Pipeline Handler BDS\n> + * output, and parse the minimum and maximum exposure and analogue gain control\n> + * values.\n> + *\n> + * \\todo Document what the BDS is, ideally in a block diagram of the ImgU.\n> + *\n> + * All algorithm modules are called to allow them to prepare the\n> + * \\a IPASessionConfiguration structure for the \\a IPAContext.\n> + */\n> int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n> \t\t ControlInfoMap *ipaControls)\n> {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 396D5BF415\n\tfor ;\n\tMon, 25 Oct 2021 19:59:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AAA4D64878;\n\tMon, 25 Oct 2021 21:59:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7475960125\n\tfor ;\n\tMon, 25 Oct 2021 21:59:38 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DE846E0A;\n\tMon, 25 Oct 2021 21:59:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XF7rxeyC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635191978;\n\tbh=Y+uJa0Dkh5tqdA5dGq7kM89uexKdIPR1TdE0L3VMu00=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XF7rxeyCN1sMk5FvFQtW8akmLPhHm83AusZkTopJsz6UIik3g3Gr3RebaxQpirzqA\n\t9/RcLjVN0cK6pGCOspKGhUSdPx9DDUfKtlTZriaNk2QS9LvtxsGknmWjzVsrai5hhH\n\tmtgVkf5ki2sP284WEqD6x4uwbL28njOFaSSoH5jo=","Date":"Mon, 25 Oct 2021 22:59:16 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-3-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211022151218.111966-3-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 02/19] ipa: ipu3: Document\n\tIPAIPU3::configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20457,"web_url":"https://patchwork.libcamera.org/comment/20457/","msgid":"<163519252428.1095920.5022215459658790872@Monstersaurus>","date":"2021-10-25T20:08:44","subject":"Re: [libcamera-devel] [PATCH v3 02/19] ipa: ipu3: Document\n\tIPAIPU3::configure","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-10-22 16:12:01)\n> Further extend the documentation for the IPAIPU3::configure operation.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Signed-off-by: Kieran Bingham \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 15 +++++++++++++++\n> 1 file changed, 15 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index b5438ed1..6e28a5aa 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -502,6 +502,21 @@ void IPAIPU3::calculateBdsGrid(const Size &bdsOutputSize)\n> << (int)bdsGrid.height << \" << \" << (int)bdsGrid.block_height_log2 << \")\";\n> }\n> \n> +/**\n> + * \\brief Configure the IPU3 IPA\n> + * \\param[in] configInfo The IPA configuration data, received from the pipeline\n> + * handler\n> + * \\param[in] ipaControls The IPA controls to update\n> + *\n> + * Calculate the best grid for the statistics based on the Pipeline Handler BDS\n> + * output, and parse the minimum and maximum exposure and analogue gain control\n> + * values.\n> + *\n> + * \\todo Document what the BDS is, ideally in a block diagram of the ImgU.\n> + *\n> + * All algorithm modules are called to allow them to prepare the\n> + * \\a IPASessionConfiguration structure for the \\a IPAContext.\n> + */\n> int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n> ControlInfoMap *ipaControls)\n> {\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C43C6BF415\n\tfor ;\n\tMon, 25 Oct 2021 20:08:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7FF0264878;\n\tMon, 25 Oct 2021 22:08:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E376F60125\n\tfor ;\n\tMon, 25 Oct 2021 22:08:46 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D2C9E0A;\n\tMon, 25 Oct 2021 22:08:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CzMD4cZN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635192526;\n\tbh=OVZde+agfGml05hnoMlmk04UrLZchSa3VXF1BzMdE5Y=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=CzMD4cZN3DxwLIhRQvAzVFJf93GV+gx6UERF7KOhrqsD12mlc/4hSjZCnMnzN6///\n\tl6ostD7gudbJt/Uh/naQhjFWrA/ij6oiThMsNksVLlJsAt41CqIJ6SoimRfcMfNaDu\n\tqKOVuaDWGXtiHOLLb4mpgp8LMMvW9dBDFAYyf1/M=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211022151218.111966-3-jeanmichel.hautbois@ideasonboard.com>","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-3-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 25 Oct 2021 21:08:44 +0100","Message-ID":"<163519252428.1095920.5022215459658790872@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v3 02/19] ipa: ipu3: Document\n\tIPAIPU3::configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20513,"web_url":"https://patchwork.libcamera.org/comment/20513/","msgid":"<98173498-a362-7a91-5abf-b7caa771c30e@ideasonboard.com>","date":"2021-10-26T07:56:22","subject":"Re: [libcamera-devel] [PATCH v3 02/19] ipa: ipu3: Document\n\tIPAIPU3::configure","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi JM,\n\nThank you for the patch\n\nOn 10/22/21 8:42 PM, Jean-Michel Hautbois wrote:\n> Further extend the documentation for the IPAIPU3::configure operation.\n>\n> Signed-off-by: Jean-Michel Hautbois \n> Signed-off-by: Kieran Bingham \n\n\nReviewed-by: Umang Jain \n> ---\n> src/ipa/ipu3/ipu3.cpp | 15 +++++++++++++++\n> 1 file changed, 15 insertions(+)\n>\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index b5438ed1..6e28a5aa 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -502,6 +502,21 @@ void IPAIPU3::calculateBdsGrid(const Size &bdsOutputSize)\n> \t\t\t << (int)bdsGrid.height << \" << \" << (int)bdsGrid.block_height_log2 << \")\";\n> }\n> \n> +/**\n> + * \\brief Configure the IPU3 IPA\n> + * \\param[in] configInfo The IPA configuration data, received from the pipeline\n> + * handler\n> + * \\param[in] ipaControls The IPA controls to update\n> + *\n> + * Calculate the best grid for the statistics based on the Pipeline Handler BDS\n> + * output, and parse the minimum and maximum exposure and analogue gain control\n> + * values.\n> + *\n> + * \\todo Document what the BDS is, ideally in a block diagram of the ImgU.\n> + *\n> + * All algorithm modules are called to allow them to prepare the\n> + * \\a IPASessionConfiguration structure for the \\a IPAContext.\n> + */\n> int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n> \t\t ControlInfoMap *ipaControls)\n> {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E37B7BF415\n\tfor ;\n\tTue, 26 Oct 2021 07:56:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C60664878;\n\tTue, 26 Oct 2021 09:56:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19A3660123\n\tfor ;\n\tTue, 26 Oct 2021 09:56:27 +0200 (CEST)","from [192.168.1.106] (unknown [103.251.226.211])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4EE1B3F0;\n\tTue, 26 Oct 2021 09:56:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SPPixKRe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635234986;\n\tbh=smRJwdvsbvd3fgJnz57n71aQUV0EpuTs+jzdMBdkiWM=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=SPPixKRe2UTuwbs3oYy97zIb5xYzFceI9dYFGfQcA5WxsscxfBdx+/Y5W2QOCeVs8\n\tMgDFQsLl8mGHupaby1oDx+LIiyHAYBU6oDlltf2wMX3sESs2u+AlIQBub3frXj447f\n\tBg+A+S/A6uQn67WRlv123EWc9o6Js+YQ8Koz4wOs=","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211022151218.111966-3-jeanmichel.hautbois@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<98173498-a362-7a91-5abf-b7caa771c30e@ideasonboard.com>","Date":"Tue, 26 Oct 2021 13:26:22 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211022151218.111966-3-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v3 02/19] ipa: ipu3: Document\n\tIPAIPU3::configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]