{"id":14244,"url":"https://patchwork.libcamera.org/api/patches/14244/?format=json","web_url":"https://patchwork.libcamera.org/patch/14244/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211022073249.35084-9-jeanmichel.hautbois@ideasonboard.com>","date":"2021-10-22T07:32:43","name":"[libcamera-devel,v4,08/14] ipa: ipu3: agc: Use filtered exposure values","commit_ref":"f1cf01d13b729f0f6efeef07012605577f31ee69","pull_url":null,"state":"accepted","archived":false,"hash":"57f193f81c8eb4f93e96c5a15ea9ec1b3b6325fc","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14244/mbox/","series":[{"id":2647,"url":"https://patchwork.libcamera.org/api/series/2647/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2647","date":"2021-10-22T07:32:35","name":"ipa: ipu3: Fix AGC bugs","version":4,"mbox":"https://patchwork.libcamera.org/series/2647/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14244/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14244/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 74416BF415\n\tfor ;\n\tFri, 22 Oct 2021 07:33:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D5AA68F5C;\n\tFri, 22 Oct 2021 09:33:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BF4F668F5F\n\tfor ;\n\tFri, 22 Oct 2021 09:32:55 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:22cc:3af6:5ccb:8367])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6F24F51D;\n\tFri, 22 Oct 2021 09:32:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TofM8+Gp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634887975;\n\tbh=OhFZNy72TZun+WkypWA4XRCIcYlrh0lqNLNyg/J5reI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=TofM8+GpL44t/Tx6HEoBD9Tuvjbf9Ada561a91Zw80vxdQ9vlrrv+KXYK3lGe/mAx\n\tDDFxOGJu+0GApFEaZtQvdTxaJ2admSz8KwHUHKiiTHQQycqHz8vX3ULRRf/li3CN9G\n\tvZBsmJNl/34m4oNhdJPi3EkEaEvzTcyvKeeoBHbs=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 22 Oct 2021 09:32:43 +0200","Message-Id":"<20211022073249.35084-9-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211022073249.35084-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211022073249.35084-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 08/14] ipa: ipu3: agc: Use filtered\n\texposure values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We are filtering the exposure value to limit the gain to apply, but we\nare not using the result.\n\nFix it.\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/ipa/ipu3/algorithms/agc.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 984aed53..f5bb3328 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -158,17 +158,17 @@ void Agc::lockExposureGain(uint32_t &exposure, double &gain)\n \n \t\tutils::Duration newExposure = 0.0s;\n \t\tif (currentShutter < maxShutterSpeed) {\n-\t\t\texposure = std::clamp(exposure * currentExposure_ / currentExposureNoDg_,\n+\t\t\texposure = std::clamp(exposure * filteredExposure_ / currentExposureNoDg_,\n \t\t\t\t\t\t\tminExposureLines_,\n \t\t\t\t\t\t\tmaxExposureLines_);\n-\t\t\tnewExposure = currentExposure_ / exposure;\n-\t\t\tgain = std::clamp(gain * currentExposure_ / newExposure,\n+\t\t\tnewExposure = filteredExposure_ / exposure;\n+\t\t\tgain = std::clamp(gain * filteredExposure_ / newExposure,\n \t\t\t\t\t kMinGain, kMaxGain);\n \t\t} else {\n-\t\t\tgain = std::clamp(gain * currentExposure_ / currentExposureNoDg_,\n+\t\t\tgain = std::clamp(gain * filteredExposure_ / currentExposureNoDg_,\n \t\t\t\t\t kMinGain, kMaxGain);\n-\t\t\tnewExposure = currentExposure_ / gain;\n-\t\t\texposure = std::clamp(exposure * currentExposure_ / newExposure,\n+\t\t\tnewExposure = filteredExposure_ / gain;\n+\t\t\texposure = std::clamp(exposure * filteredExposure_ / newExposure,\n \t\t\t\t\t\t\tminExposureLines_,\n \t\t\t\t\t\t\tmaxExposureLines_);\n \t\t}\n","prefixes":["libcamera-devel","v4","08/14"]}