{"id":14242,"url":"https://patchwork.libcamera.org/api/patches/14242/?format=json","web_url":"https://patchwork.libcamera.org/patch/14242/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211022073249.35084-8-jeanmichel.hautbois@ideasonboard.com>","date":"2021-10-22T07:32:42","name":"[libcamera-devel,v4,07/14] ipa: ipu3: agc: Change analogue gain limits","commit_ref":"a58a784e53f4c350a912aa36a1103ee2f259aedb","pull_url":null,"state":"accepted","archived":false,"hash":"0e2fca823f5287330429c4f5e9042e25ecdf3c57","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14242/mbox/","series":[{"id":2647,"url":"https://patchwork.libcamera.org/api/series/2647/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2647","date":"2021-10-22T07:32:35","name":"ipa: ipu3: Fix AGC bugs","version":4,"mbox":"https://patchwork.libcamera.org/series/2647/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14242/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14242/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B3B0C324E\n\tfor ;\n\tFri, 22 Oct 2021 07:33:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1924F68F6E;\n\tFri, 22 Oct 2021 09:33:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 824FE68F57\n\tfor ;\n\tFri, 22 Oct 2021 09:32:55 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:22cc:3af6:5ccb:8367])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3C5BB89A;\n\tFri, 22 Oct 2021 09:32:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U8CwYvZw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634887975;\n\tbh=6jyQp2VcDpoE14IpVTi4Vd171ozQMo+DRVnwXyo9WIA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=U8CwYvZw4LrUuL+bdYRFGCTh5QzpcWvJZSFDgmC36DWnMyJY3fNIZRqHN15b7V4QI\n\tBPVryRw08Qm+OZ9WAxSMn+GlfZKZdFgvM82bFtluujrOT+3WVKaTrDW2aZsz6lCoH0\n\tRwUPRQuLaVBr+KIC0BJacQ+yESCkJrSuu/fqJ/sY=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 22 Oct 2021 09:32:42 +0200","Message-Id":"<20211022073249.35084-8-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211022073249.35084-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211022073249.35084-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 07/14] ipa: ipu3: agc: Change analogue\n\tgain limits","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The gains are currently set as a uint32_t while the analogue gain is\npassed as a double. We also have a default maximum analogue gain of 15\nwhich is quite high for a number of sensors.\n\nUse a maximum value of 8 which should really be configured by the IPA\nand not fixed as it is now. While at it make it a double.\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/ipa/ipu3/algorithms/agc.cpp | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 58872410..984aed53 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -30,14 +30,10 @@ static constexpr uint32_t kInitialFrameMinAECount = 4;\n /* Number of frames to wait between new gain/exposure estimations */\n static constexpr uint32_t kFrameSkipCount = 6;\n \n-/* Maximum ISO value for analogue gain */\n-static constexpr uint32_t kMinISO = 100;\n-static constexpr uint32_t kMaxISO = 1500;\n-\n /* Maximum analogue gain value\n * \\todo grab it from a camera helper */\n-static constexpr uint32_t kMinGain = kMinISO / 100;\n-static constexpr uint32_t kMaxGain = kMaxISO / 100;\n+static constexpr double kMinGain = 1.0;\n+static constexpr double kMaxGain = 8.0;\n \n /* Histogram constants */\n static constexpr uint32_t knumHistogramBins = 256;\n@@ -166,9 +162,11 @@ void Agc::lockExposureGain(uint32_t &exposure, double &gain)\n \t\t\t\t\t\t\tminExposureLines_,\n \t\t\t\t\t\t\tmaxExposureLines_);\n \t\t\tnewExposure = currentExposure_ / exposure;\n-\t\t\tgain = std::clamp(static_cast(gain * currentExposure_ / newExposure), kMinGain, kMaxGain);\n+\t\t\tgain = std::clamp(gain * currentExposure_ / newExposure,\n+\t\t\t\t\t kMinGain, kMaxGain);\n \t\t} else {\n-\t\t\tgain = std::clamp(static_cast(gain * currentExposure_ / currentExposureNoDg_), kMinGain, kMaxGain);\n+\t\t\tgain = std::clamp(gain * currentExposure_ / currentExposureNoDg_,\n+\t\t\t\t\t kMinGain, kMaxGain);\n \t\t\tnewExposure = currentExposure_ / gain;\n \t\t\texposure = std::clamp(exposure * currentExposure_ / newExposure,\n \t\t\t\t\t\t\tminExposureLines_,\n","prefixes":["libcamera-devel","v4","07/14"]}