{"id":14237,"url":"https://patchwork.libcamera.org/api/patches/14237/?format=json","web_url":"https://patchwork.libcamera.org/patch/14237/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211022073249.35084-2-jeanmichel.hautbois@ideasonboard.com>","date":"2021-10-22T07:32:36","name":"[libcamera-devel,v4,01/14] ipa: ipu3: awb: Set a threshold for the green saturation","commit_ref":"59687683a16c64c6821db89c7a1be35b161bf917","pull_url":null,"state":"accepted","archived":false,"hash":"dc6a5c4665ce8c164b97edfd9917850445c8bc1c","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14237/mbox/","series":[{"id":2647,"url":"https://patchwork.libcamera.org/api/series/2647/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2647","date":"2021-10-22T07:32:35","name":"ipa: ipu3: Fix AGC bugs","version":4,"mbox":"https://patchwork.libcamera.org/series/2647/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14237/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14237/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 197CBBF415\n\tfor ;\n\tFri, 22 Oct 2021 07:33:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BF5A268F67;\n\tFri, 22 Oct 2021 09:32:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63A9E68F57\n\tfor ;\n\tFri, 22 Oct 2021 09:32:54 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:22cc:3af6:5ccb:8367])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EFDA389A;\n\tFri, 22 Oct 2021 09:32:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bVGV73do\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634887974;\n\tbh=oX2f7LaB6UO3edalXFu0y5aT46U54qw8zfT+MGW4tEM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bVGV73doJdNyzEkUvIwwaFPflyJRT8PTQKIkjKRyA4pybhjjYzNNdsAY/TKaPg1Bq\n\tT6a4gje/1NnsSkNX2ZxPhP84mOG3XZbiWCFycR69tSoDhrvu1n2TAv9/grsoB9jjGS\n\t/IJsYW+01zFvM5QUOnMV4t7Q6RShG25duIUaNO/I=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 22 Oct 2021 09:32:36 +0200","Message-Id":"<20211022073249.35084-2-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211022073249.35084-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211022073249.35084-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 01/14] ipa: ipu3: awb: Set a threshold\n\tfor the green saturation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We can have a saturation ratio per cell, giving the percentage of pixels\nover a threshold within a cell where 100% is set to 0xff.\n\nThe parameter structure 'ipu3_uapi_awb_config_s' contains four fields to\nset the threshold, one per channel.\nThe blue field is also used to configure the ImgU and make it calculate\nthe saturation ratio or not.\n\nSet a green value saturated when it is more than 230 (90% of the maximum\nvalue 255, coded as 8191). As this is the only channel used for AGC,\nthere is no need to apply it to the other ones.\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n src/ipa/ipu3/algorithms/awb.cpp | 27 +++++++++++++++++++++------\n src/ipa/ipu3/algorithms/awb.h | 1 +\n 2 files changed, 22 insertions(+), 6 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 809de66a..4364928c 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -328,14 +328,29 @@ void Awb::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n \tcontext.frameContext.awb.gains.red = asyncResults_.redGain;\n }\n \n+constexpr uint16_t Awb::threshold(float value)\n+{\n+\t/* AWB thresholds are in the range [0, 8191] */\n+\treturn value * 8191;\n+}\n+\n void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)\n {\n-\tparams->acc_param.awb.config.rgbs_thr_gr = 8191;\n-\tparams->acc_param.awb.config.rgbs_thr_r = 8191;\n-\tparams->acc_param.awb.config.rgbs_thr_gb = 8191;\n-\tparams->acc_param.awb.config.rgbs_thr_b = IPU3_UAPI_AWB_RGBS_THR_B_INCL_SAT\n-\t\t\t\t\t | IPU3_UAPI_AWB_RGBS_THR_B_EN\n-\t\t\t\t\t | 8191;\n+\t/*\n+\t * Green saturation thresholds are reduced because we are using the\n+\t * green channel only in the exposure computation.\n+\t */\n+\tparams->acc_param.awb.config.rgbs_thr_r = threshold(1.0);\n+\tparams->acc_param.awb.config.rgbs_thr_gr = threshold(0.9);\n+\tparams->acc_param.awb.config.rgbs_thr_gb = threshold(0.9);\n+\tparams->acc_param.awb.config.rgbs_thr_b = threshold(1.0);\n+\n+\t/*\n+\t * Enable saturation inclusion on thr_b for ImgU to update the\n+\t * ipu3_uapi_awb_set_item->sat_ratio field.\n+\t */\n+\tparams->acc_param.awb.config.rgbs_thr_b |= IPU3_UAPI_AWB_RGBS_THR_B_INCL_SAT |\n+\t\t\t\t\t\t IPU3_UAPI_AWB_RGBS_THR_B_EN;\n \n \tconst ipu3_uapi_grid_config &grid = context.configuration.grid.bdsGrid;\n \ndiff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\nindex 3b81f600..0c81e39e 100644\n--- a/src/ipa/ipu3/algorithms/awb.h\n+++ b/src/ipa/ipu3/algorithms/awb.h\n@@ -70,6 +70,7 @@ private:\n \tvoid clearAwbStats();\n \tvoid awbGreyWorld();\n \tuint32_t estimateCCT(double red, double green, double blue);\n+\tstatic constexpr uint16_t threshold(float value);\n \n \tstd::vector zones_;\n \tAccumulator awbStats_[kAwbStatsSizeX * kAwbStatsSizeY];\n","prefixes":["libcamera-devel","v4","01/14"]}