[{"id":20363,"web_url":"https://patchwork.libcamera.org/comment/20363/","msgid":"<163484958552.4046931.8952081532686327747@Monstersaurus>","date":"2021-10-21T20:53:05","subject":"Re: [libcamera-devel] [PATCH v3 01/14] ipa: ipu3: awb: Set a\n\tthreshold for the green saturation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-10-21 17:43:48)\n> We can have a saturation ratio per cell, giving the percentage of pixels\n> over a threshold within a cell where 100% is set to 0xff.\n> \n> The parameter structure 'ipu3_uapi_awb_config_s' contains four fields to\n> set the threshold, one per channel.\n> The blue field is also used to configure the ImgU and make it calculate\n> the saturation ratio or not.\n> \n> Set a green value saturated when it is more than 230 (90% of the maximum\n> value 255, coded as 8191). As this is the only channel used for AGC,\n> there is no need to apply it to the other ones.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/ipu3/algorithms/awb.cpp | 27 +++++++++++++++++++++------\n> src/ipa/ipu3/algorithms/awb.h | 1 +\n> 2 files changed, 22 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n> index 809de66a..4364928c 100644\n> --- a/src/ipa/ipu3/algorithms/awb.cpp\n> +++ b/src/ipa/ipu3/algorithms/awb.cpp\n> @@ -328,14 +328,29 @@ void Awb::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n> context.frameContext.awb.gains.red = asyncResults_.redGain;\n> }\n> \n> +constexpr uint16_t Awb::threshold(float value)\n> +{\n> + /* AWB thresholds are in the range [0, 8191] */\n> + return value * 8191;\n> +}\n> +\n> void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)\n> {\n> - params->acc_param.awb.config.rgbs_thr_gr = 8191;\n> - params->acc_param.awb.config.rgbs_thr_r = 8191;\n> - params->acc_param.awb.config.rgbs_thr_gb = 8191;\n> - params->acc_param.awb.config.rgbs_thr_b = IPU3_UAPI_AWB_RGBS_THR_B_INCL_SAT\n> - | IPU3_UAPI_AWB_RGBS_THR_B_EN\n> - | 8191;\n> + /*\n> + * Green saturation thresholds are reduced because we are using the\n> + * green channel only in the exposure computation.\n> + */\n> + params->acc_param.awb.config.rgbs_thr_r = threshold(1.0);\n> + params->acc_param.awb.config.rgbs_thr_gr = threshold(0.9);\n> + params->acc_param.awb.config.rgbs_thr_gb = threshold(0.9);\n> + params->acc_param.awb.config.rgbs_thr_b = threshold(1.0);\n> +\n> + /*\n> + * Enable saturation inclusion on thr_b for ImgU to update the\n> + * ipu3_uapi_awb_set_item->sat_ratio field.\n> + */\n> + params->acc_param.awb.config.rgbs_thr_b |= IPU3_UAPI_AWB_RGBS_THR_B_INCL_SAT |\n> + IPU3_UAPI_AWB_RGBS_THR_B_EN;\n> \n> const ipu3_uapi_grid_config &grid = context.configuration.grid.bdsGrid;\n> \n> diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\n> index 3b81f600..0c81e39e 100644\n> --- a/src/ipa/ipu3/algorithms/awb.h\n> +++ b/src/ipa/ipu3/algorithms/awb.h\n> @@ -70,6 +70,7 @@ private:\n> void clearAwbStats();\n> void awbGreyWorld();\n> uint32_t estimateCCT(double red, double green, double blue);\n> + static constexpr uint16_t threshold(float value);\n> \n> std::vector zones_;\n> Accumulator awbStats_[kAwbStatsSizeX * kAwbStatsSizeY];\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5D92BDB1C\n\tfor ;\n\tThu, 21 Oct 2021 20:53:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1856168F56;\n\tThu, 21 Oct 2021 22:53:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F074604FE\n\tfor ;\n\tThu, 21 Oct 2021 22:53:08 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 03A318B6;\n\tThu, 21 Oct 2021 22:53:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WARk3AG9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634849588;\n\tbh=ZE1iYRqREhkVQ07veu2NfwFqB2xNSfgeqsHimiUcqAo=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=WARk3AG9gNveERZJaDZhkkKtLe84cPR4vRTTAmNQIQOx1p9qKHD8f7+9TlEACN+UL\n\t2ZGjB2cvysD+tQ99kqUhf4NCmUdlRG0v/Xc+0ZHu+CmqM/SzjCJnVIQJNlgJF/oIVW\n\tSbRfT1uEH6srBK/IR9Y1d3g5VvY//mReEaPLMtAE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211021164401.110033-2-jeanmichel.hautbois@ideasonboard.com>","References":"<20211021164401.110033-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211021164401.110033-2-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 21 Oct 2021 21:53:05 +0100","Message-ID":"<163484958552.4046931.8952081532686327747@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v3 01/14] ipa: ipu3: awb: Set a\n\tthreshold for the green saturation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]