[{"id":20349,"web_url":"https://patchwork.libcamera.org/comment/20349/","msgid":"","date":"2021-10-21T02:37:12","subject":"Re: [libcamera-devel] [PATCH v2 12/13] ipa: ipu3: agc: Remove\n\tunused variables","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Wed, Oct 20, 2021 at 05:46:06PM +0200, Jean-Michel Hautbois wrote:\n> We currently control the exposure value by the shutter speed and the\n> analogue gain. We can't use the digital gain to have more than the\n> maximum exposure value calculated because we are not controlling it.\n> \n> Remove unused code associated with this digital gain.\n> \n> Signed-off-by: Jean-Michel Hautbois \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/ipu3/algorithms/agc.cpp | 19 +++----------------\n> src/ipa/ipu3/algorithms/agc.h | 2 --\n> 2 files changed, 3 insertions(+), 18 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\n> index 0417dc99..fc37eca4 100644\n> --- a/src/ipa/ipu3/algorithms/agc.cpp\n> +++ b/src/ipa/ipu3/algorithms/agc.cpp\n> @@ -42,8 +42,7 @@ static constexpr double kEvGainTarget = 0.5;\n> Agc::Agc()\n> \t: frameCount_(0), lastFrame_(0), iqMean_(0.0), lineDuration_(0s),\n> \t minExposureLines_(0), maxExposureLines_(0), filteredExposure_(0s),\n> -\t filteredExposureNoDg_(0s), currentExposure_(0s),\n> -\t currentExposureNoDg_(0s), prevExposureValue_(0s)\n> +\t currentExposure_(0s), prevExposureValue_(0s)\n> {\n> }\n> \n> @@ -102,7 +101,6 @@ void Agc::filterExposure()\n> \tif (filteredExposure_ == 0s) {\n> \t\t/* DG stands for digital gain.*/\n> \t\tfilteredExposure_ = currentExposure_;\n> -\t\tfilteredExposureNoDg_ = currentExposureNoDg_;\n> \t} else {\n> \t\t/*\n> \t\t * If we are close to the desired result, go faster to avoid making\n> @@ -115,18 +113,8 @@ void Agc::filterExposure()\n> \n> \t\tfilteredExposure_ = speed * currentExposure_ +\n> \t\t\t\tfilteredExposure_ * (1.0 - speed);\n> -\t\tfilteredExposureNoDg_ = speed * currentExposureNoDg_ +\n> -\t\t\t\tfilteredExposureNoDg_ * (1.0 - speed);\n> \t}\n> -\t/*\n> -\t * We can't let the no_dg exposure deviate too far below the\n> -\t * total exposure, as there might not be enough digital gain available\n> -\t * in the ISP to hide it (which will cause nasty oscillation).\n> -\t */\n> -\tdouble fastReduceThreshold = 0.4;\n> -\tif (filteredExposureNoDg_ <\n> -\t filteredExposure_ * fastReduceThreshold)\n> -\t\tfilteredExposureNoDg_ = filteredExposure_ * fastReduceThreshold;\n> +\n> \tLOG(IPU3Agc, Debug) << \"After filtering, total_exposure \" << filteredExposure_;\n> }\n> \n> @@ -142,8 +130,7 @@ void Agc::lockExposureGain(uint32_t &exposure, double &analogueGain)\n> \n> \t/* extracted from Rpi::Agc::computeTargetExposure */\n> \tutils::Duration currentShutter = exposure * lineDuration_;\n> -\tcurrentExposureNoDg_ = currentShutter * analogueGain;\n> -\tLOG(IPU3Agc, Debug) << \"Actual total exposure \" << currentExposureNoDg_\n> +\tLOG(IPU3Agc, Debug) << \"Actual total exposure \" << currentShutter * analogueGain\n> \t\t\t << \" Shutter speed \" << currentShutter\n> \t\t\t << \" Gain \" << analogueGain\n> \t\t\t << \" Needed ev gain \" << evGain;\n> diff --git a/src/ipa/ipu3/algorithms/agc.h b/src/ipa/ipu3/algorithms/agc.h\n> index 2ae88e9f..ad133b98 100644\n> --- a/src/ipa/ipu3/algorithms/agc.h\n> +++ b/src/ipa/ipu3/algorithms/agc.h\n> @@ -46,9 +46,7 @@ private:\n> \tuint32_t maxExposureLines_;\n> \n> \tutils::Duration filteredExposure_;\n> -\tutils::Duration filteredExposureNoDg_;\n> \tutils::Duration currentExposure_;\n> -\tutils::Duration currentExposureNoDg_;\n> \tutils::Duration prevExposureValue_;\n> \n> \tuint32_t stride_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4638CBDB1C\n\tfor ;\n\tThu, 21 Oct 2021 02:37:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0988268F58;\n\tThu, 21 Oct 2021 04:37:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F79B60124\n\tfor ;\n\tThu, 21 Oct 2021 04:37:31 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DCDBF326;\n\tThu, 21 Oct 2021 04:37:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"koZ4P6LA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634783851;\n\tbh=XpkWfWX2zFrDkfnNo3jcSg1arAJnzVzo7ndQQbGrVMo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=koZ4P6LAdCrZvef5bWB1MGR0Xuix55EdmLDSiw/NTGopK/9DSu972oh2yarV//odV\n\tFvG+E6kXT+5U0zMFQrUdemivlHaUIxEUwoesZlHAmMEmb3Y6FoUhpmCbdCZwBnH7ym\n\tXFue3ktKsN4833uztdozy0V9954PvD2hnTl4NPGU=","Date":"Thu, 21 Oct 2021 05:37:12 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20211020154607.180161-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211020154607.180161-13-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211020154607.180161-13-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 12/13] ipa: ipu3: agc: Remove\n\tunused variables","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]