{"id":14214,"url":"https://patchwork.libcamera.org/api/patches/14214/?format=json","web_url":"https://patchwork.libcamera.org/patch/14214/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211020154607.180161-8-jeanmichel.hautbois@ideasonboard.com>","date":"2021-10-20T15:46:01","name":"[libcamera-devel,v2,07/13] ipa: ipu3: agc: Change analogue gain limits","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ce2c7be78441d72a86f3d2f407428f3227376de1","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14214/mbox/","series":[{"id":2645,"url":"https://patchwork.libcamera.org/api/series/2645/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2645","date":"2021-10-20T15:45:54","name":"ipa: ipu3: Fix AGC bugs","version":2,"mbox":"https://patchwork.libcamera.org/series/2645/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14214/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14214/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB4CBC324F\n\tfor ;\n\tWed, 20 Oct 2021 15:46:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7766868F63;\n\tWed, 20 Oct 2021 17:46:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A0CDC68F57\n\tfor ;\n\tWed, 20 Oct 2021 17:46:14 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:ce4b:1c5f:7302:b899])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 49BA62A5;\n\tWed, 20 Oct 2021 17:46:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i3jhckUQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634744774;\n\tbh=B/VsM9zQtm7SbexqWytoAdNcJXlyttyznXLHwU8UZLo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=i3jhckUQO59x5QyhRNeUgd1mqnRcqzOPJTkJBlYYaPcflIvCNhYLcYkxs5VILMEZt\n\ttH0jlngY9zYqXVL36VvKn38kw0YzEvH4EHyfnJ2O8BdDMqt0GAlqKMQhr9tpYjLB4m\n\tCXgDVnEaKmjuHyGER0nfYc7srBjfl15C3lb3aVd8=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 20 Oct 2021 17:46:01 +0200","Message-Id":"<20211020154607.180161-8-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211020154607.180161-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211020154607.180161-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 07/13] ipa: ipu3: agc: Change analogue\n\tgain limits","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The gains is currently set as a uint32_t while the analogue gain is\npassed as a double. We also have a default maximum analogue gain of 15\nwhich is quite high for a number of sensors.\n\nUse a maximum value of 8 which should really be configured by the IPA\nand not fixed as it is now. While at it make it a double.\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/ipa/ipu3/algorithms/agc.cpp | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 8e1b6d8c..1bae1eb9 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -30,14 +30,10 @@ static constexpr uint32_t kInitialFrameMinAECount = 4;\n /* Number of frames to wait between new gain/exposure estimations */\n static constexpr uint32_t kFrameSkipCount = 6;\n \n-/* Maximum ISO value for analogue gain */\n-static constexpr uint32_t kMinISO = 100;\n-static constexpr uint32_t kMaxISO = 1500;\n-\n /* Maximum analogue gain value\n * \\todo grab it from a camera helper */\n-static constexpr uint32_t kMinGain = kMinISO / 100;\n-static constexpr uint32_t kMaxGain = kMaxISO / 100;\n+static constexpr double kMinGain = 1.0;\n+static constexpr double kMaxGain = 8.0;\n \n /* Histogram constants */\n static constexpr uint32_t knumHistogramBins = 256;\n@@ -165,9 +161,11 @@ void Agc::lockExposureGain(uint32_t &exposure, double &gain)\n \t\t\t\t\t\t\tminExposureLines_,\n \t\t\t\t\t\t\tmaxExposureLines_);\n \t\t\tnewExposure = currentExposure_ / exposure;\n-\t\t\tgain = std::clamp(static_cast(gain * currentExposure_ / newExposure), kMinGain, kMaxGain);\n+\t\t\tgain = std::clamp(gain * currentExposure_ / newExposure,\n+\t\t\t\t\t kMinGain, kMaxGain);\n \t\t} else if (currentShutter >= maxShutterSpeed) {\n-\t\t\tgain = std::clamp(static_cast(gain * currentExposure_ / currentExposureNoDg_), kMinGain, kMaxGain);\n+\t\t\tgain = std::clamp(gain * currentExposure_ / currentExposureNoDg_,\n+\t\t\t\t\t kMinGain, kMaxGain);\n \t\t\tnewExposure = currentExposure_ / gain;\n \t\t\texposure = std::clamp(exposure * currentExposure_ / newExposure,\n \t\t\t\t\t\t\tminExposureLines_,\n","prefixes":["libcamera-devel","v2","07/13"]}